From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
"Liam R. Howlett" <liam@infradead.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Elkin Cruz <elkin@google.com>
Subject: Re: [PATCH] mm/backing-dev: pass "%s" format string to device_create() in bdi_register_va()
Date: Thu, 19 Nov 2026 18:26:34 +0000 [thread overview]
Message-ID: <av8_U9OpmR7FtHzh@gremlin> (raw)
In-Reply-To: <20261119170517.1515872-1-irogers@google.com>
On Thu, Nov 19, 2026 at 09:05:17AM -0800, Ian Rogers wrote:
> bdi_register_va() formats (fmt, args) into bdi->dev_name via vsnprintf()
> and then passes bdi->dev_name directly as the format string argument to
> device_create(), causing vsnprintf() to run a second time on the already
> formatted device name with no variadic arguments. If a caller formats an
> identifier containing '%', device_create() interprets it as format
> specifiers and reads arbitrary stack slots.
>
> Pass "%s", bdi->dev_name to device_create().
>
> Found via an x86_64 LLVM=1 (Clang 21.1.8) allyesconfig audit with
> -Wformat-security enabled; fix and changelog drafted with an AI coding
> assistant. Build-tested under LLVM=1 W=1 and -Wformat-security; not
> runtime-tested with '%' in backing-device names.
>
> Fixes: 6bd87eec23cb ("bdi: add a ->dev_name field to struct backing_dev_info")
> Signed-off-by: Ian Rogers <irogers@google.com>
Seems reasonable so:
Acked-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> ---
> mm/backing-dev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/backing-dev.c b/mm/backing-dev.c
> index fad1495d3b20..58373d494d92 100644
> --- a/mm/backing-dev.c
> +++ b/mm/backing-dev.c
> @@ -1097,7 +1097,8 @@ int bdi_register_va(struct backing_dev_info *bdi, const char *fmt, va_list args)
> return 0;
>
> vsnprintf(bdi->dev_name, sizeof(bdi->dev_name), fmt, args);
> - dev = device_create(&bdi_class, NULL, MKDEV(0, 0), bdi, bdi->dev_name);
> + dev = device_create(&bdi_class, NULL, MKDEV(0, 0), bdi, "%s",
> + bdi->dev_name);
> if (IS_ERR(dev))
> return PTR_ERR(dev);
>
> --
> 2.56.1.708.g77570a6a1d-goog
>
--
Cheers, Lorenzo
prev parent reply other threads:[~2026-11-19 18:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 17:05 [PATCH] mm/backing-dev: pass "%s" format string to device_create() in bdi_register_va() Ian Rogers
2026-11-19 18:26 ` Lorenzo Stoakes (ARM) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av8_U9OpmR7FtHzh@gremlin \
--to=ljs@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=elkin@google.com \
--cc=irogers@google.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox