Re: [PATCH 6.1 000/291] 6.1.135-rc1 review

[He Zhe <zhe.he@windriver.com>]

On 2025/4/24 23:28, Greg Kroah-Hartman wrote:
> On Thu, Apr 24, 2025 at 04:34:04PM +0200, Arnd Bergmann wrote:
>> On Thu, Apr 24, 2025, at 15:41, Greg Kroah-Hartman wrote:
>>> On Thu, Apr 24, 2025 at 07:01:02PM +0530, Naresh Kamboju wrote:
>>>> ## Build error:
>>>> net/sched/act_mirred.c:265:6: error: variable 'is_redirect' is used
>>>> uninitialized whenever 'if' condition is true
>>>> [-Werror,-Wsometimes-uninitialized]
>>>>   265 |         if (unlikely(!(dev->flags & IFF_UP)) ||
>>>> !netif_carrier_ok(dev)) {
>>>>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> Odd this isn't showing up in newer releases, as this is an old commit
>>> and nothing has changed in this file since then (it showed up in 6.8.)
>>>
>>> Is there some follow-up commit somewhere that I'm missing that resolved
>>> this issue?
>> I think the difference is commit 16085e48cb48 ("net/sched: act_mirred:
>> Create function tcf_mirred_to_dev and improve readability") from 
>> v6.8, which adds the initialization that 166c2c8a6a4d ("net/sched:
>> act_mirred: don't override retval if we already lost the skb")
>> relies on.
> Ok, that didn't apply cleanly either, so I'm just going to drop this
> backported patch and wait for the submitter to fix it up and resend it.

Sorry for the inconvenience. We have fixed the above issue found by clang-20
and will sent out v2 soon.

Thanks,
Zhe

>
> thanks,
>
> greg k-h