From: Joe Perches <joe@perches.com>
To: Ian Rogers <irogers@google.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v1] tools clang-format: Add a tools clang-format that overrides some kernel behaviors
Date: Mon, 13 Apr 2026 09:54:37 -0700 [thread overview]
Message-ID: <b4e9f338b8cdc168f90848b8daf321386b863915.camel@perches.com> (raw)
In-Reply-To: <CAP-5=fWteCfNQ7DmwLorcs9h3iH__XK01CrwnJ4-qUfcDCsSSA@mail.gmail.com>
On Mon, 2026-04-13 at 09:19 -0700, Ian Rogers wrote:
> On Mon, Apr 13, 2026 at 8:45 AM Joe Perches <[joe@perches.com](mailto:joe@perches.com)> wrote:
> > On Mon, 2026-04-13 at 08:39 -0700, Ian Rogers wrote:
> On Tue, Apr 7, 2026 at 10:11 AM Joe Perches <[[joe@perches.com](mailto:joe@perches.com)](mailto:[joe@perches.com](mailto:joe@perches.com))> wrote:
> On Tue, 2026-04-07 at 09:55 -0700, Ian Rogers wrote:
> > > Sorting headers is desirable to avoid issues like duplicate includes.
> > > > Perhaps.
> > > > Some others prefer reverse-christmas-tree by length ordering for #includes
> > > > though I think it's poor style.
> > > Thanks Joe. I second not switching to a reverse-christmas-tree style :-)
> > > If this patch is okay, could we bring it in through the perf tree?
> > It's likely better to avoid this suggestion.
> > The issue is that others strongly prefer that reverse-christmas-tree
> > style and would object so nak.
> Presumably that is a kernel suggestion rather than a tools directory
> suggestion. We can move the file into tools/perf, tools/lib/perf, etc.
> if that removes more global concerns. perf hasn't adopted a
> reverse-christmas-tree style.
Fine by me.
Just curious: is this a style control file used by directory depth/path?
next prev parent reply other threads:[~2026-04-13 16:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 16:55 [PATCH v1] tools clang-format: Add a tools clang-format that overrides some kernel behaviors Ian Rogers
2026-04-07 17:11 ` Joe Perches
2026-04-13 15:39 ` Ian Rogers
2026-04-13 15:45 ` Joe Perches
2026-04-13 16:19 ` Ian Rogers
2026-04-13 16:54 ` Joe Perches [this message]
2026-04-13 17:50 ` Ian Rogers
2026-04-14 6:34 ` Namhyung Kim
2026-04-13 16:21 ` Miguel Ojeda
2026-04-28 6:54 ` [PATCH v2] perf clang-format: Add a perf " Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4e9f338b8cdc168f90848b8daf321386b863915.camel@perches.com \
--to=joe@perches.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=irogers@google.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox