From: Tom Rix <trix@redhat.com>
To: Simon Horman <simon.horman@corigine.com>
Cc: isdn@linux-pingi.de, nathan@kernel.org, ndesaulniers@google.com,
kuba@kernel.org, alexanderduyck@fb.com, yangyingliang@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] mISDN: remove unused vpm_read_address function
Date: Thu, 23 Mar 2023 08:18:01 -0700 [thread overview]
Message-ID: <bfc6db20-e094-7fd5-21b5-3d0b81fb494f@redhat.com> (raw)
In-Reply-To: <ZBsArtzFkgz+05LK@corigine.com>
On 3/22/23 6:20 AM, Simon Horman wrote:
> On Tue, Mar 21, 2023 at 08:01:27AM -0400, Tom Rix wrote:
>> clang with W=1 reports
>> drivers/isdn/hardware/mISDN/hfcmulti.c:667:1: error: unused function
>> 'vpm_read_address' [-Werror,-Wunused-function]
>> vpm_read_address(struct hfc_multi *c)
>> ^
>> This function is not used, so remove it.
> Yes, agreed.
>
> But with this patch applied, make CC=clang W=1 tells me:
>
> CALL scripts/checksyscalls.sh
> CC [M] drivers/isdn/hardware/mISDN/hfcmulti.o
> drivers/isdn/hardware/mISDN/hfcmulti.c:643:1: error: unused function 'cpld_read_reg' [-Werror,-Wunused-function]
>
> So perhaps cpld_read_reg should be removed too?
Yes, i will add and respin.
Thanks,
Tom
>
prev parent reply other threads:[~2023-03-23 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 12:01 [PATCH] mISDN: remove unused vpm_read_address function Tom Rix
2023-03-22 13:20 ` Simon Horman
2023-03-23 15:18 ` Tom Rix [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfc6db20-e094-7fd5-21b5-3d0b81fb494f@redhat.com \
--to=trix@redhat.com \
--cc=alexanderduyck@fb.com \
--cc=isdn@linux-pingi.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@corigine.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox