From: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
To: Andrea Righi <andrea.righi@canonical.com>,
Miguel Ojeda <ojeda@kernel.org>,
Alex Gaynor <alex.gaynor@gmail.com>,
Wedson Almeida Filho <wedsonaf@gmail.com>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Nicolas Schier" <nicolas@fjasle.eu>, "Tom Rix" <trix@redhat.com>,
"Eric Curtin" <ecurtin@redhat.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Neal Gompa" <neal@gompa.dev>,
"Arnaldo Carvalho de Melo" <acme@redhat.com>,
rust-for-linux@vger.kernel.org, linux-kbuild@vger.kernel.org,
llvm@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts: rust: drop is_rust_module.sh
Date: Sat, 8 Apr 2023 15:24:53 -0300 [thread overview]
Message-ID: <c0f47367-6352-e55d-1a87-fe2960a84838@gmail.com> (raw)
In-Reply-To: <20230407070517.204676-1-andrea.righi@canonical.com>
On 4/7/23 04:05, Andrea Righi wrote:
> Commit c1177979af9c ("btf, scripts: Exclude Rust CUs with pahole")
> introduced the constraint "!DEBUG_INFO_BTF || PAHOLE_HAS_LANG_EXCLUDE"
> to enable RUST.
>
> With this constraint we don't need is_rust_module.sh anymore, because
> 'pahole --lang_exclude=rust' already has the capability to exclude Rust
> CUs. If pahole isn't recent enough (< 1.24) to support --lang_exclude,
> then DEBUG_INFO_BTF can't be enabled with RUST and is_rust_module.sh
> isn't used as well.
>
> In any case is_rust_module.sh is obsolete and we can just drop it.
>
> Link: https://lore.kernel.org/lkml/Y+p2xKIN6TJnQinK@righiandr-XPS-13-7390/
> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
> ---
> [...]
Go on
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
prev parent reply other threads:[~2023-04-08 18:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 7:05 [PATCH] scripts: rust: drop is_rust_module.sh Andrea Righi
2023-04-07 17:53 ` Nathan Chancellor
2023-04-07 19:07 ` Andrea Righi
2023-04-08 10:24 ` Eric Curtin
2023-04-08 10:28 ` Neal Gompa
2023-04-08 13:41 ` Masahiro Yamada
2023-04-08 18:24 ` Martin Rodriguez Reboredo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0f47367-6352-e55d-1a87-fe2960a84838@gmail.com \
--to=yakoyoku@gmail.com \
--cc=acme@redhat.com \
--cc=alex.gaynor@gmail.com \
--cc=andrea.righi@canonical.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=daniel@iogearbox.net \
--cc=ecurtin@redhat.com \
--cc=gary@garyguo.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=neal@gompa.dev \
--cc=nicolas@fjasle.eu \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=trix@redhat.com \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox