From: Niklas Schnelle <schnelle@linux.ibm.com>
To: Arnd Bergmann <arnd@kernel.org>, kernel test robot <lkp@intel.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: [niks:has_ioport_v4 36/41] drivers/usb/host/pci-quirks.c:289:5: warning: no previous prototype for function 'usb_hcd_amd_remote_wakeup_quirk'
Date: Thu, 11 May 2023 11:34:52 +0200 [thread overview]
Message-ID: <c593b7b3f3d42545ca07424a6ab5afb268c150a2.camel@linux.ibm.com> (raw)
In-Reply-To: <73615d5f-d507-42aa-8689-7e80093c9f75@app.fastmail.com>
On Thu, 2023-05-11 at 10:49 +0200, Arnd Bergmann wrote:
> On Thu, May 11, 2023, at 10:06, Niklas Schnelle wrote:
> > On Thu, 2023-05-11 at 09:21 +0200, Arnd Bergmann wrote:
> > > On Thu, May 11, 2023, at 00:31, kernel test robot wrote:
> > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/niks/linux.git
> > > > has_ioport_v4
> > > > head: b873f53aa1a6487f4a450747bd5ee38afad6dfe4
> > > > commit: 216a01adc35d677e5b2db113a4df427faae01e75 [36/41] usb:
> > > > pci-quirks: handle HAS_IOPORT dependencies
> > > > config: x86_64-randconfig-a014
> > > > (https://download.01.org/0day-ci/archive/20230511/202305110634.RGuHbrxM-lkp@intel.com/config)
> > > >
> > > > > > drivers/usb/host/pci-quirks.c:289:5: warning: no previous prototype for function 'usb_hcd_amd_remote_wakeup_quirk' [-Wmissing-prototypes]
> > > > int usb_hcd_amd_remote_wakeup_quirk(struct pci_dev *pdev)
> > > > ^
> > > > drivers/usb/host/pci-quirks.c:289:1: note: declare 'static' if the
> > > > function is not intended to be used outside of this translation unit
> > > > int usb_hcd_amd_remote_wakeup_quirk(struct pci_dev *pdev)
> > > > ^
> > > > static
> > > > 1 warning generated.
> > >
> > > It looks like the declaration was dropped by accident, it should
> > > have been moved into the #ifdef.
> > >
> > > Arnd
> >
> > I think I saw it but assumed that the extern declaration in
> > include/linux/usb/hcd.h was enough. I guess before this was hidden by
> > the missing CONFIG_USB_PCI_AMD. Should be fixed now.
>
> Ok. It looks like linux/usb/hcd.h is just not included in quirks.c,
> so adding an #include should also fix it.
>
> Arnd
It feels a little cleaner to keep it in pci-quirks.h where it was
before the patch. I just wonder if we then also need an #ifdef
CONFIG_USB_PCI_AMD around the extern declaration?
Thanks
Niklas
next prev parent reply other threads:[~2023-05-11 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 22:31 [niks:has_ioport_v4 36/41] drivers/usb/host/pci-quirks.c:289:5: warning: no previous prototype for function 'usb_hcd_amd_remote_wakeup_quirk' kernel test robot
2023-05-11 7:21 ` Arnd Bergmann
2023-05-11 8:06 ` Niklas Schnelle
2023-05-11 8:49 ` Arnd Bergmann
2023-05-11 9:34 ` Niklas Schnelle [this message]
2023-05-11 10:27 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c593b7b3f3d42545ca07424a6ab5afb268c150a2.camel@linux.ibm.com \
--to=schnelle@linux.ibm.com \
--cc=arnd@kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox