From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.208.42 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794283041; b=CUrd7CM+HN320ynKBvWmCh4HcPYf/HKp6fRsVabnc04hQp7rX2LssC3aEWfxfK5mfM+f Q9CH5oqBg4nXwV505MilO4Hc+md1TEZv6i5ZwRdXplcj8eMN15H0XHRSzKnx3utKhBPA1 OdKEwVNeAWg88554Nu9o//lPup5fSVLgKghmCoecYGVuQM0o5srUWZLjTZNmRJHMRkEsu LL/hv4RD1BKmkTDALYIh/3mV0bs0iO6RqaHRkCt+xwwWy02ppzoKkjq7KLox6NaLxDfcO 7CpP9rSzHafzrzSHCqfsqa3bExOQy4ChAtuLX7fmX9An1W5h+lI0SPsDxULKT7xGlxQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794283041; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:MIME-Version: Content-Transfer-Encoding; bh=eceI8dL07kv9yfwsc+DTSqIVxIuF3lFqQT3hh7B4xzA=; b=TBWhEBHXg+jw07i5RZMWSyZ7SirPy0Zd7MVW8hHnUZgOc1aGVm3D7vJ+GfdxCBuAzh7c buiHog0apwxtKqIOo4xygA32gH24gZbvX2JYRDHRNctM6441YH1nnMVf1N0j1yGDX6g9z 9yUOhLgjN4ji8I/uB4m1D7c1rv8KVRgAFfix4QUgzRIgeOH9/kWPyr5+3Wl0NefQAAW8E EPULoJLQLK40EfOsfvYorIKGca38Fh1pCQn3D52hKzlo3IkI1nY5VKF5r7nwe05H6TThS V2OAHppn/7j1rGXawZgrOryAWX9OFAbyWu5dqxgQrbg+ZB8QOFBPG/J8lBu+3zVTgMw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass header.d=cloudflare.com header.i=@cloudflare.com header.a=rsa-sha256 header.s=google09082023 header.b=aF4B9ZUH; arc=none smtp.remote-ip=209.85.208.42 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54532606A326 for ; Tue, 10 Nov 2026 03:57:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 54532606A326 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.a=rsa-sha256 header.s=google09082023 header.b=aF4B9ZUH Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-6b47c1a3c74so1927667a12.3 for ; Mon, 09 Nov 2026 19:57:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1794283040; x=1794887840; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=eceI8dL07kv9yfwsc+DTSqIVxIuF3lFqQT3hh7B4xzA=; b=aF4B9ZUHDWHhEkJuX1rtmXMc7wrvKtWAgMYdrQ3gx/QKxlaYMhK/LJN8HIFxuQTwik Z6qu/dZFLufY0swCpLiqyroXm1T3mfMvD3plGGbLxAqFWvHvZSpv7XMQ3Innlref/Oiu BcwqduXyy52Fhk+xcv4rD8II1WpDLY4XaZt7ckvwpH3QtIGIsKW6HAF5fFmeorItswXt PWB4irb5wW5A/LB9r9+JBo5Z4S1rexOjQJoMhP0bzKPRdYabhHQk1SfeT3wcFtIsXv+L LWd4/VYeVr9Hy8FuOQAKet+ud+MDzdeSWvmOQtIOsACymEh8vxOdVvuKQWJd92LGp+l3 960A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794283040; x=1794887840; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eceI8dL07kv9yfwsc+DTSqIVxIuF3lFqQT3hh7B4xzA=; b=cPsmxttsXYsNwxXbCxTZ+PmKHy9CVL0cigBemoko2im78argG6ikjvTsxfuiP9nUco rBuz2xWlxrko+AyxUWSasldFsFfbWel2PpeE9nos6HoxpixSLqP5u4AIwVwqSS1CmOGi KT5h0flkj/DGNrFJSbtU2wLSeaX+4VegLopBk/9atBGv8p0Si6+2UedxkzcWaEx0vc4D 076sLmJqNaDaYYeHdXCQz0sf7WFjnjtBmWbS/gLfUAhR4jo3EGCIKcfXepQ1Qgegs8B4 KDWogQeNEwy6Wg7sKwjd4lf0AB6aQ/q/pe6tyxwfxEj1hrGAtZQlFSqScG7uzK+b5pOM 4T+A== X-Forwarded-Encrypted: i=1; AL+hErGqxGi8sgPpOFbIY8ZTVilFsq1gi/9yeerdNOjKe0U1MNjPTSgVWc1TxyXcbb3DVhGdlLd3@lists.linux.dev X-Gm-Message-State: APuU4Z/EQQ+RiK9FJ+saCyHBsK3qBKIij1JFdc1X8ihHrXFxRugV1CEB ZMbV9dJNZoe3cId7klw7GOfptj26DvT5QBwDy9B1n+YgHm3rh7iXQ06J6ez9zWBy4LQ= X-Gm-Gg: AYBFou2rbr8jSgBS4kCk4RCKocW3DjNZJLbQEEQ9HcV4hkmgejWw91Jb5qE6oOTPe5s N/u/UYwZqZfC8LT5swo0WF20OdfwgjnjS0ZhfaVgyhWI4pb15bSYsaYFbJ0oLCnuyrBxw1XktVC l2cR8n78npPd3qBlBXXDPqUPp/1bd8jGhYetPQYx4RpaG/9oQziHyK5nJPYVLK50vQLpg3ArRe2 UwmKiJPrvCgF5+2rfbTnbIw1+teFjYMo7L8oV0o/jxQyeQOaMH/LQS+9C4119bUOMu4f3ZaFovN Wkvv8Fd9GewHjhLccmfTiwj5M8YXEhjuK8AazA6lBY9PNxiKIfMKLcaLMRO1OtZCIwJM0rOnkM4 7fAZFC1HybF2SQCbafaXvJGm06V3k8H7gB1Xng8gtvaNhkY/C4EDTr/x3XF338sssVw6+8AhwGd U2GATrgVkZxPB2KDXNoop0thziKB0HOQrsEbZTB/lHqkw/j0fqbZLe41pkittwTWMuYVdK13hsU 4Zugj+PHJKpmVPF7izVbKiNvF/V6XjbKxopj7qyvzkw/A8Yfa8tM5jtnexmKK9NEdeLonmvebRd +41yzN+Zh9S1SvENXL7+GwlG5foKsPRBMgBylLAQ2XAcaBU8n7dRceXrHFl8JUUX X-Received: by 2002:a05:6402:205b:b0:6b7:1d62:3916 with SMTP id 4fb4d7f45d1cf-6b755626b9dmr778195a12.0.1794283039727; Mon, 09 Nov 2026 19:57:19 -0800 (PST) Received: from L9JK9NPFH9.lan ([104.28.20.56]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6b7579047c9sm548801a12.33.2026.11.09.19.57.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 09 Nov 2026 19:57:18 -0800 (PST) From: Tianyi Gao To: bpf@vger.kernel.org, netdev@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Jakub Kicinski , Jesper Dangaard Brouer Cc: John Fastabend , Stanislav Fomichev , Lorenzo Bianconi , Vladimir Vdovin , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Andrew Lunn , Donald Hunter , Eduard Zingerman , Kumar Kartikeya Dwivedi , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Ihor Solodrai , Tony Nguyen , Przemek Kitszel , Maciej Fijalkowski , Alexander Lobakin , Magnus Karlsson , Tushar Vyavahare , Jason Xing , Nikolay Aleksandrov , Madalin Bucur , Ioana Ciornei , Jonathan Corbet , Shuah Khan , Shuah Khan , Randy Dunlap , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Chris J Arges , Jakub Sitnicki , linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, intel-wired-lan@lists.osuosl.org, llvm@lists.linux.dev, kernel-team@cloudflare.com, Tianyi Gao Subject: [PATCH bpf-next 00/15] xdp: add SKB core extensions to keep RX metadata until skb creation Date: Tue, 10 Nov 2026 03:56:58 +0000 Message-ID: X-Mailer: git-send-email 2.56.0 X-Mailing-List: llvm@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit An skb gets its RX hash, VLAN tag and checksum status from the RX descriptor, which describes the packet before the XDP program ran. Without this series: - On XDP_PASS, the values are stale. After the program strips a UDP tunnel header, the stack applies the outer CHECKSUM_UNNECESSARY to the inner packet [1]. If the outer UDP checksum is 0, a packet with a bad inner checksum reaches the socket. - On XDP_REDIRECT, the values are lost. The skb that cpumap or veth builds from the xdp_frame has no RX hash and no VLAN tag, and its checksum status is CHECKSUM_NONE. In one use case, an XDP program redirects packets into a veth device. The checksum status is lost, so GRO verifies every checksum in software. With one TCP flow, this costs 34% of the receiving CPU. Another use case [2] is load balancing IPsec tunnel traffic with cpumap. Without the RX hash, GRO on cpumap puts all flows into the same bucket. In a cpumap test with 16 TCP flows and no IPsec, the throughput is 17.6 Gbit/s instead of 23.4. This series introduces SKB core extensions for XDP. It reserves an skb core extension area in the headroom, right after the space for struct xdp_frame. An XDP program stores RX metadata in the area with kfuncs, and the kernel sets the skb fields from it. This design was initially proposed in [3]. The layout of the area follows skb extensions (struct skb_ext). A small header gives the offset of each entry. An entry takes headroom only when the program stores it, so the area does not grow with each new type of RX metadata, unlike [4]. Unlike skb_ext, the area needs no allocation. This series supports three types of RX metadata. Each type has a store kfunc, and bpf_xdp_skb_ext_del() deletes an entry: - The RX hash and its type: bpf_xdp_skb_ext_store_rx_hash(). - The VLAN tag and its protocol: bpf_xdp_skb_ext_store_rx_vlan(). - The checksum status: bpf_xdp_skb_ext_store_rx_csum(). Only XDP_CHECKSUM_NONE, or XDP_CHECKSUM_UNNECESSARY with a csum_level up to SKB_MAX_CSUM_LEVEL, are allowed [5][6]. The kernel sets the skb fields from the area: - After XDP_REDIRECT, in __xdp_build_skb_from_frame(). - On XDP_PASS, in the NIC driver. A driver that does this sets the new XDP feature skb-ext-pass. On other native XDP drivers, the kernel warns once when the program returns XDP_PASS with stored values, and ignores the area. This series adds the support to ice. The existing XDP RX metadata kfuncs are bpf_xdp_metadata_rx_*(). Only a device-bound program can call them. Programs on cpumap and devmap are not device-bound, so they cannot call them. Relaxing this check would change their semantics. So this series adds three load kfuncs, bpf_xdp_skb_ext_load_rx_*(). They read the stored values. bpf_xdp_adjust_head(), bpf_xdp_adjust_meta() and bpf_xdp_pull_data() do not move the packet or the metadata into the area. In this series, the area takes at most 20 bytes of headroom. With the hardware RX timestamp, the RX queue index and CHECKSUM_COMPLETE, it would take up to 40 bytes. Lorenzo's RX checksum kfunc series v5 [7] also defines enum xdp_checksum. The series that is merged second drops its copy. Performance: We measured on ice (E810, 25 Gbit/s) with bpf-next 0fb18ce8a2e9, patches 1-3 of [7] and this series. In the RX metadata column, the XDP program reads a value with bpf_xdp_metadata_rx_*() and stores it. The veth test stores the checksum status, and the cpumap test stores the RX hash. The kernel then sets the value on the skb. Baseline does not store it. Each value is the median of 5 rounds: test metric baseline RX metadata veth, 1 TCP flow RX CPU busy 100% 66% (-34%) veth, 1 TCP flow RX cycles/pkt 2027 1343 (-34%) cpumap, 16 TCP flows throughput 17.6 Gbit/s 23.4 (+33%) cpumap, 16 TCP flows pkts/GRO skb 3.4 7.5 (+122%) Both veth columns reach line rate, so the gain is in CPU time. A store kfunc takes 2.9 to 4.9 ns. Details are in [8]. Not in this series: - XDP_PASS support in mlx5 and bnxt. To align with Lorenzo's series [7], we plan to add xmo_rx_checksum and XDP_PASS support to them together, one driver at a time. - AF_XDP zero-copy. User space can write the headroom of zero-copy buffers, so the store kfuncs return -EOPNOTSUPP there. - Packets that enter XDP as an skb and leave it as an skb. This happens in generic XDP, and on XDP_PASS in veth when its peer sends it an skb. The series only sets the stored values on an skb that the kernel builds from an xdp_buff or an xdp_frame. - Stored entries on frames that dpaa and dpaa2 redirect. These drivers move data_hard_start before XDP_REDIRECT, so patch 2 clears the flag of the area. [1] https://lore.kernel.org/all/20260227153231.78d16b69@kernel.org/ [2] https://lore.kernel.org/all/ca38f2ed-999f-4ce1-8035-8ee9247f27f2@kernel.org/ [3] https://lore.kernel.org/all/1d5521eb-84fc-4417-a3f5-6366694d160a@kernel.org/ [4] https://lore.kernel.org/all/175146824674.1421237.18351246421763677468.stgit@firesoul/ [5] https://lore.kernel.org/all/20260722113525.34092660@kernel.org/ [6] https://lore.kernel.org/all/20260721183256.6f49d6e1@kernel.org/ [7] https://lore.kernel.org/all/20260715-bpf-xdp-meta-rxcksum-v5-0-623d5c0d0ab7@kernel.org/ [8] https://github.com/tgao-cf/skb-core-extensions-bench Tianyi Gao (15): xdp: reserve an skb core extension area after the xdp_frame net: dpaa, dpaa2: clear the skb core extension flag xdp: add kfuncs to store RX hash and VLAN tag xdp: add a kfunc to delete skb core extension entries xdp: add a kfunc to store the RX checksum status selftests/bpf: Test the skb core extension kfuncs xdp: set skb RX metadata from the skb core extension area of xdp_frame selftests/bpf: Test RX metadata on skbs built from xdp_frames xdp: add the skb-ext-pass XDP feature and warn without it xdp: warn on XDP_PASS with stored values when XDP runs on an skb ice: set skb RX metadata from the skb core extension area of xdp_buff selftests: drv-net: xdp: test the stored RX metadata on XDP_PASS xdp: add kfuncs to load the stored RX metadata selftests/bpf: Test the load kfuncs on cpumap and veth docs: net: document the skb core extension area Documentation/netlink/specs/netdev.yaml | 5 + Documentation/networking/xdp-rx-metadata.rst | 127 +++++- .../net/ethernet/freescale/dpaa/dpaa_eth.c | 2 + .../net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 + drivers/net/ethernet/intel/ice/ice_main.c | 3 +- drivers/net/ethernet/intel/ice/ice_sf_eth.c | 3 +- drivers/net/ethernet/intel/ice/ice_txrx.c | 4 +- drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 7 +- drivers/net/ethernet/intel/ice/ice_txrx_lib.h | 3 +- drivers/net/ethernet/intel/ice/ice_xsk.c | 2 +- drivers/net/veth.c | 5 +- include/net/xdp.h | 74 +++ include/uapi/linux/netdev.h | 6 +- net/bpf/test_run.c | 4 +- net/core/dev.c | 2 + net/core/filter.c | 8 +- net/core/xdp.c | 428 +++++++++++++++++- tools/include/uapi/linux/netdev.h | 6 +- .../selftests/bpf/prog_tests/test_xsk.c | 25 + .../selftests/bpf/prog_tests/test_xsk.h | 2 + .../selftests/bpf/prog_tests/xdp_bonding.c | 8 +- .../bpf/prog_tests/xdp_do_redirect.c | 8 +- .../selftests/bpf/prog_tests/xdp_pull_data.c | 12 +- .../selftests/bpf/prog_tests/xdp_skb_ext.c | 375 +++++++++++++++ .../selftests/bpf/progs/test_xdp_pull_data.c | 7 + .../selftests/bpf/progs/test_xdp_skb_ext.c | 173 +++++++ .../selftests/bpf/progs/xdp_skb_ext_failure.c | 16 + .../selftests/bpf/progs/xdp_skb_ext_success.c | 245 ++++++++++ .../selftests/bpf/progs/xsk_xdp_progs.c | 13 + tools/testing/selftests/bpf/xdp_skb_ext.h | 53 +++ .../drivers/net/hw/lib/py/__init__.py | 3 +- .../selftests/drivers/net/hw/xdp_metadata.py | 118 ++++- .../drivers/net/hw/xdp_skb_ext.bpf.c | 166 +++++++ 33 files changed, 1873 insertions(+), 42 deletions(-) create mode 100644 tools/testing/selftests/bpf/prog_tests/xdp_skb_ext.c create mode 100644 tools/testing/selftests/bpf/progs/test_xdp_skb_ext.c create mode 100644 tools/testing/selftests/bpf/progs/xdp_skb_ext_failure.c create mode 100644 tools/testing/selftests/bpf/progs/xdp_skb_ext_success.c create mode 100644 tools/testing/selftests/bpf/xdp_skb_ext.h create mode 100644 tools/testing/selftests/drivers/net/hw/xdp_skb_ext.bpf.c base-commit: 0fb18ce8a2e9de830433923cf65838933d615359 -- 2.56.0