From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CE412DAFB8 for ; Wed, 20 Aug 2025 10:39:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755686372; cv=none; b=DeRXLc0nFvc5S4JAgXqml3IR53VtBwh/DBLHVDXPa/MEwmatCepUq1dykwFVel48RFhw2RyJX4mbMY/UvyliTyNcEaGsHEO/U+noLD7GoIGPpzSJXIqcvfts9FEArKgINY+4Z9EBqWrG+vBN0lR0eys0U3oH6ugK4n2gJY+b0xA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755686372; c=relaxed/simple; bh=oJ7eX6Cr5MC+UWmH243rR3j1t09yrQpwK8VcV4x8/8U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=taI9SGj1a8HYMCJsUieB6ddI3bClEn6kyZeQBCFofUR88bcVkhKotSaUJhNqrlSepuwJ+mAF5PaKSRiZwK0xRp6WY/tYQvm3ELAOjNBrBQ/mUTxpVbyVQ6yRSZxLa1jXf/nMxcxWBUPGzbO0zperaLSdH37bwlfEpNtHBCzudqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=eci2odmY; arc=none smtp.client-ip=95.215.58.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="eci2odmY" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1755686369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0JEL0qQNPV6M/qOGIsQOAetnYYV4YPCbvB8NI4rcmrw=; b=eci2odmY5AvMvqAXli7nCNec0jkbmwDAhyukUUGK62nOaIEuwrgywZPdZcyNRvpAebM5+I 9TJEGKYFlNJXi9+sIRDBTSFavKfrP3vtRrMG+Jz4nyHtAT3Bb+fexCktTxAKI5kHRGhm8H 5OxSh3bIArxMHr6twIFrcXSObG+juGM= Date: Wed, 20 Aug 2025 18:39:21 +0800 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] panic: Clean up message about deprecated 'panic_print' parameter Content-Language: en-US To: Petr Mladek , Andrew Morton Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Steven Rostedt , Jonathan Corbet , linux-kernel@vger.kernel.org, paulmck@kernel.org, john.ogness@linutronix.de, kernel test robot , Feng Tang References: <202508200907.PsZ3geub-lkp@intel.com> <33a897b4-7d9a-4641-9c7a-07c19bb9cb6f@linux.dev> <7a34da58-874d-4271-9dbb-7991468d58ff@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Lance Yang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 2025/8/20 17:33, Petr Mladek wrote: > On Wed 2025-08-20 16:57:48, Lance Yang wrote: >> On 2025/8/20 09:56, Lance Yang wrote: >>> On 2025/8/20 09:54, Lance Yang wrote: >>>> On 2025/8/20 09:31, kernel test robot wrote: >>>>> All errors (new ones prefixed by >>): >>>>> >>>>>>> kernel/panic.c:952:2: error: call to undeclared function >>>>>>> 'panic_print_deprecated'; ISO C99 and later do not >>>>>>> support implicit function declarations >>>>>>> [-Wimplicit-function-declaration] >>>>>       952 |         panic_print_deprecated(); >>>>>           |         ^ >>>>>     kernel/panic.c:958:2: error: call to undeclared function >>>>> 'panic_print_deprecated'; ISO C99 and later do not support >>>>> implicit function declarations [-Wimplicit-function-declaration] >>>>>       958 |         panic_print_deprecated(); >>>>>           |         ^ >>>>>     2 errors generated. >>>> >>>> >>>> Oops, panic_print_deprecated() is defined within the #ifdef >>>> CONFIG_PROC_SYSCTL block, but it's also called from panic_print_set() >>> >> >> If Petr is cool, @Andrew could you squash the following? >> >> --- >> Subject: [PATCH 1/1] fixup: panic: clean up message about deprecated >> 'panic_print' parameter > > The patch was malformed probably by your mail client. > Below is the fixed and revied variant. Yes. My client messed up the formatting - git send-email it is ;) Thanks, Lance