[PATCH] kernel/irq/matrix.c: remove redundant assignment to variable 'end'

[PATCH] kernel/irq/matrix.c: remove redundant assignment to variable 'end'

[Colin Ian King]

Variable end is being initialized with a value that is never read, it
is being re-assigned later with the same value. The initialization is
redundant and can be removed.

Cleans up clang scan build warning:
kernel/irq/matrix.c:289:25: warning: Value stored to 'end' during its
initialization is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 kernel/irq/matrix.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/irq/matrix.c b/kernel/irq/matrix.c
index bbfb26489aa1..1698e77645ac 100644
--- a/kernel/irq/matrix.c
+++ b/kernel/irq/matrix.c
@@ -286,7 +286,7 @@ void irq_matrix_remove_managed(struct irq_matrix *m, const struct cpumask *msk)
 int irq_matrix_alloc_managed(struct irq_matrix *m, const struct cpumask *msk,
 			     unsigned int *mapped_cpu)
 {
-	unsigned int bit, cpu, end = m->alloc_end;
+	unsigned int bit, cpu, end;
 	struct cpumap *cm;
 
 	if (cpumask_empty(msk))
-- 
2.35.1

Re: [PATCH] kernel/irq/matrix.c: remove redundant assignment to variable 'end'

[Tom Rix]

On 4/22/22 4:04 AM, Colin Ian King wrote:
> Variable end is being initialized with a value that is never read, it
> is being re-assigned later with the same value. The initialization is
> redundant and can be removed.
>
> Cleans up clang scan build warning:
> kernel/irq/matrix.c:289:25: warning: Value stored to 'end' during its
> initialization is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>   kernel/irq/matrix.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/irq/matrix.c b/kernel/irq/matrix.c
> index bbfb26489aa1..1698e77645ac 100644
> --- a/kernel/irq/matrix.c
> +++ b/kernel/irq/matrix.c
> @@ -286,7 +286,7 @@ void irq_matrix_remove_managed(struct irq_matrix *m, const struct cpumask *msk)
>   int irq_matrix_alloc_managed(struct irq_matrix *m, const struct cpumask *msk,
>   			     unsigned int *mapped_cpu)
>   {
> -	unsigned int bit, cpu, end = m->alloc_end;
> +	unsigned int bit, cpu, end;
Reviewed-by: Tom Rix <trix@redhat.com>
>   	struct cpumap *cm;
>   
>   	if (cpumask_empty(msk))

Re: [PATCH] kernel/irq/matrix.c: remove redundant assignment to variable 'end'

[Thomas Gleixner]

Colin,

On Fri, Apr 22 2022 at 12:04, Colin Ian King wrote:

can you please stop using file paths as subsystem prefix in the patch
subject?

  https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#patch-subject

I fixed it up once more, but you can really spare me the effort.

Thanks,

        tglx

Re: [PATCH] kernel/irq/matrix.c: remove redundant assignment to variable 'end'

[Colin King (gmail)]

On 25/04/2022 14:02, Thomas Gleixner wrote:
> Colin,
> 
> On Fri, Apr 22 2022 at 12:04, Colin Ian King wrote:
> 
> can you please stop using file paths as subsystem prefix in the patch
> subject?
> 
>    https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#patch-subject
> 
> I fixed it up once more, but you can really spare me the effort.
> 

Apologies. Will do next time.

Colin

> Thanks,
> 
>          tglx