From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
To: kernel test robot <lkp@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [tip:x86/cpu 3/5] ERROR: modpost: "acpi_processor_ffh_play_dead" [drivers/acpi/processor.ko] undefined!
Date: Sun, 16 Feb 2025 14:26:14 +0200 [thread overview]
Message-ID: <de5bf4f116779efde315782a15146fdc77a4a044.camel@linux.intel.com> (raw)
In-Reply-To: <202502151207.FA9UO1iX-lkp@intel.com>
On Sat, 2025-02-15 at 12:51 +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/cpu
> head: 96040f7273e2bc0be1871ad9ed4da7b504da9410
> commit: 541ddf31e30022b8e6f44b3a943964e8f0989d15 [3/5] ACPI/processor_idle: Add FFH state handling
> config: x86_64-randconfig-077-20250214 (https://download.01.org/0day-ci/archive/20250215/202502151207.FA9UO1iX-lkp@intel.com/config)
> compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250215/202502151207.FA9UO1iX-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202502151207.FA9UO1iX-lkp@intel.com/
>
> All errors (new ones prefixed by >>, old ones prefixed by <<):
>
> > > ERROR: modpost: "acpi_processor_ffh_play_dead" [drivers/acpi/processor.ko] undefined!
Oh, this is the 'CONFIG_ACPI_PROCESSOR=m' case. The function export is missing. Sorry for this.
The below patch fixes the issue. Could you please fold it into the following commit?
541ddf31e300 ACPI/processor_idle: Add FFH state handling
I am not sure about the rules of the tip tree in cases like this, please direct me on
how to handle the delivery of the fix.
Thanks!
index 5bdb65516969..86c87c01d23d 100644
--- a/arch/x86/kernel/acpi/cstate.c
+++ b/arch/x86/kernel/acpi/cstate.c
@@ -214,6 +214,7 @@ void acpi_processor_ffh_play_dead(struct acpi_processor_cx *cx)
percpu_entry = per_cpu_ptr(cpu_cstate_entry, cpu);
mwait_play_dead(percpu_entry->states[cx->index].eax);
}
+EXPORT_SYMBOL_GPL(acpi_processor_ffh_play_dead);
void __cpuidle acpi_processor_ffh_cstate_enter(struct acpi_processor_cx *cx)
{
next prev parent reply other threads:[~2025-02-16 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-15 4:51 [tip:x86/cpu 3/5] ERROR: modpost: "acpi_processor_ffh_play_dead" [drivers/acpi/processor.ko] undefined! kernel test robot
2025-02-16 12:26 ` Artem Bityutskiy [this message]
2025-02-21 14:19 ` [PATCH] ACPI/processor_idle: Export acpi_processor_ffh_play_dead() Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de5bf4f116779efde315782a15146fdc77a4a044.camel@linux.intel.com \
--to=artem.bityutskiy@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox