Re: Re: Re: [PATCH] PCI: Enable io space 1k granularity for

Zhou Shengqing
2024-07-02T05:49:58Z

> > I still think this is not going to work because I don't want this kind
> > of device-specific clutter in this generic path. The pcibios_*
> > interfaces are history that we'd like to get rid of also, but it would
> > be better than putting it here.
>
> Do you think it should be putted to the pci_bios* interface?
>
> And if there is no suitable place to apply this patch,
> then let's just ignore this issue.

> What are the device/function addresses of the IIO and the Root Ports?

IIO device = 0,function = 0.
Root Ports device = 1/2/3/4/5/6/7/8,function = 0, And they are on the same bus.

>
> They must all be on the root bus, and if the IIO is enumerated first
> (i.e., if it has a smaller device/function number), you may be able to
> make a quirk that applies to the Root Port vendor/device ID but reads
> the config bit from the IIO.
>
> quirk_passive_release(), quirk_vialatency(), quirk_amd_780_apc_msi(),
> etc. do similar things.

I have commited a new patch referred to quirk_passive_release().
https://lore.kernel.org/all/20240702035649.26039-1-zhoushengqing@ttyinfo.com/

And I validate it on my system which previously some devices couldn't have IO space.
After applying this patch, all devices were able to have IO space.

Thank you again for your assistance.

>
> Bjorn