From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: kernel test robot <lkp@intel.com>
Cc: "llvm@lists.linux.dev" <llvm@lists.linux.dev>,
"oe-kbuild-all@lists.linux.dev" <oe-kbuild-all@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: arch/powerpc/kernel/traps.c:1167:19: error: unused function '__parse_fpscr'
Date: Fri, 22 Sep 2023 12:32:51 +0000 [thread overview]
Message-ID: <e8f1dcdd-0274-11fa-5e2e-a03fc4effd87@csgroup.eu> (raw)
In-Reply-To: <202309210327.WkqSd5Bq-lkp@intel.com>
Le 20/09/2023 à 21:39, kernel test robot a écrit :
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: a229cf67ab851a6e92395f37ed141d065176575a
> commit: ca13c130a43fe3ab625d22ada0a61e5c0b612229 powerpc/4xx: Remove WatchdogHandler() to fix no previous prototype error
Problem already exists before that commit.
Problem was introduced by commit Fixes: b6254ced4da6 ("powerpc/signal:
Don't manage floating point regs when no FPU")
Christophe
> date: 5 weeks ago
> config: powerpc-kilauea_defconfig (https://download.01.org/0day-ci/archive/20230921/202309210327.WkqSd5Bq-lkp@intel.com/config)
> compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230921/202309210327.WkqSd5Bq-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202309210327.WkqSd5Bq-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>>> arch/powerpc/kernel/traps.c:1167:19: error: unused function '__parse_fpscr' [-Werror,-Wunused-function]
> 1167 | static inline int __parse_fpscr(unsigned long fpscr)
> | ^
> 1 error generated.
>
>
> vim +/__parse_fpscr +1167 arch/powerpc/kernel/traps.c
>
> 14cf11af6cf608 Paul Mackerras 2005-09-26 1166
> 5fad293bcbd48d Kumar Gala 2007-02-07 @1167 static inline int __parse_fpscr(unsigned long fpscr)
> dc1c1ca3dcd94c Stephen Rothwell 2005-10-01 1168 {
> aeb1c0f6ff18f5 Eric W. Biederman 2018-04-17 1169 int ret = FPE_FLTUNK;
> dc1c1ca3dcd94c Stephen Rothwell 2005-10-01 1170
> dc1c1ca3dcd94c Stephen Rothwell 2005-10-01 1171 /* Invalid operation */
> dc1c1ca3dcd94c Stephen Rothwell 2005-10-01 1172 if ((fpscr & FPSCR_VE) && (fpscr & FPSCR_VX))
> 5fad293bcbd48d Kumar Gala 2007-02-07 1173 ret = FPE_FLTINV;
> dc1c1ca3dcd94c Stephen Rothwell 2005-10-01 1174
> dc1c1ca3dcd94c Stephen Rothwell 2005-10-01 1175 /* Overflow */
> dc1c1ca3dcd94c Stephen Rothwell 2005-10-01 1176 else if ((fpscr & FPSCR_OE) && (fpscr & FPSCR_OX))
> 5fad293bcbd48d Kumar Gala 2007-02-07 1177 ret = FPE_FLTOVF;
> dc1c1ca3dcd94c Stephen Rothwell 2005-10-01 1178
> dc1c1ca3dcd94c Stephen Rothwell 2005-10-01 1179 /* Underflow */
> dc1c1ca3dcd94c Stephen Rothwell 2005-10-01 1180 else if ((fpscr & FPSCR_UE) && (fpscr & FPSCR_UX))
> 5fad293bcbd48d Kumar Gala 2007-02-07 1181 ret = FPE_FLTUND;
> dc1c1ca3dcd94c Stephen Rothwell 2005-10-01 1182
> dc1c1ca3dcd94c Stephen Rothwell 2005-10-01 1183 /* Divide by zero */
> dc1c1ca3dcd94c Stephen Rothwell 2005-10-01 1184 else if ((fpscr & FPSCR_ZE) && (fpscr & FPSCR_ZX))
> 5fad293bcbd48d Kumar Gala 2007-02-07 1185 ret = FPE_FLTDIV;
> dc1c1ca3dcd94c Stephen Rothwell 2005-10-01 1186
> dc1c1ca3dcd94c Stephen Rothwell 2005-10-01 1187 /* Inexact result */
> dc1c1ca3dcd94c Stephen Rothwell 2005-10-01 1188 else if ((fpscr & FPSCR_XE) && (fpscr & FPSCR_XX))
> 5fad293bcbd48d Kumar Gala 2007-02-07 1189 ret = FPE_FLTRES;
> 5fad293bcbd48d Kumar Gala 2007-02-07 1190
> 5fad293bcbd48d Kumar Gala 2007-02-07 1191 return ret;
> 5fad293bcbd48d Kumar Gala 2007-02-07 1192 }
> 5fad293bcbd48d Kumar Gala 2007-02-07 1193
>
> :::::: The code at line 1167 was first introduced by commit
> :::::: 5fad293bcbd48d9a2370020cf60e4b4a42559b12 [POWERPC] Fixup error handling when emulating a floating point instruction
>
> :::::: TO: Kumar Gala <galak@kernel.crashing.org>
> :::::: CC: Kumar Gala <galak@kernel.crashing.org>
>
next prev parent reply other threads:[~2023-09-22 12:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 19:39 arch/powerpc/kernel/traps.c:1167:19: error: unused function '__parse_fpscr' kernel test robot
2023-09-22 12:32 ` Christophe Leroy [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-09-30 13:40 kernel test robot
2023-09-30 15:57 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8f1dcdd-0274-11fa-5e2e-a03fc4effd87@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=mpe@ellerman.id.au \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox