From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B889620CCC6 for ; Fri, 11 Oct 2024 11:03:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728644585; cv=none; b=lSgfr2iv1rK8SCOfq0+vZsb2mn5hV3yGeh/pc7vS7KOngMMU8epGLPGJvWfVOcl/mDSH3VZ5ifDnhbqTljKjp4lwk92zYi/aneslfLTh9ZQSkuNwHfDyt+xONRyGZtyE3dhL3ShY6t6lN+FFX3gwilzH1ixXN/I1uHRRIHrNk0Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728644585; c=relaxed/simple; bh=PNsJvaR2hjTB0m5F7S8kPrYH81jNbMy+cnbFnpqGHtw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gC50YkyQ7fi4dqSC3TTv2OmyKLwMuM9GPaczKZ/99p0Qmy+1Ov5PSfwPC7hKiPrq4k+rlA+3tHaRrzpHKxFIUG1lp0wvHTLTpC2Hn3ijNV+QciM4ToOzGmfmwEoT3osP7EazPraHhqYF0/4aTEBnAcdSrD+QLFZLAi46YcQ+0Y0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KFT7Hb+F; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KFT7Hb+F" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a9968114422so272794766b.2 for ; Fri, 11 Oct 2024 04:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728644582; x=1729249382; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jDgqCY+XT65kiTHSQJtsyJ8AXYUcreWmz9KtIDjKv1k=; b=KFT7Hb+FPtRgPoswCXlALGBcyZE8dNE9KgQ+k7IazbbBRPrWFSPWuHzoIpXL/BjDRE Hn7mRmDR9ZL21+SWWzwYrAbpsI7RCRb+TvmjGifAL7bxBrr8QCRcj0NsS5g5S4JbUR3T cY7MUi4qqrnpAwj/0+weNn9U783BAKGiFNC7kJhYLX/sQkJf6Hf+X1kLCTGcDuMlnFL5 st3/1GDaoqpiPXxQfnAfGE/K88fK02w1BOG7NDq9opQ6P7tFCTIdS+4UwOszgU3H1rj8 n5fYIcFB49byXMgooa0KKXaSniCdgyhjy1dob79Qjk1DJH0Syatlsad76ZwPeaAiiaCV tdsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728644582; x=1729249382; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jDgqCY+XT65kiTHSQJtsyJ8AXYUcreWmz9KtIDjKv1k=; b=lYy5f6FXzBlCxd8sIgwie/xn7tcYfX7LqC0ob2XRxlWQtdYz/PDlmN8hu1+wMLqRkj 41raIs9Og/fbGiTPOFUTCFZvZZTuXbj2PlWaJSifqj1mQooDXah5CDbcKCGvblQzzZa3 t22jMLNdI8fdyCA9oxBY3C+SSi6Kk8vcvZt66kw66qaX4V+kcuLQD6oToHayexZKoxfN b0q3DXfzxekbACv4pDMQmgS3Sa7/V8148sLDj2obrznFjRJers7LFyYMuLvewGx962Q4 5higiibhyqM0kE9rYEXh7dTMO0dfhhjtaF/6+aI3/yDEbjQHTW9MMRMHOZnizZlOMn63 vfdw== X-Forwarded-Encrypted: i=1; AJvYcCUX4RQ4GKTmweM96KM++2MX14jqk5l8lcmdaQUr4gn2OaNsO9uvYHzutm6k4gOSMMNHKuix@lists.linux.dev X-Gm-Message-State: AOJu0YxiTjrD2NFvqBbwVNNQbbMlqfHYJS/1B7RA7A6uSAHgA3s/1elX cMzVNkbGVpYy9imCYL4BK09ZQBtysr//g4qOdbZ/3XCDQcReEqXC X-Google-Smtp-Source: AGHT+IEy14Gx0H4bckIlt3krJcapszDFEJlJFkVFRbRzPFWdbCtdvus5IaXo71tLkpD9oWj2tSQarg== X-Received: by 2002:a17:907:944c:b0:a99:4698:cc5a with SMTP id a640c23a62f3a-a99b95bc0d1mr163059766b.47.1728644581797; Fri, 11 Oct 2024 04:03:01 -0700 (PDT) Received: from [10.10.12.27] (91-118-163-37.static.upcbusiness.at. [91.118.163.37]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a99a7ec573csm200566466b.6.2024.10.11.04.02.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Oct 2024 04:03:01 -0700 (PDT) Message-ID: Date: Fri, 11 Oct 2024 13:02:52 +0200 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: Fix uninitialized variable To: Andy Shevchenko , "Yo-Jung (Leo) Lin" <0xff07@gmail.com> Cc: linux-kernel-mentees@lists.linuxfoundation.org, ricardo@marliere.net, skhan@linuxfoundation.org, Jonathan Cameron , Lars-Peter Clausen , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Vasileios Amoiridis , Angel Iglesias , Adam Rizkalla , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20241011093752.30685-1-0xff07@gmail.com> Content-Language: en-US, de-AT From: Javier Carrasco In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/10/2024 12:54, Andy Shevchenko wrote: > On Fri, Oct 11, 2024 at 05:37:45PM +0800, Yo-Jung (Leo) Lin wrote: >> clang found that the "offset" in bmp580_trigger_handler doesn't get >> initialized before access. Add proper initialization to this variable. > > ... > >> struct bmp280_data *data = iio_priv(indio_dev); >> - int ret, offset; >> + int ret, offset = 0; > > Can it be done closer to the actual user of it? > > Actually, offset could be initialized to sizeof(32), and only used for the temperature calculations. + int ret, offset = sizeof(s32); The first memcpy would use 0 as index, as it did before. Best regards, Javier Carrasco