From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE7A242903B for ; Thu, 20 Aug 2026 13:06:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787231164; cv=none; b=cDTYHdMHYMw4psHxNBfhZSEfHOjJrNp7mRfvYG6z/2Sfire7Yw3/AeLPOdV6ZdUfZb6W1i503iAdAuOMxk9Gf5mYeYejrcwPnV84KbzMk2iPB/FBMzQjN8dazrGtDOw+jRH18o+wvdsnpdJgV5L2E8YfEOjUWd+CbIp7IMDABzk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787231164; c=relaxed/simple; bh=/MvLGjCq9P+3TJQdi9yv+SMKwpIqRwp5tDl+T95B12k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ka/92agTDl46wFbxNSah5sEW6UHioSFU0yhvmWjK+SgnYY37hHZYKMde6Bo5DzjqBtEI4vIQc72TaA9Ig8gsMhwo4fYqx+cKqvEZ7Xvu8LkHjYFDy1UqiHZ3Bpe3hmlbcmXBZs4eUf4TiPRDZO5U8qck67QiB+6rFo8ljqbhhSI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jwaV4z2T; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KFsXNihh; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jwaV4z2T"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KFsXNihh" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67K8PEiE2465441 for ; Thu, 20 Aug 2026 13:05:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AieFSNSsSUo34uQSMJ/dNEJ/DOfK3/fGsi4sE8iI73Y=; b=jwaV4z2TzGHiIR6o jRjasUFvEdE3hZE4YOADkjaSjyq+fcG4SjuMiuZVqbaXpQo4fXaIGY24SYwIat5Y xEHhlCuMnmrr/SJYHxUbGJ+FCUVgQRxIlibWMy7b/sBOaiRz0+BwV58KjdvUWos0 MymhkSBlK9tfmtpyUhUVKJsUFs7C/x9lF8qpNUMfawb2xETI4YbvdSb/Fm3cQMvp wpXyQIuiglhtbRGv11uPR8LPyT8bF0b6C169b+Ox9GnAJLwwDeqD8AZtXLm3YYqq gt/e/bKxwCGZ8iFBBe16qImQzjIyszZalA0J2/MKSZVYh0FOA7HSdLy82KtShU+Q AQ3oYw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g5x29h1dq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 20 Aug 2026 13:05:58 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38e54b6556aso2763859a91.2 for ; Thu, 20 Aug 2026 06:05:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787231158; x=1787835958; darn=lists.linux.dev; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=AieFSNSsSUo34uQSMJ/dNEJ/DOfK3/fGsi4sE8iI73Y=; b=KFsXNihhNPUWp9iVJygiIw2vHWUALSztv8TlWIkjmpFheJHQL4jrRRmdJf7zuyCzbS Fd9GnrFQNv7J/CGvJGkeBuWbIlVU66FfQX/XpS/WjmDuOyNDW6XSq8yNsmEh+HB02R8w I7z+tg3vlhi70TAo4nau/yeCAduxOh9NpTjzV3u2DgzvVAJfHT0kSTXjFUl/H46aB69P 7deg5TRto7YOe615M8BHU2HvjZv24TmkZ0gz8+HMMHDQWwWsmCCwiPOPIq70xxPYx6r5 6UH85viMjbuZstqMMgVG/Y4kJp9wwt7L5OjRzScYU4O5vHncsmSNaFhW4lxZm4kTdsJm jJgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787231158; x=1787835958; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AieFSNSsSUo34uQSMJ/dNEJ/DOfK3/fGsi4sE8iI73Y=; b=rFKdFagrYU9WNVYEvOjdjNC4tij0s8uQ6owuESB2aSf7k2uqsHieTSOo0nz/2BsnB4 ZX7hSLDf6Iv34rNBR4mgjs2CTbys7t82grqDoQ950L1dTRGc1j+mpTVL14vARK+HUCY1 Su97Ouc0KobcdMquPiOmopaK0wVsnzN1WsU5YRvf/Q/plFOSrx3o5EoSMTrpj+K5Sdv2 AGcMwRPDMoGlG0cxpIBQmVnCwDPlHV/ua7eTIOP2AXyHdHvfB2iBlJ5fXL6okFmrOMCZ zdwoN+Mx1H+UlpSZ2IuBd1gIkcgyNNKkpU+ZFMRWusMbOkS0X3ZczWuv6kV3qSYNomvm gFxQ== X-Forwarded-Encrypted: i=1; AHgh+RoZDzeZSyjQ4ZPDSvxHhq1oqLfrmeVdViuQdVjXoYM3IhWgah01MpBOZbSnBUZ2fFOF5igu@lists.linux.dev X-Gm-Message-State: AFuF++nyRqQZK0UEkVBCebR93M88NRALXPm3FVyoE6byGljBBYiuROSt 20Yqa/0JzCT8Y4Y9YxWDVUhtBB9nPcXCyP8mYgA3FRr2XmX8AtlGUXurxRju4AV3yF3pdV1+wC0 6YGChniQfH1iNdNafefLw71uBWRX4wjpGkZqoVvmSHIrWbmp0gC6DUMkp X-Gm-Gg: AR+sD11VdSFmWhj3KyoHTFgH0hBmkGkXpqYwN6x+tRd8+rSHVTIz530ey1dd8OA1O95 4T+uGBmJQw/GeGWFWeO2IhXjA4x3rFkuIDZFgBpCR8Vh4XwL4rFDC1q0KE0hy0pEC9exKQHqPqk RtC/l7lVfGpYhK0UQI78DLvfxHxsLo19hYkdNnPY+qPB3YVkofh/oe4sgatMoXVZFCUYDLOMbEP mAMq5k5skiOr8fyWgjhhUijohYU6ctV16J87YLkup+g9g5cKtNRz94jVd13ojSJMpYJy4Nsn9lP NpxW5omxGrmpXZ6e3868Lt2Ar88aijKMSrPAUnq78PCXR4k2zEiNgKFG4xXjWJT5QfkJVyLbRfN R0n8RGfiX+WMRwaXkkZdcoOgtm9zyyw== X-Received: by 2002:a17:90b:4d82:b0:395:4de4:92c7 with SMTP id 98e67ed59e1d1-39580ed143bmr23044566a91.3.1787231157844; Thu, 20 Aug 2026 06:05:57 -0700 (PDT) X-Received: by 2002:a17:90b:4d82:b0:395:4de4:92c7 with SMTP id 98e67ed59e1d1-39580ed143bmr23044231a91.3.1787231156489; Thu, 20 Aug 2026 06:05:56 -0700 (PDT) Received: from [10.219.56.166] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3957fb12145sm6574171a91.4.2026.08.20.06.05.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Aug 2026 06:05:49 -0700 (PDT) Message-ID: Date: Thu, 20 Aug 2026 18:35:40 +0530 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 15/15] accel/qda: Add remote memory unmap from DSP address space To: Dmitry Baryshkov Cc: Oded Gabbay , Jonathan Corbet , Shuah Khan , Randy Dunlap , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Bharath Kumar , Chenna Kesava Raju , srinivas.kandagatla@oss.qualcomm.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, llvm@lists.linux.dev, iommu@lists.linux.dev, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org References: <20260817-qda-v2-v2-0-757ab8ed2f64@oss.qualcomm.com> <20260817-qda-v2-v2-15-757ab8ed2f64@oss.qualcomm.com> <6k6ogbosxx4z5bh7uriu4fnj24ycuakylq6g2gnuwsbckl2zww@e66jgj5xo52o> Content-Language: en-US From: Ekansh Gupta In-Reply-To: <6k6ogbosxx4z5bh7uriu4fnj24ycuakylq6g2gnuwsbckl2zww@e66jgj5xo52o> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 4WghPJZ2Mgc849nNuzxglodiNv3RYgl- X-Authority-Analysis: v=2.4 cv=V8BNF+ni c=1 sm=1 tr=0 ts=6a86fbb6 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=rYwYc2LNA-xZppdo0x8A:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODIwMDA5NyBTYWx0ZWRfXwdzzlN9u7wuK XmGM2qJPn1srlouVBpFRA8fH/9frn7sYWb0z8opmvUDnyFNGc3GvT3Z64ebURTtnKmD6FmnkmvP nRD0Uqcef0XbjtKfLMGHhWD+X/BkLquPsL3qYZjqWLh/manH4l1/YUzN+p9GY6fcz4ZFoQwjdzR 4dfYuwd/72jVr/GXXSO6wgrIB3rHMSBtX6WhAm9I0HPxnt2TJwMjcAUzUbDyL0aUpA6wLyPY1KU 4iRTCn1B1fWWp4QAloB246+VlY/FFytZM5o620yJeEe8EudB8pNj5zTNt26hap2WRVstj7gQJFW saJWiP32PNvwNmq4DTALOrlf5BcPggVn1HaaSnEOwr6dfVm2GYKDGW39yfxl0fcmZzrdC1FfGW1 IU3oB3Gkd+MSjUJcCpI7awi4Ad469Lobnh2WObe2xClDs//uxlCBG9C1LHyk/CqWLdBCdt3/eNq Pv2SD+0fwMioZOa5fpg== X-Proofpoint-Spam-Info: AW1haW4tMjYwODIwMDA5NyBTYWx0ZWRfX41Iz/i3UvI3p DsMWkijcqnsvHuJ/hxYxgMDYLIMt3kdS5GDbEetecga7mUeAjKLkRZP+9ANHeZ+/9o9g0X8NmNg TeFkwxHUb58StEYihGmfZuawVezvCLk= X-Proofpoint-GUID: 4WghPJZ2Mgc849nNuzxglodiNv3RYgl- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_06,2026-08-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 clxscore=1015 bulkscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608200097 On 17-08-2026 11:14, Dmitry Baryshkov wrote: > On Mon, Aug 17, 2026 at 10:38:45AM +0530, Ekansh Gupta wrote: >> Add DRM_IOCTL_QDA_REMOTE_MUNMAP, which removes a mapping previously >> established with DRM_IOCTL_QDA_REMOTE_MAP from the DSP address space of >> the calling process. >> >> Mirroring the map path, the DSP exposes two unmap operations, both >> reachable through this IOCTL and selected by the request field of >> struct drm_qda_mem_unmap: >> >> QDA_REQUEST_MUNMAP unmaps a region by the DSP address that the >> corresponding map call returned. It uses the vaddrout and size fields. >> >> QDA_REQUEST_MEM_UNMAP unmaps a region by buffer identity, using the >> GEM handle, the DSP virtual address and the size. > > Why do we need two different operations? Can you just pass the GEM > handle to the IOCTL? QDA_REQUEST_MUNMAP (RMID 5): The DSP locates the mapping by the DSP virtual address that was returned by the corresponding MMAP call. This is the older protocol message that only needs {address, size} to identify the region in the DSP's page table. QDA_REQUEST_MEM_UNMAP (RMID 11): The DSP locates the mapping by its internal handle association. This is the newer protocol message that is not supported on older platforms. > > Also, what happens if the buffer is still in use on the DSP side? Will > the DSP crash? Will the whole board crash? The access from DSP after unmap will trigger an SMMU context fault on the context bank device. The fault does not bring down the board but might trigger remoteproc to restart(I'm not exactly sure about the iommu side handling of such faults). Thanks for reviewing the patches. //Ekansh > > >> >> Each request type has its own argument builder in qda_fastrpc.c, >> documented with the packed argument layout the DSP expects. Unknown >> request types are rejected with -EINVAL. >> >> Assisted-by: Claude:claude-sonnet-5 >> Signed-off-by: Ekansh Gupta >> --- >> drivers/accel/qda/qda_drv.c | 1 + >> drivers/accel/qda/qda_fastrpc.c | 119 ++++++++++++++++++++++++++++++++++++++++ >> drivers/accel/qda/qda_fastrpc.h | 34 ++++++++++++ >> drivers/accel/qda/qda_ioctl.c | 22 ++++++++ >> drivers/accel/qda/qda_ioctl.h | 1 + >> include/uapi/drm/qda_accel.h | 39 ++++++++++++- >> 6 files changed, 215 insertions(+), 1 deletion(-) >> >> >