From: Tom Rix <trix@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: tim@cyberelk.net, axboe@kernel.dk, jejb@linux.ibm.com,
martin.petersen@oracle.com, nathan@kernel.org,
ndesaulniers@google.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] security: do not leak information in ioctl
Date: Mon, 11 Apr 2022 09:31:20 -0700 [thread overview]
Message-ID: <eec2efee-1153-8d8e-77c2-96156733a0c6@redhat.com> (raw)
In-Reply-To: <YlREKRb/xgAFsi97@infradead.org>
On 4/11/22 8:07 AM, Christoph Hellwig wrote:
> Wrong subject prefix, and this really should be split into one patch for
> pcd and one for sr.
ok i will split
> The sr prt looks sensible to me. But for pcd why can't you just
> initialize buffer using
>
> char buffer[32] = { };
>
> and be done with it?
The failure can happen in the transfer loop, so some of the data will
not be zero.
And checking status should be done.
zero-ing is because i am paranoid.
Tom
>
next prev parent reply other threads:[~2022-04-11 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 14:51 [PATCH] security: do not leak information in ioctl Tom Rix
2022-04-11 15:07 ` Christoph Hellwig
2022-04-11 16:31 ` Tom Rix [this message]
2022-04-12 5:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eec2efee-1153-8d8e-77c2-96156733a0c6@redhat.com \
--to=trix@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=jejb@linux.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.petersen@oracle.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).