Re: [PATCH 05/14] KVM: selftests: Fix a typo in x86-64's kvm_get_cpu_address_width()

Philippe Mathieu-Daudé
2022-12-13T09:47:27Z

On 13/12/22 01:16, Sean Christopherson wrote:
> Fix a == vs. = typo in kvm_get_cpu_address_width() that results in
> @pa_bits being left unset if the CPU doesn't support enumerating its
> MAX_PHY_ADDR. Flagged by clang's unusued-value warning.
>
> lib/x86_64/processor.c:1034:51: warning: expression result unused [-Wunused-value]
> *pa_bits == kvm_cpu_has(X86_FEATURE_PAE) ? 36 : 32;
>
> Fixes: 3bd396353d18 ("KVM: selftests: Add X86_FEATURE_PAE and use it calc "fallback" MAXPHYADDR")
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
> tools/testing/selftests/kvm/lib/x86_64/processor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/lib/x86_64/processor.c b/tools/testing/selftests/kvm/lib/x86_64/processor.c
> index c4d368d56cfe..acfa1d01e7df 100644
> --- a/tools/testing/selftests/kvm/lib/x86_64/processor.c
> +++ b/tools/testing/selftests/kvm/lib/x86_64/processor.c
> @@ -1031,7 +1031,7 @@ bool is_amd_cpu(void)
> void kvm_get_cpu_address_width(unsigned int *pa_bits, unsigned int *va_bits)
> {
> if (!kvm_cpu_has_p(X86_PROPERTY_MAX_PHY_ADDR)) {
> - *pa_bits == kvm_cpu_has(X86_FEATURE_PAE) ? 36 : 32;
> + *pa_bits = kvm_cpu_has(X86_FEATURE_PAE) ? 36 : 32;

:)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>