Re: [PATCH 12/14] KVM: selftests: Use wildcards to find library source files

Sean Christopherson
2023-01-04T01:09:40Z

On Sat, Dec 24, 2022, Paolo Bonzini wrote:
> On 12/13/22 01:16, Sean Christopherson wrote:
> > Use $(wildcard ...) to find the library source files instead of manually
> > defining the inputs, which is a maintenance burden and error prone.
>
> No, please don't. This leads to weird errors, for example when "git
> checkout" is interrupted with ^C.

Well, don't do that ;-)

Are there concerns beyond having an incomplete and/or modified git working tree?
E.g. could we do something crazy like fail the build by default if the working
tree isn't pristine? The library files aren't terrible, but the number of tests
is getting unwieldy, to say the least.