From: Matthias Brugger <matthias.bgg@gmail.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: Tom Rix <trix@redhat.com>,
chunkuang.hu@kernel.org, p.zabel@pengutronix.de,
chunfeng.yun@mediatek.com, kishon@kernel.org,
angelogioacchino.delregno@collabora.com, nathan@kernel.org,
ndesaulniers@google.com, granquet@baylibre.com,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] phy: mediatek: fix returning garbage
Date: Mon, 8 May 2023 10:24:19 +0200 [thread overview]
Message-ID: <f5cf30b2-c29c-03ac-e7fc-4c7da2cd0c5b@gmail.com> (raw)
In-Reply-To: <ZFipVfhLVyye/eud@matsya>
On 08/05/2023 09:48, Vinod Koul wrote:
> On 05-05-23, 17:37, Matthias Brugger wrote:
>>
>>
>> On 05/05/2023 11:28, Vinod Koul wrote:
>>> On 14-04-23, 08:22, Tom Rix wrote:
>>>> clang reports
>>>> drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable
>>>> 'ret' is uninitialized when used here [-Werror,-Wuninitialized]
>>>> if (ret)
>>>> ^~~
>>>> ret should have been set by the preceding call to mtk_hdmi_pll_set_hw.
>>>
>>> I have applied "phy: mediatek: hdmi: mt8195: fix uninitialized variable
>>> usage in pll_calc"
>>
>> Thanks Vinod, that was on my list for today as well. I was a bit puzzled
>> because you took the patch that added it, but I wasn't sure if you would
>> take the fix. How do you want to handle things like this in the future?
>
> Fixes should be sent as Fixes patch
>
I'm not sure what do you mean. Patch subject includes the word fix and the patch
has a fixes tag. What was missing here?
Does this mean you will take fixes for this driver in the future or do you want
me to take care of them?
Regards,
Matthias
next prev parent reply other threads:[~2023-05-08 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 12:22 [PATCH] phy: mediatek: fix returning garbage Tom Rix
2023-04-14 15:43 ` Matthias Brugger
2023-04-14 15:46 ` Matthias Brugger
2023-04-14 15:49 ` Nathan Chancellor
2023-04-17 7:38 ` AngeloGioacchino Del Regno
2023-05-05 9:28 ` Vinod Koul
2023-05-05 15:37 ` Matthias Brugger
2023-05-08 7:48 ` Vinod Koul
2023-05-08 8:24 ` Matthias Brugger [this message]
2023-05-08 8:57 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5cf30b2-c29c-03ac-e7fc-4c7da2cd0c5b@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunfeng.yun@mediatek.com \
--cc=chunkuang.hu@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=granquet@baylibre.com \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=p.zabel@pengutronix.de \
--cc=trix@redhat.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox