From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9917733DB for ; Thu, 22 May 2025 09:36:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747906617; cv=none; b=huKYgwugH7cFds9tPecY57cGFzqWd+oRoqzQT1h/BQp9ThS34WBOHJhdEAUrIYIc9eI8Xx6hnAqmHo+0/G5cs5B76btRFEJmpWRxjo3qly/EK79c4TQZ8hRpl2RN3GQtZMNeDrnMuIx+3fQa/Faj/DpYhiTgjR9JlxVzadMSIS0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747906617; c=relaxed/simple; bh=jby8RYHrYFnGjogk4ajcjl7VAWfMLIUjNIcmyK3dq2Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pKfxOC2pbXduIPBAb5GRGqrOqDI9ht6XLaz8e+RzSA4I45L2PWRbXZWW+NCrPqvui5SUe4KMBBdNfdjpnYCWCqS234+brn7gy0Ji658+L4g7JiJgAyx6ILe5eZEv+P+DKqyMPchxOr741JYlyfSrO8AcWvxfXPr/+Fx1ghbHuBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XkHRmM8f; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XkHRmM8f" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747906613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hDHCSn2rrDn0eR68mmoruWEApHPw0SjaUXgvWHvFihE=; b=XkHRmM8f1YfuUYH5E9M8Dr/uj/bl1Nt1O5k1wgHaSzCcDhx4JykIcHLagYre8dsBBdAxzJ 4YSZT04uTydyEB/22ffkNcat03AT0/J7k3NUVr+G2MRb/Q/djZr6RCI1vKpkMOqBBFYkIO CdvBtJ7UPXIEjYO0mpObON2UbircvfQ= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-314-OceEgFH5Ot2Xi-M3Qsfv7Q-1; Thu, 22 May 2025 05:36:51 -0400 X-MC-Unique: OceEgFH5Ot2Xi-M3Qsfv7Q-1 X-Mimecast-MFC-AGG-ID: OceEgFH5Ot2Xi-M3Qsfv7Q_1747906610 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-ad56bfb164eso453175666b.2 for ; Thu, 22 May 2025 02:36:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747906609; x=1748511409; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hDHCSn2rrDn0eR68mmoruWEApHPw0SjaUXgvWHvFihE=; b=pc7d508xRHWkdz7iJMOdeJYrz+Pj7xhjZ2MfNi8OhHOIyKsUjhKzLRVkI1bvlEHvHu gfAgkl0jbAbtXVCnHH/W1360F3t4qNCHE7g59SWaL/q3cTi30QYQqv4+SbC4oNZftYB0 N5VZhCUzRTU6sXvNPRx7MjxMN2oDLYQpqSj6uAut6cTvucnSG/BLnbAfVIMl9GnxWUWF BASIRycYnmjNvAXyxgc35hwWJVCqFuqgzG2LKTMZerHlr8BHv1Y1Vtcy4OkifGpJUJ+6 2zNQ3C/rQL+6NGGbf8Emm4j+Zb/enDpJt0FlrLPqVFwQoxS68HN8MT4ojRUYH4RKVES9 ucuQ== X-Gm-Message-State: AOJu0YyKFGS0Szk129ei2dAArmamu2ARJif37lkVqVFzei6yCX6tcONh SjNRfY9FxHS/eExzyw80LMvHtFI4latb/kLHcRKi5IGKYor5R3/fBI+kgvpMlm3k0E4sZB9AxE1 PDelp09RAMXs1Qcp49QaeGTETEyJYGGyShWusXmFGgQ1Vtn+jVb5hw3Akj7rqWjM= X-Gm-Gg: ASbGncuo0oJpJbtiUKqzjEgseoVFY18B3v2lpf1LYddhm3laY7EmVVXOwU78EbKkDCb AWVKJTWUwximtFIAWV5of0dL2ZMnF1iOnHrzzFweXTWTmSC4FwlsBI8I+3xaTwULjQ90mFej28U uddLcHlyOo6Aif7qVQsJzu0cxfi08lgZzu2w1tnrEeL050qbKRW3w05kbKpG9nIpEle5VeQtBfp btYwnQa4lHzXcRD6zjP4IIbbkPug3d+rZXhlloW/NHsLBpclXC+1oPcBS+KYAr7ZYSzaJ1M/E5J hFX2fpP9Um0YYsfnjZj8JIS2XxCH+r4Y24MlsBLv2EHUo3g99z4Lqo0bnaUhkKsmDsRBghnZOJM on62wMDSH1j8fmWRG8VbJ0HqRGcc9yLxuK6CvQI7Srpg1xkWuCxmG3L0aLBUOyw== X-Received: by 2002:a17:907:968f:b0:ad2:53fc:a884 with SMTP id a640c23a62f3a-ad52d549101mr2313488366b.29.1747906609559; Thu, 22 May 2025 02:36:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEkt+cRiEtLvTfug96SnfCVbtLrVD/Hds5wFUbM5/CTbcUBhCNKQ2UGNlRxw27MHgFkES/aOw== X-Received: by 2002:a17:907:968f:b0:ad2:53fc:a884 with SMTP id a640c23a62f3a-ad52d549101mr2313484666b.29.1747906609060; Thu, 22 May 2025 02:36:49 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad52d4ca731sm1034015566b.166.2025.05.22.02.36.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 May 2025 02:36:48 -0700 (PDT) Message-ID: Date: Thu, 22 May 2025 11:36:47 +0200 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [pdx86-platform-drivers-x86:review-ilpo-next 109/109] drivers/platform/x86/ideapad-laptop.c:2044:3: error: field designator 'charge_types' does not refer to any field in type 'const struct power_supply_ext' To: kernel test robot , Jelle van der Waa , Sebastian Reichel Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Andy Shevchenko , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Armin Wolf References: <202505221051.khDhUKJ0-lkp@intel.com> From: Hans de Goede In-Reply-To: <202505221051.khDhUKJ0-lkp@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: oy5ET8EDZ2IJyE1UmNRXcXZRYml1syLDrI5s_y7f2ik_1747906610 X-Mimecast-Originator: redhat.com Content-Language: en-US, nl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 22-May-25 4:39 AM, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-ilpo-next > head: b2012b38080e2f92d43eca59e8249c174a27527c > commit: b2012b38080e2f92d43eca59e8249c174a27527c [109/109] platform/x86: ideapad: Expose charge_types > config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20250522/202505221051.khDhUKJ0-lkp@intel.com/config) > compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff) > rustc: rustc 1.78.0 (9b00956e5 2024-04-29) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250522/202505221051.khDhUKJ0-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202505221051.khDhUKJ0-lkp@intel.com/ > > All errors (new ones prefixed by >>): > >>> drivers/platform/x86/ideapad-laptop.c:2044:3: error: field designator 'charge_types' does not refer to any field in type 'const struct power_supply_ext' > 2044 | .charge_types = (BIT(POWER_SUPPLY_CHARGE_TYPE_STANDARD) | > | ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 2045 | BIT(POWER_SUPPLY_CHARGE_TYPE_LONGLIFE)), > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 1 error generated. > > > vim +2044 drivers/platform/x86/ideapad-laptop.c Hmm, this patch depends on: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git/commit/?h=for-next&id=c1f7375a246e5f810191a6c3031d2fa2b80e9f5e I guess that that patch is not in review-ilpo-next, maybe Sebastian can take this patch instead of taking it through pdx86-next ? Or it can be merged after 6.16-rc1 ? Regards, Hans > > 2039 > 2040 static const struct power_supply_ext ideapad_battery_ext = { > 2041 .name = "ideapad_laptop", > 2042 .properties = ideapad_power_supply_props, > 2043 .num_properties = ARRAY_SIZE(ideapad_power_supply_props), >> 2044 .charge_types = (BIT(POWER_SUPPLY_CHARGE_TYPE_STANDARD) | > 2045 BIT(POWER_SUPPLY_CHARGE_TYPE_LONGLIFE)), > 2046 .get_property = ideapad_psy_ext_get_prop, > 2047 .set_property = ideapad_psy_ext_set_prop, > 2048 .property_is_writeable = ideapad_psy_prop_is_writeable, > 2049 }; > 2050 >