From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D2862CA0
	for <llvm@lists.linux.dev>; Tue,  7 Dec 2021 14:37:28 +0000 (UTC)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
	by smtp-out2.suse.de (Postfix) with ESMTP id 829071FD56;
	Tue,  7 Dec 2021 14:37:20 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1638887840; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=486I88iG5iTiPXlrozcDOPpJfLCaalP50/kaI6xgM8s=;
	b=moHx4OzQMMSAegKyA5u7PneXP3PwdnVOP/mr407/5Ls5i6IvSWZ4uDS+/lw7fCwyYb8KKh
	rTGZROsSR23pYYK2t3QTGaOVuH867w9fVUwnStpX7KTCERqJgVVxTIwp32ftjKoYcw/yn/
	QaqB9+BmSowt1Mh73wUW2Aw7AbRbb0c=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1638887840;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=486I88iG5iTiPXlrozcDOPpJfLCaalP50/kaI6xgM8s=;
	b=F2vGVeUN+TLm8RtXXGzCqdnS68oeajvDTNJAAvzzT2KHdVQxGl6JZ0e9BLW+Gk7b4SF3VJ
	hWO8MvEj4H7P+DBQ==
Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42])
	by relay2.suse.de (Postfix) with ESMTP id 72E70A3B84;
	Tue,  7 Dec 2021 14:37:20 +0000 (UTC)
Date: Tue, 07 Dec 2021 15:37:20 +0100
Message-ID: <s5htufkmqfz.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: perex@perex.cz,
	tiwai@suse.com,
	nathan@kernel.org,
	ndesaulniers@google.com,
	alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev,
	Naresh Kamboju <naresh.kamboju@linaro.org>
Subject: Re: [PATCH] sound: ppc: beep: fix clang -Wimplicit-fallthrough
In-Reply-To: <20211207110053.695712-1-anders.roxell@linaro.org>
References: <20211207110053.695712-1-anders.roxell@linaro.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
Precedence: bulk
X-Mailing-List: llvm@lists.linux.dev
List-Id: <llvm.lists.linux.dev>
List-Subscribe: <mailto:llvm+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:llvm+unsubscribe@lists.linux.dev>
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII

On Tue, 07 Dec 2021 12:00:53 +0100,
Anders Roxell wrote:
> 
> Clang warns:
> 
> sound/ppc/beep.c:103:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
>         case SND_TONE: break;
>         ^
> sound/ppc/beep.c:103:2: note: insert 'break;' to avoid fall-through
>         case SND_TONE: break;
>         ^
>         break;
> 1 warning generated.
> 
> Clang is more pedantic than GCC, which does not warn when failing
> through to a case that is just break or return. Clang's version
> is more in line with the kernel's own stance in deprecated.rst.
> Add athe missing break to silence the warning.
> 
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

Thanks, applied.


Takashi