* [PATCH] scsi: isci: request: Fix an error code problem in isci_io_request_build
@ 2024-01-12 4:19 Su Hui
2024-01-15 8:45 ` Artur Paszkiewicz
2024-01-17 19:44 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Su Hui @ 2024-01-12 4:19 UTC (permalink / raw)
To: artur.paszkiewicz, jejb, martin.petersen, nathan, ndesaulniers,
morbo, justinstitt
Cc: Su Hui, dan.j.williams, linux-scsi, linux-kernel, llvm,
kernel-janitors
Clang static complains that Value stored to 'status' is never read.
Return 'status' rather than 'SCI_SUCCESS'.
Fixes: f1f52e75939b ("isci: uplevel request infrastructure")
Signed-off-by: Su Hui <suhui@nfschina.com>
---
drivers/scsi/isci/request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/isci/request.c b/drivers/scsi/isci/request.c
index 71f711cb0628..355a0bc0828e 100644
--- a/drivers/scsi/isci/request.c
+++ b/drivers/scsi/isci/request.c
@@ -3387,7 +3387,7 @@ static enum sci_status isci_io_request_build(struct isci_host *ihost,
return SCI_FAILURE;
}
- return SCI_SUCCESS;
+ return status;
}
static struct isci_request *isci_request_from_tag(struct isci_host *ihost, u16 tag)
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: isci: request: Fix an error code problem in isci_io_request_build
2024-01-12 4:19 [PATCH] scsi: isci: request: Fix an error code problem in isci_io_request_build Su Hui
@ 2024-01-15 8:45 ` Artur Paszkiewicz
2024-01-17 19:44 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Artur Paszkiewicz @ 2024-01-15 8:45 UTC (permalink / raw)
To: Su Hui, jejb, martin.petersen, nathan, ndesaulniers, morbo,
justinstitt
Cc: dan.j.williams, linux-scsi, linux-kernel, llvm, kernel-janitors
On 1/12/24 05:19, Su Hui wrote:
> Clang static complains that Value stored to 'status' is never read.
> Return 'status' rather than 'SCI_SUCCESS'.
>
> Fixes: f1f52e75939b ("isci: uplevel request infrastructure")
> Signed-off-by: Su Hui <suhui@nfschina.com>
Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: isci: request: Fix an error code problem in isci_io_request_build
2024-01-12 4:19 [PATCH] scsi: isci: request: Fix an error code problem in isci_io_request_build Su Hui
2024-01-15 8:45 ` Artur Paszkiewicz
@ 2024-01-17 19:44 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2024-01-17 19:44 UTC (permalink / raw)
To: Su Hui
Cc: artur.paszkiewicz, jejb, martin.petersen, nathan, ndesaulniers,
morbo, justinstitt, dan.j.williams, linux-scsi, linux-kernel,
llvm, kernel-janitors
> Clang static complains that Value stored to 'status' is never read.
> Return 'status' rather than 'SCI_SUCCESS'.
Applied to 6.8/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-17 19:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-12 4:19 [PATCH] scsi: isci: request: Fix an error code problem in isci_io_request_build Su Hui
2024-01-15 8:45 ` Artur Paszkiewicz
2024-01-17 19:44 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox