From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: tyreld@linux.ibm.com, martin.petersen@oracle.com,
jejb@linux.ibm.com, ndesaulniers@google.com, trix@redhat.com,
brking@linux.vnet.ibm.com, linux-scsi@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, llvm@lists.linux.dev,
patches@lists.linux.dev
Subject: Re: [PATCH] scsi: ibmvfc: Use 'unsigned int' for single-bit bitfields in 'struct ibmvfc_host'
Date: Fri, 13 Oct 2023 14:13:09 -0400 [thread overview]
Message-ID: <yq1r0lyl7bp.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20231010-ibmvfc-fix-bitfields-type-v1-1-37e95b5a60e5@kernel.org> (Nathan Chancellor's message of "Tue, 10 Oct 2023 13:32:37 -0700")
Nathan,
> Clang warns (or errors with CONFIG_WERROR=y) several times along the
> lines of:
>
> drivers/scsi/ibmvscsi/ibmvfc.c:650:17: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion]
> 650 | vhost->reinit = 1;
> | ^ ~
>
Applied to 6.7/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2023-10-13 18:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 20:32 [PATCH] scsi: ibmvfc: Use 'unsigned int' for single-bit bitfields in 'struct ibmvfc_host' Nathan Chancellor
2023-10-10 20:50 ` Nick Desaulniers
2023-10-13 18:13 ` Martin K. Petersen [this message]
2023-10-17 1:11 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1r0lyl7bp.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=brking@linux.vnet.ibm.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=patches@lists.linux.dev \
--cc=trix@redhat.com \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox