* [PATCH] sensors-detect: Move Winbond WPCD377I to the non-hwmon table
@ 2020-05-12 14:23 Jean Delvare
2020-05-13 10:08 ` Ondřej Lysoněk
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2020-05-12 14:23 UTC (permalink / raw)
To: lm-sensors
Move the detection entry for the Winbond WPCD377I to the
@non_hwmon_chip_ids table, where it belongs. This saves one line, and
more importantly prevents "not-a-sensor" from being accidentally
added to the list of kernel drivers.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
---
prog/detect/sensors-detect | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
--- lm-sensors.orig/prog/detect/sensors-detect 2020-05-12 11:08:57.101496194 +0200
+++ lm-sensors/prog/detect/sensors-detect 2020-05-12 16:18:49.375617471 +0200
@@ -719,11 +719,6 @@
i2c_addrs => [0x2c..0x2e],
i2c_detect => sub { emc6w201_detect(@_); },
}, {
- name => "Winbond WPCD377I",
- driver => "not-a-sensor",
- i2c_addrs => [0x2c..0x2e],
- i2c_detect => sub { lm85_detect(@_, 7); },
- }, {
name => "Analog Devices ADT7462",
driver => "adt7462",
i2c_addrs => [0x5c, 0x58],
@@ -1684,6 +1679,10 @@
i2c_addrs => [0x2c..0x2f],
i2c_detect => sub { w83791sd_detect(@_); },
}, {
+ name => "Winbond WPCD377I",
+ i2c_addrs => [0x2c..0x2e],
+ i2c_detect => sub { lm85_detect(@_, 7); },
+ }, {
name => "Fintek F75111R/RG/N (GPIO)",
i2c_addrs => [0x37, 0x4e],
i2c_detect => sub { fintek_detect(@_, 1); },
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sensors-detect: Move Winbond WPCD377I to the non-hwmon table
2020-05-12 14:23 [PATCH] sensors-detect: Move Winbond WPCD377I to the non-hwmon table Jean Delvare
@ 2020-05-13 10:08 ` Ondřej Lysoněk
0 siblings, 0 replies; 2+ messages in thread
From: Ondřej Lysoněk @ 2020-05-13 10:08 UTC (permalink / raw)
To: lm-sensors
Jean Delvare <jdelvare@suse.de> writes:
> Move the detection entry for the Winbond WPCD377I to the
> @non_hwmon_chip_ids table, where it belongs. This saves one line, and
> more importantly prevents "not-a-sensor" from being accidentally
> added to the list of kernel drivers.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> ---
> prog/detect/sensors-detect | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> --- lm-sensors.orig/prog/detect/sensors-detect 2020-05-12 11:08:57.101496194 +0200
> +++ lm-sensors/prog/detect/sensors-detect 2020-05-12 16:18:49.375617471 +0200
> @@ -719,11 +719,6 @@
> i2c_addrs => [0x2c..0x2e],
> i2c_detect => sub { emc6w201_detect(@_); },
> }, {
> - name => "Winbond WPCD377I",
> - driver => "not-a-sensor",
> - i2c_addrs => [0x2c..0x2e],
> - i2c_detect => sub { lm85_detect(@_, 7); },
> - }, {
> name => "Analog Devices ADT7462",
> driver => "adt7462",
> i2c_addrs => [0x5c, 0x58],
> @@ -1684,6 +1679,10 @@
> i2c_addrs => [0x2c..0x2f],
> i2c_detect => sub { w83791sd_detect(@_); },
> }, {
> + name => "Winbond WPCD377I",
> + i2c_addrs => [0x2c..0x2e],
> + i2c_detect => sub { lm85_detect(@_, 7); },
> + }, {
> name => "Fintek F75111R/RG/N (GPIO)",
> i2c_addrs => [0x37, 0x4e],
> i2c_detect => sub { fintek_detect(@_, 1); },
>
>
> --
> Jean Delvare
> SUSE L3 Support
Applied. Thanks!
Ondřej Lysoněk
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-13 10:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-12 14:23 [PATCH] sensors-detect: Move Winbond WPCD377I to the non-hwmon table Jean Delvare
2020-05-13 10:08 ` Ondřej Lysoněk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox