From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f46.google.com (mail-yx1-f46.google.com [74.125.224.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B11CE314B66 for ; Wed, 7 Jan 2026 09:29:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767778161; cv=none; b=sR6ydiYg58HRgIq4tjpFx/qKmYylRWpKJ7Zke7VK0fTjq5Oi3HdN4wbpviXSWX9URO/Kxc/79+G2Qupi5g6YcT5X0OS56ggUfoB01XwL9ZGV6fePGMzY+6Jee3ntAeIXy5PwA+J1v71PhFVhX2XKF3MwTUceSD8YWSALmnvrx/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767778161; c=relaxed/simple; bh=YskUE8ivh/0bvl2ccHBh6Q13s6fd7XMp1/zObXA0Cvc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m38J1JTepaMifydpNqVCogqr+CWdvrEPSBYu5R23/RxTRrvPaALHF2fldlIO65fgtZBB8PpR5RmnADR0yeepZMjBPwiht/HaieNilDHFGmMgvcwPpCO0K213Gh/Lc7dJk3dX4mykF1X9CFZ1BSqbPjYPupQpHqZ5eaiNyNfYkzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fPiNpb7Z; arc=none smtp.client-ip=74.125.224.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fPiNpb7Z" Received: by mail-yx1-f46.google.com with SMTP id 956f58d0204a3-646d9eb45afso1774952d50.2 for ; Wed, 07 Jan 2026 01:29:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767778158; x=1768382958; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wk512LwmO/uZGHz1Ojwhz3Ek5WphQWvtFTpjZjwnzlQ=; b=fPiNpb7ZMWL8fIasXzNlWtU+7Gv+9vTln14JvjWCRQoTUF9JFRM8xdXbjfA3rMWZM7 RAe7EjdENHY9DcfdLI+5oVpKxZ7Kf0+x2uIssu6c1yrd2Yr8nmSnw+OLxmDSKqJQu7MO 82p0kyxXggJmHDQVxm+Ueto3eTqIt87DZw3nK6olq8R07AhLE/17oFJ6zyeZ5SZHn0DW JJmUHFANfYe2JxNRlTPQIg1VMD+Ux4FtOXhh17ckReo5Pbp3pUwlqvyxbpgH/kkEbhVp wCHgYbYz7m7MAMOhw8J1CwUrZSt1V+YibyMSeb0Dolrz0NZsUzU7KyCjL7xj4XCrFfz7 x4FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767778158; x=1768382958; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wk512LwmO/uZGHz1Ojwhz3Ek5WphQWvtFTpjZjwnzlQ=; b=S8yGXQpeEhUAyA3vXvOa3W9hYqn11i3UyMzRsIlcYwe7nKoV44gYLkOaxiELL+tRDa EU4FWNUsUEKNbwyQSAlTm99eKbhXX6EQqTM7B+FhBNVwr0xyaHjXrDB82YedtPSRWIhg UzKhpInduPF/0RmzUgZcVuoLG9QoSoRkD6pGD5JiB3fRhfzP/gGwqG5XMv/7hQZptYQC NRpkR/NvQrMK7X+lXmz31cmrNvsZcFaErgoAIBh55w3qUcQa/MbI+Xmv0SratiHzwoGN akz7fH2/jG9jaW02/iqJWQ0Iavvano3ymXXTr04PLC166RVx0f86ftAhdwD1ejG0jPHD TBZA== X-Forwarded-Encrypted: i=1; AJvYcCVFAEXmeioHMPDBWaMBJGmQ32sjWfiZTsG74vU1DO52Bfn5ODHJmOrws9Dp1ziEJQO52nFsd0CeCe4=@lists.linux.dev X-Gm-Message-State: AOJu0YzngXy3+1y/GpYMpshmqOP9w4747OKjWwTxoFfZkrAjCyh9tje7 bD1HX5Fydz1d8Eguw1Ny7bcbNwKvy7bXAwsq6Hy7hRk6qK56lrbmrKW2 X-Gm-Gg: AY/fxX7e92X0ENf4WObOFxpul7StrFKREYeVptZ83yAdjmO+0bEdljFFPIhS/EQf3b/ cQMnWb6qQG9EoOb3Wavm3Uc+gWmTR8Ri0pImL3JBJLyF4lx2MJI5oDW6rYHhcyDWiXHYlHs56VC 0i60GKBK6gM7+A7oAxf4OYZU5/iKrpJZaDs0CLhJGVtJPxBSKgdglRIOpDzPBvbfcb/pZWr2OwB 4vXxGQpfntovsQaPAedHAf1CY/u5n5jkGyCq+AaBqd3p8EPZyAa5qnXd+AeskDpopvr5RgOFhcd 30qA1Uye/UHC5T1cdGtz8ZVpskSP6H6+uMIKqKNOIDmQy4mzd8Cx/5S5GdRyCDNVYA5h1n1D7sH G3mqQ/ShYQe/UHhAUM8rnCj3FiISnmhkoaaxZzDcLf2SKu0bF/hBnu14My973xCxIcR/hhaNzT5 zPWkWHBkFZLw4KqSRN0uHvqI+GkU0t5+jwRNn2Sw== X-Google-Smtp-Source: AGHT+IGPYSkTJQTXRdeZJNO0Ptp1UF4C4ZvN+4Y+pwY9mfVj1KcuNobxA+hhEKXT47wj8D4Ny+QBYg== X-Received: by 2002:a05:690e:1483:b0:644:60d9:8654 with SMTP id 956f58d0204a3-64716c69eccmr1598952d50.87.1767778157608; Wed, 07 Jan 2026 01:29:17 -0800 (PST) Received: from [192.168.2.226] (104.194.78.75.16clouds.com. [104.194.78.75]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6470d80be64sm1865006d50.6.2026.01.07.01.28.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jan 2026 01:29:16 -0800 (PST) Message-ID: <080e493a-e4f1-4c97-a3e1-f76f126b5213@gmail.com> Date: Wed, 7 Jan 2026 17:28:36 +0800 Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/pgtable: convert pgtable_t to ptdesc pointer To: Mike Rapoport , alexs@kernel.org Cc: Richard Henderson , Matt Turner , Magnus Lindholm , Vineet Gupta , Russell King , Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Catalin Marinas , Guo Ren , Brian Cain , Huacai Chen , WANG Xuerui , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Andy Lutomirski , Chris Zankel , Max Filippov , Arnd Bergmann , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , "open list:ALPHA PORT" , open list , "open list:SYNOPSYS ARC ARCHITECTURE" , "moderated list:ARM PORT" , "open list:MMU GATHER AND TLB INVALIDATION" , "open list:MMU GATHER AND TLB INVALIDATION" , "open list:C-SKY ARCHITECTURE" , "open list:QUALCOMM HEXAGON ARCHITECTURE" , "open list:LOONGARCH" , "open list:M68K ARCHITECTURE" , "open list:MIPS" , "open list:OPENRISC ARCHITECTURE" , "open list:PARISC ARCHITECTURE" , "open list:RISC-V ARCHITECTURE" , "open list:SUPERH" , "open list:USER-MODE LINUX (UML)" References: <20260107064642.15771-1-alexs@kernel.org> Content-Language: en-US From: Alex Shi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026/1/7 17:05, Mike Rapoport wrote: > On Wed, Jan 07, 2026 at 02:46:35PM +0800,alexs@kernel.org wrote: >> From: Alex Shi >> >> After struct ptdesc introduced, pgtable_t should used it instead of old >> struct page pointer. The only thing in the way for this change is just >> pgtable->lru in pgtable_trans_huge_deposit/withdraw. >> >> Let's convert them into ptdesc and use struct ptdesc* as pgtable_t. >> Thanks testing support from kernel test robot >> >> Signed-off-by: Alex Shi >> --- > ... > >> diff --git a/arch/arm/include/asm/pgalloc.h b/arch/arm/include/asm/pgalloc.h >> index a17f01235c29..1a3484c2df4c 100644 >> --- a/arch/arm/include/asm/pgalloc.h >> +++ b/arch/arm/include/asm/pgalloc.h >> @@ -96,12 +96,12 @@ pte_alloc_one(struct mm_struct *mm) >> { >> struct page *pte; >> >> - pte = __pte_alloc_one(mm, GFP_PGTABLE_USER | PGTABLE_HIGHMEM); >> + pte = ptdesc_page(__pte_alloc_one(mm, GFP_PGTABLE_USER | PGTABLE_HIGHMEM)); > When ptdesc will be separated from struct page, ptdesc_page() would fail if the > allocation failed. This line should be split into something like > > struct ptdesc *ptdesc = __pte_alloc_one(...); > if (!ptesc) > return NULL; > pte = ptdesc_page(ptdesc); > > Right, I will fix this. and sent the 2nd version. Thanks a lot! >> if (!pte) >> return NULL; >> if (!PageHighMem(pte)) >> clean_pte_table(page_address(pte)); >> - return pte; >> + return page_ptdesc(pte); >> } >> >> static inline void __pmd_populate(pmd_t *pmdp, phys_addr_t pte, > -- Sincerely yours, Mike. >