Re: [PATCH 3/3] ASoC: dt-bindings: Add support for Loongson audio card

[Krzysztof Kozlowski <krzk@kernel.org>]

On 05/06/2023 14:09, YingKun Meng wrote:
> From: Yingkun Meng <mengyingkun@loongson.cn>
> 
> The audio card uses loongson I2S controller present in 7axxx/2kxxx chips
> to transfer audio data.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.  It might happen, that command when run on an older
kernel, gives you outdated entries.  Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least DT list (maybe more), so this won't be tested.
Please resend and include all necessary entries.

> 
> Signed-off-by: Yingkun Meng <mengyingkun@loongson.cn>
> ---
>  .../sound/loongson,ls-audio-card.yaml         | 64 +++++++++++++++++++
>  1 file changed, 64 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml b/Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml
> new file mode 100644
> index 000000000000..f1d6ee346bb3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/loongson-audio-card.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Loongson generic ASoC audio sound card.

What is a "generic audio card"? Does it even match hardware? Bindings
are supposed to describe hardware, which is usually very specific.

Also: Drop full stop. It's a title.


> +
> +maintainers:
> +  - Yingkun Meng <mengyingkun@loongson.cn>
> +
> +description:
> +  Generic ASoC audio device for loongson platform.
> +
> +properties:
> +  compatible:
> +    const: loongson,ls-audio-card
> +
> +  model:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description: User specified audio sound card name
> +
> +  mclk-fs:
> +    $ref: simple-card.yaml#/definitions/mclk-fs
> +
> +  cpu:
> +    description: Holds subnode which indicates cpu dai.
> +    type: object
> +    additionalProperties: false
> +    properties:
> +      sound-dai:
> +        maxItems: 1

In the cpu: required with sound-dai

> +
> +  codec:
> +    description: Holds subnode which indicates codec dai.
> +    type: object
> +    additionalProperties: false
> +    properties:
> +      sound-dai:
> +        maxItems: 1

In the codec: required with sound-dai

No multiple dai links? Are you sure this card is so limited?


Best regards,
Krzysztof