From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A50B417FF5 for ; Tue, 30 May 2023 12:03:04 +0000 (UTC) X-GND-Sasl: alexandre.belloni@bootlin.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1685448177; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7CSRmaE6JhiYga7TPE+m6X9B1ZhYPe18KEKuurrlc1s=; b=BnDg/KM0HCEuPhQEczxYX0epEE8tK793htPY2GFqK5/Zp6N1pp55AqFzdds8A2MVgNbG3o LtS0qTp+BfCFBxNYOxvMbTG8GMvMUhtwMcYT6qW2DLVqD+iZkVDiSbXYVH55bd9ucpY39i XAkYghCMdpcc8/yJIPrk+f3HgI/i4zTz5QkylYAiLCxUiyfUJOTl0qNj5+i/4pcYcH71OG BqKOkDbWZawF5wip3pJHa6ETSnkKGlJTAMQkKxLE6nAvGGKLe1aEw/17JSZXMZ+3mkPn4N kkjq7TjQp4mgLyzXT1y25E0Pl4Bwh1Is9VnANufeqx+LK57YnV3XdeVRshrzMw== X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com X-GND-Sasl: alexandre.belloni@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 76A4424000A; Tue, 30 May 2023 12:02:54 +0000 (UTC) Date: Tue, 30 May 2023 14:02:54 +0200 From: Alexandre Belloni To: Binbin Zhou Cc: Krzysztof Kozlowski , Conor Dooley , Keguang Zhang , Jiaxun Yang , Conor Dooley , Binbin Zhou , Alessandro Zummo , linux-rtc@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, Huacai Chen , Huacai Chen , Xuerui Wang , loongarch@lists.linux.dev, Thomas Bogendoerfer , "linux-mips@vger.kernel.org" , zhao zhang , Yang Ling , loongson-kernel@lists.loongnix.cn Subject: Re: [PATCH V4 1/5] dt-bindings: rtc: Remove the LS2X from the trivial RTCs Message-ID: <20230530120254a7ee88f0@mail.local> References: <20230527-passing-unfixed-39e01b787808@spud> <14EF9F21-8150-40D9-8870-E9151C4882CF@flygoat.com> <20230527-poet-antarctic-cc02aa60ab52@spud> <6845b6ce-06a8-9a0c-7f04-50fa906cd1e4@linaro.org> Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 30/05/2023 19:39:50+0800, Binbin Zhou wrote: > Hi Krzysztof: > > LS7A bridge chip can be considered as a combination of South and North > bridge. Generally, it will be connected to the Loongson-3 series CPUs. > LS2K500/LS2K1000/LS2K2000 refers to the LS2K series embedded CPU chip. > > Therefore, from the understanding of the driver code, I don't think it > is appropriate to fallback them together. Please pardon me if this > view does not apply to dt-binding. > > If fallback is necessary, can we have this: > > Let ls7a remain a separate item. > > "loongson,ls1b-rtc" > "loongson,ls1c-rtc", "loongson,ls1b-rtc" Based on Keguang's feedback, "loongson,ls1b-rtc" is not a fallback for "loongson,ls1c-rtc" as it is missing registers, keep it standalone. > "loongson,ls7a-rtc" > "loongson,ls2k0500-rtc" > "loongson,ls2k2000-rtc", "loongson,ls2k0500-rtc" > "loongson,ls2k1000-rtc" > > { .compatible = "loongson,ls1b-rtc", .data = &ls1x_rtc_config } > { .compatible = "loongson,ls7a-rtc", .data = &generic_rtc_config } > { .compatible = "loongson,ls2k0500-rtc", .data = &generic_rtc_config } > { .compatible = "loongson,ls2k1000-rtc", .data = &ls2k1000_rtc_config } > > Thanks. > Binbin > > > > > > > > > Which one do you think is more suitable for us? > > > > Use fallbacks for some. You pointed difference in alarm for ls1x, right? > > If so, then they can stay separate. > > > > ls2k500 and ls2k2000 seem compatible with each other so should use fallback. > > > > Best regards, > > Krzysztof > > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com