From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F5A729D29B for ; Fri, 17 Oct 2025 00:33:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760661202; cv=none; b=pMMmvc/wcKvRhIo6QMq5BPvkkTDuUGwbE7mKxC1QC6GpzB8DlPgDltyMTOwnI1K3EqhEHTi3uT7VAb97wi/VnsFahZfetJUvWZPFKlsL3k5bAyGgUIctK5d1oiBgmVfz13zdOiZA78c36QeQ531DMocIt7bW7tyIORoz9BMuvyE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760661202; c=relaxed/simple; bh=tg0l56HvAdoWWKikkxStnVhmDSB2cUfpRDPGIT/ddFc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=KMIFt5kffBKQ9n4PUgZ1htawutgC/8SiGB5GA+7Nx2z0dZ/+64T21twEsy/EnLkytJaxwHwJbvy/CxxF2IARmm6vfKd2LSWSgaCvboKwkMduQX27+nU4DJSBQz0/g9oeDBZXadKiTAo6GVuhvNWwR+x+3Y5GuMFvvkzc/h6rxYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Qkbmeseu; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Qkbmeseu" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-290ab8f5af6so10480375ad.3 for ; Thu, 16 Oct 2025 17:33:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1760661200; x=1761266000; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=Et3yNXLGMeuamTbAzxTVAbjwKav6YdsiHYhgXHS+lqo=; b=QkbmeseuEJmsD0CXY/fWJzEBI0bnQdfZZ5meviTa2Z2S0P1pjws7pC+vxXFZ9aGcPG OUfI/V7yuPqK/DQLakttk1atrkKFiXgOhdcV0a5KQNOqBOACRHsOznSPPnvKBvn8Cj4W omBajeieltkW6jm1nutdvH9dM0LCi6RRmJIr+ENHXHuQr/nH1GtMCjlLPZzclKQijCjA FujfeYojRyEWNxrpkKnZLh0M6H5WcFk8DwA7JU9XboRuRWBjl7dYZjXmxhkV+SvoIk8+ 32GVLGEXWHTpooZcWEj6m3uyiSZYLnaQgpFjP8IH/SypJ52i3YOIHHC3Yi+s1Lo1QIhc TpIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760661200; x=1761266000; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Et3yNXLGMeuamTbAzxTVAbjwKav6YdsiHYhgXHS+lqo=; b=GslVX4V6W1U5WMoDZrVcZJM2L7KfrqoGxZQ4OvToias8t/clvEIZxW3h5vhtRRJNOq vg1tIe4rt6LWUqu2o3b7Dr5hBjNZ4/nc4d1/wirVzinPI2yyjS4+t0J6yoERJK3c8054 54OSWsBKf5N+xY7+Gst3qyVo/P1UBa7GdYD1qzFLWhCNICl05wB9igwzEdBkbLs6aiwZ zbbF/bgNF8vB8+oLXr/HwsJ2ReJsmuuTqEmJxmb7Jq4mNYT3yTWYO8J3gzuQ9pkbdzgJ 7dLOBDFVSQIIFVbhoNTM7Y5IXTtf05V54Gc9RWbTpcqyW/Vr77YfNCI3/6pO93sGJEQ0 6egg== X-Forwarded-Encrypted: i=1; AJvYcCWfzdtlzPHeUbte9b2XVEUNE9Xn9aC5fD6EVxK8QP/iOHgmrRz+1ZrvLOqqsp0Iq9fCltQR4MbPNdU=@lists.linux.dev X-Gm-Message-State: AOJu0YyjB22tHZCdpo2E9wl7kjn6tk/bypW4IgzhKTArkUc/SVz4OUUm cS7lghMdpB4A7+xhUVyUtkk0XjCFSIoSH7wusiEoySqQC95OxYIO5/Ijvi14Cru3YLhjXs4hZBI SWnqS7g== X-Google-Smtp-Source: AGHT+IF8DlOutKWl0i8m+B1TfQqXPthFr1585kr7hlu5o2md7/0QzZzZHhKvSNGyUqeTAbPYZaEbqdnIEp8= X-Received: from pjbmr8.prod.google.com ([2002:a17:90b:2388:b0:330:49f5:c0a7]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:e544:b0:26b:5346:5857 with SMTP id d9443c01a7336-290c9cd4b82mr18056465ad.24.1760661200311; Thu, 16 Oct 2025 17:33:20 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 16 Oct 2025 17:32:36 -0700 In-Reply-To: <20251017003244.186495-1-seanjc@google.com> Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251017003244.186495-1-seanjc@google.com> X-Mailer: git-send-email 2.51.0.858.gf9c4a03a3a-goog Message-ID: <20251017003244.186495-19-seanjc@google.com> Subject: [PATCH v3 18/25] KVM: TDX: Derive error argument names from the local variable names From: Sean Christopherson To: Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Madhavan Srinivasan , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Sean Christopherson , Paolo Bonzini , "Kirill A. Shutemov" Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, x86@kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, Ira Weiny , Kai Huang , Michael Roth , Yan Zhao , Vishal Annapurve , Rick Edgecombe , Ackerley Tng , Binbin Wu Content-Type: text/plain; charset="UTF-8" When printing SEAMCALL errors, use the name of the variable holding an error parameter instead of the register from whence it came, so that flows which use descriptive variable names will similarly print descriptive error messages. Suggested-by: Rick Edgecombe Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/tdx.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c index 2d587a38581e..e517ad3d5f4f 100644 --- a/arch/x86/kvm/vmx/tdx.c +++ b/arch/x86/kvm/vmx/tdx.c @@ -41,14 +41,15 @@ #define TDX_BUG_ON(__err, __fn, __kvm) \ __TDX_BUG_ON(__err, #__fn, __kvm, "%s", "") -#define TDX_BUG_ON_1(__err, __fn, __rcx, __kvm) \ - __TDX_BUG_ON(__err, #__fn, __kvm, ", rcx 0x%llx", __rcx) +#define TDX_BUG_ON_1(__err, __fn, a1, __kvm) \ + __TDX_BUG_ON(__err, #__fn, __kvm, ", " #a1 " 0x%llx", a1) -#define TDX_BUG_ON_2(__err, __fn, __rcx, __rdx, __kvm) \ - __TDX_BUG_ON(__err, #__fn, __kvm, ", rcx 0x%llx, rdx 0x%llx", __rcx, __rdx) +#define TDX_BUG_ON_2(__err, __fn, a1, a2, __kvm) \ + __TDX_BUG_ON(__err, #__fn, __kvm, ", " #a1 " 0x%llx, " #a2 " 0x%llx", a1, a2) -#define TDX_BUG_ON_3(__err, __fn, __rcx, __rdx, __r8, __kvm) \ - __TDX_BUG_ON(__err, #__fn, __kvm, ", rcx 0x%llx, rdx 0x%llx, r8 0x%llx", __rcx, __rdx, __r8) +#define TDX_BUG_ON_3(__err, __fn, a1, a2, a3, __kvm) \ + __TDX_BUG_ON(__err, #__fn, __kvm, ", " #a1 " 0x%llx, " #a2 ", 0x%llx, " #a3 " 0x%llx", \ + a1, a2, a3) bool enable_tdx __ro_after_init; -- 2.51.0.858.gf9c4a03a3a-goog