From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24DE036E372 for ; Thu, 30 Oct 2025 20:10:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761855014; cv=none; b=mmMGBUbcotlDVPSFQK+3jGeyM0oKz2Zck3wIbdoz5MHrfypADtu6nRzZblxzuNRJZrY7bRUieG3Uul2i1c+PCIyF1GeBmtSoTdu/K8pbMTera0CzcxRBgiL7GS72CBFScL+L/95G+0sO2XgZMcq06W7/DYjnN+I8PfQUpzTgcv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761855014; c=relaxed/simple; bh=Q2c6cNYSKoGYP4CYOI8nHGq0kI85fWBL8NZOIPZmdhU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=DUzb8xlCEkunOIuLuWZqTcr9tjuJ8n6iDsXYkjkhlyJ0QezVu83kQWaiPzFTmUVrGQA00wq/K7pygx86sSPKIo8tjAkX0oELLI7SjRB+UPHNoBNgyuvPQAGixlzI7FToOmfCECF4AkqBcoDeKa3vMCETR314jiFtpI3pYrO9zoY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=umVi+29G; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="umVi+29G" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-32eb18b5659so1098785a91.2 for ; Thu, 30 Oct 2025 13:10:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1761855011; x=1762459811; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=pr+88J8V2FFjpoCz/RKjLuOTT6WQDejtYqs45iSU51c=; b=umVi+29GlBMqC9PBZwUtq52Zvsm9mhX1HUBpuKEf7XecdfuWCGrPnSkLz4djFm4ReC ibPTQ1nVHKXnicXup3lM1Mg9YYRg6W6j2EFq5USq354esNTw5oFa/CbNUtJ/XRsZP64D 3VVktGd21ALuRPrIWmQAg4OeAEsrjDDNJxTzhpBTjJMQ0z0BfXHIJ7U0iqzcC519OGYc 0ehnRNhzB7SKzSGxyCNfl516wBp53si0mLAiMnO9hTlwYAUCaxD8I22OgXPtI4cOwwjd NzS/Px4A0SXFUDveGjVCZwJsULMigMsrk7a2//sepo5pbwcTQnkQONYUuofUAb61Jc2Q OLrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761855011; x=1762459811; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pr+88J8V2FFjpoCz/RKjLuOTT6WQDejtYqs45iSU51c=; b=sK7+caCUaOGFlGmJOZYIR1tlpCrQPeLQ9JccK98fKfRJaIoeGk/NKyon6EUoYnU/QH DqgvjVC2ViOWd8Ds+Xxnlsg7xLI8XFY336CMlAtMM1p6pM3y8bs7l1D8rliACAxIo3+S tDrKQxmQQKGBgexV6qeIyz+UGleT7iBOHLb0cYKcWgJQlBlTN86DjVEC/5jVukYa1ugU JN3M0mVG+74Q3ycyIm5Wk1qEtaHryHSdvrPLAB2bHX9gjmr3XfB14nsqKDScc3ShaQbF X6/w0iuqOP0sM38hXXK82W1K75FHibsiTjmgRjiEIcG4XL8aMeiK+uwJGjzYuihfqi1f gdNQ== X-Forwarded-Encrypted: i=1; AJvYcCWFHwg8qBN/punl8jGYKLxQHmENamo0hmRMNj8aPDS9ne1zdSHccTox8Vs3d3wCWbu2qGi4dmSeD4k=@lists.linux.dev X-Gm-Message-State: AOJu0YxgqXXjyeoT1+Gm9WlRbGOhTAaY0d8WSSylWyfvg0cQM/KF3XlF Ru1A3ttwpBlfQj8G0XgMPAEHXLciZEXVXv8ySxcO1yzGpjElfnf+ngL2ONGV56eTg6HYMByVqCa dc4ZFKg== X-Google-Smtp-Source: AGHT+IHqKKH3jALoT7jRe2OHIQ2mXXV+pELYiJKGwKEjf4ZIM+twJ+5jG3TjV8eGRlfpIUNYgujs+bg0n4E= X-Received: from pjji4.prod.google.com ([2002:a17:90a:6504:b0:33b:dccb:b328]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:4c8d:b0:33f:ebc2:63a with SMTP id 98e67ed59e1d1-34082fc2cb0mr1192488a91.14.1761855011296; Thu, 30 Oct 2025 13:10:11 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 30 Oct 2025 13:09:28 -0700 In-Reply-To: <20251030200951.3402865-1-seanjc@google.com> Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251030200951.3402865-1-seanjc@google.com> X-Mailer: git-send-email 2.51.1.930.gacf6e81ea2-goog Message-ID: <20251030200951.3402865-6-seanjc@google.com> Subject: [PATCH v4 05/28] KVM: x86/mmu: WARN if KVM attempts to map into an invalid TDP MMU root From: Sean Christopherson To: Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Madhavan Srinivasan , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Sean Christopherson , Paolo Bonzini , "Kirill A. Shutemov" Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, x86@kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, Ira Weiny , Kai Huang , Binbin Wu , Michael Roth , Yan Zhao , Vishal Annapurve , Rick Edgecombe , Ackerley Tng Content-Type: text/plain; charset="UTF-8" When mapping into the TDP MMU, WARN (if KVM_PROVE_MMU=y) if the root is invalid, e.g. if KVM is attempting to insert a mapping without checking if the information and MMU context is fresh. Signed-off-by: Sean Christopherson --- arch/x86/kvm/mmu/tdp_mmu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c index c5734ca5c17d..440fd8f80397 100644 --- a/arch/x86/kvm/mmu/tdp_mmu.c +++ b/arch/x86/kvm/mmu/tdp_mmu.c @@ -1273,6 +1273,8 @@ int kvm_tdp_mmu_map(struct kvm_vcpu *vcpu, struct kvm_page_fault *fault) struct kvm_mmu_page *sp; int ret = RET_PF_RETRY; + KVM_MMU_WARN_ON(!root || root->role.invalid); + kvm_mmu_hugepage_adjust(vcpu, fault); trace_kvm_mmu_spte_requested(fault); -- 2.51.1.930.gacf6e81ea2-goog