Re: [PATCH v2 2/7] dt-bindings: interrupt-controller: loongson,pch-pic: Change to unevaluatedProperties

[Rob Herring <robh@kernel.org>]

On Fri, Dec 19, 2025 at 04:46:49PM +0800, Binbin Zhou wrote:
> Change additionalProperties to unevaluatedProperties because it refs to
> interrupt-controller.yaml.
> 
> Fix below CHECK_DTBS warnings:
> arch/loongarch/boot/dts/loongson-2k2000-ref.dtb: interrupt-controller@10000000 (loongson,pch-pic-1.0): '#address-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
>         from schema $id: http://devicetree.org/schemas/interrupt-controller/loongson,pch-pic.yaml
> 
> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> ---
>  .../interrupt-controller/loongson,pch-pic.yaml         | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-pic.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-pic.yaml
> index b7bc5cb1dff2..cf235ca57a2f 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-pic.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,pch-pic.yaml
> @@ -14,6 +14,9 @@ description:
>    transforming interrupts from on-chip devices into HyperTransport vectorized
>    interrupts.
>  
> +allOf:
> +  - $ref: /schemas/interrupt-controller.yaml#

This is not really needed because interrupt-controller.yaml is applied 
to all nodes named 'interrupt-controller', but fine to add.

> +
>  properties:
>    compatible:
>      const: loongson,pch-pic-1.0
> @@ -34,14 +37,18 @@ properties:
>    '#interrupt-cells':
>      const: 2
>  
> +  '#address-cells':
> +    const: 0
> +

This part is the only change actually needed.

>  required:
>    - compatible
>    - reg
>    - loongson,pic-base-vec
>    - interrupt-controller
>    - '#interrupt-cells'
> +  - '#address-cells'

Unless there's some guarantee that this node is *always* referenced by 
an interrupt-map property, then it's not really required. After all, 
presumably things worked without it.

>  
> -additionalProperties: false
> +unevaluatedProperties: false

Also not needed.

>  
>  examples:
>    - |
> @@ -50,6 +57,7 @@ examples:
>        compatible = "loongson,pch-pic-1.0";
>        reg = <0x10000000 0x400>;
>        interrupt-controller;
> +      #address-cells = <0>;
>        #interrupt-cells = <2>;
>        loongson,pic-base-vec = <64>;
>        interrupt-parent = <&htvec>;
> -- 
> 2.47.3
>