From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBB0C312828; Tue, 20 Jan 2026 23:39:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768952377; cv=none; b=nWfvVA6KFGmV5XCNfK7y7evkO2lZg7O0jCZCi+l5kmTyDXkeEdMGlCLwQeLF2ovacAvBJGYDfB/xYbd4ejH4iXRYhdRzfxU0PAtzL3rx0FXiPI+JRIaHKRwJo5J2Lwyr8I039dnc2Gsz3cO5bvvyatEx8riW+JJ9wLeM/6M5mUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768952377; c=relaxed/simple; bh=HIDptQyxrl7l/EyyrCmFy4C2HhqwWYyybCVYMiH9RDU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HQORVyCWqulvFDevf3KSNG9BM5c0wUC7JjD/e0CsFWtr7yqFAZxPcXYvbr/35pgZuLCbR5XNe9oc4KCHOeFs8Wl9xNcUOWBRhch6mLm58wf2Wbs5Ksqu2wnnefj0qVbGctZo8Fz/mCi0bFxiVdFu9/Kt97Z8yrZl/N2YWcDnihU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ofou5bRu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ofou5bRu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29C94C16AAE; Tue, 20 Jan 2026 23:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768952376; bh=HIDptQyxrl7l/EyyrCmFy4C2HhqwWYyybCVYMiH9RDU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ofou5bRu6mNASNchMBpMdKFge85/CDtJYpoL7z083Csq0rHXZT0Pge5nLG3WfPxS5 w9bdNnfQfdqbb34Ujrrr2Sy2t2anfTsFpwsmm33CJDIPCkta5v+gkKdNz+03t75FtC JNO/j7HFoa4xLlPNl0kCzD2dcNqzdf4dopSOZM7vwKFgYjYPUc/ixiIRKi5D08IwWJ fSCO/c8hdGwlBeaW8HCafvug79cDbZOVzQC6i1RJt0MIYUB8gKX1MCZDVOUet1MvXO obA3WCP3gVJxp7ifrJYDN1yAfSVmsiQHX/9t7kNGOY/lhgBkyMz/3mdhUnxKn8YJf2 6ZJ9Y8YZB0VQA== Date: Tue, 20 Jan 2026 23:39:30 +0000 From: Conor Dooley To: Alexandre Belloni Cc: Binbin Zhou , Binbin Zhou , Huacai Chen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-rtc@vger.kernel.org, Xiaochuang Mao , Huacai Chen , Xuerui Wang , loongarch@lists.linux.dev, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, Keguang Zhang Subject: Re: [PATCH v3 1/3] dt-bindings: rtc: loongson: Correct Loongson-1C interrupts property Message-ID: <20260120-proposal-retry-d0a1f3de10ea@spud> References: <20260119-tricking-premiere-ada70700f804@spud> <20260120075045e7e864ba@mail.local> <20260120-cubical-harmonica-a7b7bbb26b08@spud> <20260120224920df0cf2ac@mail.local> Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lnVaNHpePim2zo65" Content-Disposition: inline In-Reply-To: <20260120224920df0cf2ac@mail.local> --lnVaNHpePim2zo65 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 20, 2026 at 11:49:20PM +0100, Alexandre Belloni wrote: > On 20/01/2026 19:24:09+0000, Conor Dooley wrote: > > On Tue, Jan 20, 2026 at 08:50:45AM +0100, Alexandre Belloni wrote: > > > On 19/01/2026 18:24:36+0000, Conor Dooley wrote: > > > > On Sat, Jan 17, 2026 at 10:26:48AM +0800, Binbin Zhou wrote: > > > > > The `interrupts` property indicates an RTC alarm interrupt, which= is > > > > > required for RTCs that support the alarm feature, which is not su= pported > > > > > by the Loongson-1C RTC. We exclude it for a more accurate descrip= tion. > > > > >=20 > > > > > Changing the `allowed` property is ABI-breaking behavior, but > > > > > throughout the existing Loongson DTS{i}, the description of the R= TC > > > > > nodes conforms to the modified bingding rules. > > > >=20 > > > > Right, changing properties is an ABI break, but when following the = ABI > > > > would've produced something non-functional, breaking it is not real= ly > > > > relevant. > > >=20 > > >=20 > > > But the HW has the interrupt, the fact that is not functional doesn't > > > mean it isn't there. I thought we should describe the hardware? > >=20 > > Does the hardware have it? My interpretation of the commit message was > > that it didn't have the alarm feature and thus no interrupt? Unless the > > interrupt has some other purpose, in which case yeah we shouldn't accept > > this change and only the new device should permit there being no > > interrupt. >=20 > The datasheet shows the interrupt coming out of the RTC and it has the > proper registers. Why it is not functional is not clear to me. Right.. Perhaps Binbin can explain that then? If the interrupt is actually there then the dts should get fixed instead IMO. --lnVaNHpePim2zo65 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaXASMgAKCRB4tDGHoIJi 0oRlAP9p3ULEJ4S1rYcPHyjv7qsgCkCsdws862oF5id1UCAfTgD7Bs1fxn8Fbfh9 P5o3JDKXXNSLklqH3ahOVJRH4BaNyAs= =wCOM -----END PGP SIGNATURE----- --lnVaNHpePim2zo65--