From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29F8D49691E for ; Tue, 3 Mar 2026 16:09:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772554158; cv=none; b=X5XC6+iUetsr0TvCiV/rPfyoHeYWRzqVmLpcyb6JrAzQBFu/6UGKuUbudUKoDiTLXGpMWNdGBpuaw7Ygi6+7PiQRLCMGCFMBKwP3+bAen35iQXvyt7XdF//Mwy+unPVQw6vsZ5MDqpTNVjb3wggw8wU004CJ4V+C1gnnNj1/kw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772554158; c=relaxed/simple; bh=jDsNUvqgl7v9nLKyfwmMiQvl2RWvM1GW2wkBf9+Y8Zg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TFKdquJwR9/Xs7Bh5SFG6zqpRb90fHUofXCo8hfErnf2C55knHWWyJkY+2R0U2dPNE6uqBkSiqDIDh6+x07+0KJsDu85g4/vkmSWetUBzCYm6PimjsgxA7b2B9Cv2leNGxiVrAsG5y6UILXq+vspplduVS2+mzlEpH8IZ5fB5Js= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id C608B68BFE; Tue, 3 Mar 2026 17:09:11 +0100 (CET) Date: Tue, 3 Mar 2026 17:09:11 +0100 From: Christoph Hellwig To: Eric Biggers Cc: Christoph Hellwig , Andrew Morton , Richard Henderson , Matt Turner , Magnus Lindholm , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Herbert Xu , Dan Williams , Chris Mason , David Sterba , Arnd Bergmann , Song Liu , Yu Kuai , Li Nan , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-arch@vger.kernel.org, linux-raid@vger.kernel.org Subject: Re: [PATCH 09/25] xor: move generic implementations out of asm-generic/xor.h Message-ID: <20260303160911.GI7021@lst.de> References: <20260226151106.144735-1-hch@lst.de> <20260226151106.144735-10-hch@lst.de> <20260228071521.GK65277@quark> Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260228071521.GK65277@quark> User-Agent: Mutt/1.5.17 (2007-11-01) On Fri, Feb 27, 2026 at 11:15:21PM -0800, Eric Biggers wrote: > This makes the generic code always be included in xor.ko, even when the > architecture doesn't need it. For example, x86_64 doesn't need it, > since it always selects either the AVX or SSE code. True. OTOH it is tiny. > Have you considered putting the generic code in xor-core.c (or in > headers included by it) before xor_arch.h is included, and putting > __maybe_unused on the xor_block_template structs? Then they'll still be > available for arch_xor_init() to use, but any of them that aren't used > in a particular build will be optimized out as dead code by the > compiler. And earlier version did this, but it's a bit ugly. What I might consider is to require architectures that provide optimized version to opt into any generic one they want to use. This would require extra kconfig symbols, but be a lot cleaner overall.