Re: [PATCH v2] dt-bindings: i2c: ls2x-i2c: Add clocks and clock-frequency properties

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2500 bytes --]

On Fri, May 08, 2026 at 09:29:08AM +0800, Hongliang Wang wrote:
> 
> On 2026/5/8 上午1:29, Conor Dooley wrote:
> > On Thu, May 07, 2026 at 04:10:09PM +0800, Hongliang Wang wrote:
> > > From: wanghongliang <wanghongliang@loongson.cn>
> > > 
> > > clocks property describes the i2c bus reference clock from APB clock.
> > > clock-frequency property describes i2c bus speed.
> > > 
> > > Signed-off-by: wanghongliang <wanghongliang@loongson.cn>
> > > ---
> > >   Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml | 3 +++
> > >   1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml b/Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml
> > > index ee09c6d9c5f0..4bf89bb97e7d 100644
> > > --- a/Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml
> > > +++ b/Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml
> > > @@ -38,10 +38,13 @@ unevaluatedProperties: false
> > >   examples:
> > >     - |
> > >       #include <dt-bindings/interrupt-controller/irq.h>
> > > +    #include <dt-bindings/clock/loongson,ls2k-clk.h>
> > >       i2c0: i2c@1fe21000 {
> > >           compatible = "loongson,ls2k-i2c";
> > >           reg = <0x1fe21000 0x8>;
> > > +        clock-frequency = <100000>;
> > > +        clocks = <&clk LOONGSON2_APB_CLK>;
> > /stuff/linux-dt/Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.example.dtb: i2c@1fe21000 (loongson,ls2k-i2c): Unevaluated properties are not allowed ('clocks' was unexpected)
> > 	from schema $id: http://devicetree.org/schemas/i2c/loongson,ls2x-i2c.yaml
> > 
> > 
> > Please test your patches before sending them.
> The error is becasue there is no clocks property in loongson,ls2x-i2c.yaml.
> The patch is based on the following repository and uses the i2c-host-next
> branch.
> I found the clocks property already exist in loongson,ls2x-i2c.yaml, so I
> didn't
> add it in my patch
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git

Ah, my bad then.

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

> > 
> > Does this device actually have a clock or not?
> Yes,  the clock actually exists.
> > 
> > Cheers,
> > Conor.
> > 
> > >           interrupt-parent = <&extioiic>;
> > >           interrupts = <22 IRQ_TYPE_LEVEL_LOW>;
> > >           #address-cells = <1>;
> > > -- 
> > > 2.47.2
> > > 
> Best regards,
> Hongliang Wang
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]