From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 093244756D8 for ; Tue, 15 Sep 2026 08:27:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.71 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789460878; cv=none; b=O/13z/lbIu6PLROKq9jCIKfF+hxTimlmdr8n0YJOcDOr+h+xkZKBRSvKG1hfCfF3XmPlkxywJZhTr/mQK7qrIAPtb89/DTe5NNVLpOCHlGNY5BQyKK9yBjVFbbjputLXJ2g+cGnl7ga0hhGVBKqgejOU8XxcXucwumFh8as9lIs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789460878; c=relaxed/simple; bh=WLXzasjY0mBK/NrbpJfTCOFtGklzxJ8+ta6QqRZkwNM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=KjReenHfNH14O+492PWx5W3R3RSZ0mhMRzvi9kqAkMbS5SxTCytWr1hzs/Ed2+0SCi1Wkb840/n8jsn55DdlvUGgVhqDH4Y0p4fySrQAoA7FTey+2I6CK8pyUWrL+wV09NsmH+Dh5j9/JaUx0pNTSQRXYKu/X+EdADtJnDMneK4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--morbo.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=kurNkGg/; arc=none smtp.client-ip=209.85.217.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--morbo.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kurNkGg/" Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-7866c4ed349so3749220137.0 for ; Tue, 15 Sep 2026 01:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1789460876; x=1790065676; darn=lists.linux.dev; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=RYxDJLbbwpCoc34IeHntB/eNfLB4EmZZnrz8tORBuFs=; b=kurNkGg/MjFSaTt77iHjCmwDu+tlE43pMBLVDV4NsESnMfJX1wBQXKa87FGW/PnKYq n67hZA2oG3q2V6gAa56+F3j1FhhCTQDmK12HLAzz85S06OE/9CuCa68G1YH+NzMA8Zha EVDHZnTsJNe3JXUVLcD5/sn2eBmV9cUjKHeMklkW2UwpAG3XcEVv/Tx6jVj3uZiY7PPB Ms0uxDj8CSWSGUG9w+AhhpUSh8MiWpTAELtXbceph+JD+10hRqU3446cx98JhXODqNP5 8ANe1arul9p7odlVecWui50d9GC5Oa+MxO6D3FU00nzBi1YzFTkZnzyqs7Lu4tOO3Zkm cAQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789460876; x=1790065676; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RYxDJLbbwpCoc34IeHntB/eNfLB4EmZZnrz8tORBuFs=; b=gVdd/F4bxprbQP7JxkGAQOln4yDYGj55jYXNwhEgoN9xGIXgn6CDalO4N/M4DQcFzc Z0T7FXrBFIFl0Fi2jln7ctuMasi7pYBq/JHxX1kJ7RVWSY3Rt3iPZ13vuKMw1krolvGx 2/nmGXKHI3+jL/OXdTeqvjGz6uSCqtZjV3fp2UnR0ESPn1w1eCTxZlb4/QDEIzwsvUAG zV7o2l2qIr/DyxpCHMmTYYLfyX26eWR3yXX6JUbU1QxTJnmrkb7FpBVQ6gNpq/lHsJZF fYWgEtHl/dnRIEKB0CoCrMFDmhI/iOyx6crNPDDJ4kBV6lNXgYNS6CVD9vju5xqgJV9H DPnQ== X-Forwarded-Encrypted: i=1; AKwUvBwKgToEfF2VXqqaGsb0gMHqvNRfgcNfbSE23Od81Gop2D5Q+wrpLLqWHSF42kJVkeugyI8zkvkxlgo=@lists.linux.dev X-Gm-Message-State: AFuF++lEzEhXy7HLzHvMJK7UbvBJkRpBsL03gJXv1ynq5tqoh6tIVqqL DfwxLQXBhyIWVtjIRQofkaimA5pvBXQ/vPKUgKne8RovZhKD4eoao2vFoz07OVRgUcan+mSsfCH d X-Received: from plas19.prod.google.com ([2002:a17:903:2013:b0:2dd:75f1:13f5]) (user=morbo job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:40c6:b0:2d0:cc92:f7a9 with SMTP id d9443c01a7336-2dd837a6aeemr1077095ad.4.1789460419151; Tue, 15 Sep 2026 01:20:19 -0700 (PDT) Date: Tue, 15 Sep 2026 08:18:45 +0000 In-Reply-To: <20260915081910.4142719-1-morbo@google.com> Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260915081910.4142719-1-morbo@google.com> X-Mailer: git-send-email 2.55.0.1032.g73a4cd73de-goog Message-ID: <20260915081910.4142719-29-morbo@google.com> Subject: [PATCH 28/28] drm/xe/pf: Refactor strlcat() to seq_buf in sched_group_engines_read() From: Bill Wendling To: linux-kernel@vger.kernel.org Cc: Bill Wendling , codemender-patching+linux@google.com, Russell King , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Ian Abbott , H Hartley Sweeten , Tony Luck , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthew Brost , "=?UTF-8?q?Thomas=20Hellstr=C3=B6m?=" , Rodrigo Vivi , Dmitry Torokhov , Matthias Schwarzott , Mauro Carvalho Chehab , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Arend van Spriel , Rob Herring , Saravana Kannan , Krzysztof Kozlowski , Sylwester Nawrocki , Peter Griffin , Alim Akhtar , Linus Walleij , Anil Gurumurthy , Sudarsana Kalluru , "Martin K. Petersen" , Trond Myklebust , Anna Schumaker , Mike Marshall , Martin Brandenburg , Kees Cook , Jiri Pirko , Simon Horman , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Jaroslav Kysela , Takashi Iwai , Andrew Morton , "Mike Rapoport (Microsoft)" , Kanglong Wang , Tiezhu Yang , Qiang Ma , Randy Dunlap , Pengpeng Hou , Ard Biesheuvel , Breno Leitao , Thorsten Blum , Harshit Mogalapalli , Greg Kroah-Hartman , Lyude Paul , Ashutosh Desai , Imre Deak , Dmitry Baryshkov , Johan Hovold , Johannes Berg , Miri Korenblit , Alexander Stein , Cryolitia PukNgae , Jiaming Zhang , Will Porter , Cen Zhang , "=?UTF-8?q?C=C3=A1ssio=20Gabriel?=" , Rong Zhang , Arun Raghavan , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-edac@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-scsi@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, linux-hardening@vger.kernel.org, linux-sound@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Similar to control_read(), sched_group_engines_read() constructs a space-separated list of hardware engine names in a stack buffer using repeated strlcat() calls inside a loop. In preparation for removing the deprecated strlcat() API[1], refactor sched_group_engines_read() to use struct seq_buf and seq_buf_printf(). Link: https://github.com/KSPP/linux/issues/370 [1] Cc: codemender-patching+linux@google.com Assisted-by: Developer:Gemini [editor_update_file, make_kernel_build_single= _file, shell_command_run] Signed-off-by: Bill Wendling --- Cc: Russell King Cc: Huacai Chen Cc: WANG Xuerui Cc: Thomas Bogendoerfer Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: x86@kernel.org Cc: "H. Peter Anvin" Cc: Ian Abbott Cc: H Hartley Sweeten Cc: Tony Luck Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Simona Vetter Cc: Matthew Brost Cc: "Thomas Hellstr=C3=B6m" Cc: Rodrigo Vivi Cc: Dmitry Torokhov Cc: Matthias Schwarzott Cc: Mauro Carvalho Chehab Cc: Tony Nguyen Cc: Przemek Kitszel Cc: Andrew Lunn Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Arend van Spriel Cc: Rob Herring Cc: Saravana Kannan Cc: Krzysztof Kozlowski Cc: Sylwester Nawrocki Cc: Peter Griffin Cc: Alim Akhtar Cc: Linus Walleij Cc: Anil Gurumurthy Cc: Sudarsana Kalluru Cc: "Martin K. Petersen" Cc: Trond Myklebust Cc: Anna Schumaker Cc: Mike Marshall Cc: Martin Brandenburg Cc: Kees Cook Cc: Jiri Pirko Cc: Simon Horman Cc: Chuck Lever Cc: Jeff Layton Cc: NeilBrown Cc: Olga Kornievskaia Cc: Dai Ngo Cc: Tom Talpey Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Bill Wendling Cc: Andrew Morton Cc: "Mike Rapoport (Microsoft)" Cc: Kanglong Wang Cc: Tiezhu Yang Cc: Qiang Ma Cc: Randy Dunlap Cc: Pengpeng Hou Cc: Ard Biesheuvel Cc: Breno Leitao Cc: Thorsten Blum Cc: Harshit Mogalapalli Cc: Greg Kroah-Hartman Cc: Lyude Paul Cc: Ashutosh Desai Cc: Imre Deak Cc: Dmitry Baryshkov Cc: Johan Hovold Cc: Johannes Berg Cc: Miri Korenblit Cc: Alexander Stein Cc: Cryolitia PukNgae Cc: Jiaming Zhang Cc: Will Porter Cc: Cen Zhang Cc: "C=C3=A1ssio Gabriel" Cc: Rong Zhang Cc: Arun Raghavan Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: loongarch@lists.linux.dev Cc: linux-mips@vger.kernel.org Cc: linux-parisc@vger.kernel.org Cc: linux-edac@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: intel-xe@lists.freedesktop.org Cc: linux-input@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org Cc: linux-wireless@vger.kernel.org Cc: brcm80211@lists.linux.dev Cc: brcm80211-dev-list.pdl@broadcom.com Cc: devicetree@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-gpio@vger.kernel.org Cc: linux-scsi@vger.kernel.org Cc: linux-nfs@vger.kernel.org Cc: devel@lists.orangefs.org Cc: linux-hardening@vger.kernel.org Cc: linux-sound@vger.kernel.org --- drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c b/drivers/gpu/drm/= xe/xe_gt_sriov_pf_debugfs.c index 5db7fc067c4d..548a50f74422 100644 --- a/drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c +++ b/drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c @@ -377,8 +377,10 @@ static ssize_t sched_group_engines_read(struct file *f= ile, char __user *buf, struct xe_hw_engine *hwe; enum xe_hw_engine_id id; char engines[128]; + struct seq_buf s; + const char *s_str; =20 - engines[0] =3D '\0'; + seq_buf_init(&s, engines, sizeof(engines)); =20 if (group < num_groups) { for_each_hw_engine(hwe, gt, id) { @@ -386,15 +388,14 @@ static ssize_t sched_group_engines_read(struct file *= file, char __user *buf, u16 guc_logical_instance =3D xe_hwe_guc_logical_instance(hwe); u32 mask =3D groups[group].engines[guc_class]; =20 - if (mask & BIT(guc_logical_instance)) { - strlcat(engines, hwe->name, sizeof(engines)); - strlcat(engines, " ", sizeof(engines)); - } + if (mask & BIT(guc_logical_instance)) + seq_buf_printf(&s, "%s ", hwe->name); } - strlcat(engines, "\n", sizeof(engines)); + seq_buf_puts(&s, "\n"); } =20 - return simple_read_from_buffer(buf, count, ppos, engines, strlen(engines)= ); + s_str =3D seq_buf_str(&s); + return simple_read_from_buffer(buf, count, ppos, s_str, strlen(s_str)); } =20 static const struct file_operations sched_group_engines_fops =3D { --=20 2.55.0.1032.g73a4cd73de-goog