From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C38B1FB1 for ; Tue, 15 Sep 2026 08:19:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789460413; cv=none; b=sbKwb3nwbrjJaWc79Xno3L8MFT8izzfnnOsze4I3Q/OQGssYEF2U6FZuR6kjvo1ITnQFtG284OklU9lmX2n4DYGqJa6bEwdeajjI5N2dUm6zYxHHVUYdm+f3gqTHrPluNncWj9sOg+Zw8N9DHDCH+Qy/G07B+lm6lwJE2ZGongk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789460413; c=relaxed/simple; bh=IWKQ4COf9lXb2aWQAfm5Y+7WKwIMngPQWy99kbv9mag=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=dBT2CNGhVf5j6MO7oT3DkzKoYv/nUL+/HTDy+oj73SGooYdjq/iZHfPOwGgWAVgAzCZKoBu3BOrV0ws4Wbi7wjaZ6cz9rFa2uIGja4KQrBwsBIrfc5aKJHh8szJKb25YIBzx4gaJaOYS0tfv222q9+zPoWl2rnprWh4KzETESyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--morbo.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ZwXFixqb; arc=none smtp.client-ip=209.85.214.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--morbo.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ZwXFixqb" Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2d6f75c1219so88122905ad.3 for ; Tue, 15 Sep 2026 01:19:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1789460396; x=1790065196; darn=lists.linux.dev; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=su2v7itwh4re1nYnX3JAIlBIidMghtZfDu1F4zgeEKU=; b=ZwXFixqbZPYgHXs2Z+Qc1CDd9Xhf1IQlLVjR7stZzPL0pzgZ8BE7aGA9iERoELI4oy 6loTN++RXal/RnG6UyMR2csz65kULM68an3o+7ZlQ61MD/BamAt057SYEv19eGjJ8BlL vc8Tx0eVxwx//0ZW0eyzpl9dsMIeSpWKdmod1AXYwWLG0EWmHpt+x+suEZTA3TaudkeQ Oiz95FhUPM2uGtohyGE/cy4oAw97tDaZSzTfvI6MixTSNDQv+nf9maqTLccRa+ZejmBb +jUJdya8swypDRynFuvH6D12oWuxLmmQPQVVLnsZVIn0UMoW5nhPQwFIFhM8ORkj+j5G uGrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789460396; x=1790065196; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=su2v7itwh4re1nYnX3JAIlBIidMghtZfDu1F4zgeEKU=; b=Q22OrSGKzdXwx04dwtkiDdVBZ3GrHM0MA3JuqWc62UQAQ5Z0dQgq8jFUSFvpUWw7GY Ew9fJ4VQouv3MquL2IJ7TCQesbzRrrLxHurpx3oh/StvLPI1AWTPA0et2mdhRZECN41F U8DbtwGfYMMAyIY29ePdYqW6DoAX57BqefiWLUKLApiDbUSokpclhjCFWuKfxuvfeYo3 UqG+AAjOzWCBlvuQWrDBSitgecI4SOEVqpYg5GbUxFlB9P3S9VKbiY/uml4rlvAbD2J5 86JXukt8LctLX2yLvMvwZ5jnJrFcztOB6+G6ggum+RXWdpc9b3guvai7O+kEcrO24+Oj UDQQ== X-Forwarded-Encrypted: i=1; AKwUvBzxiYuKK6svW+7oOw7JbhhPQedN9btzeB55r7xld1iUmQ2r7b6t7C1omvsU3H8mtTeN74kAFw8OkEU=@lists.linux.dev X-Gm-Message-State: AFuF++mJ2ypgDZ4h4Pjt0DFxGHnPP3uW7m2v7Dlv94lk02qFWU1TYX59 hiyR505oe1l3pG9/hCUQMAOfOGCBMnaoW1RLrr+TAnj5yh5yEkDGYOvragTJAl0cwHIGb39XuKc I X-Received: from plpo14.prod.google.com ([2002:a17:903:3e0e:b0:2cc:e407:8fef]) (user=morbo job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:3508:b0:2dd:8b2:6e64 with SMTP id d9443c01a7336-2dd83851cd5mr695675ad.12.1789460395589; Tue, 15 Sep 2026 01:19:55 -0700 (PDT) Date: Tue, 15 Sep 2026 08:18:25 +0000 In-Reply-To: <20260915081910.4142719-1-morbo@google.com> Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260915081910.4142719-1-morbo@google.com> X-Mailer: git-send-email 2.55.0.1032.g73a4cd73de-goog Message-ID: <20260915081910.4142719-9-morbo@google.com> Subject: [PATCH 08/28] devlink: Refactor strlcat() to seq_buf in __devlink_compat_running_version() From: Bill Wendling To: linux-kernel@vger.kernel.org Cc: Bill Wendling , codemender-patching+linux@google.com, Russell King , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Ian Abbott , H Hartley Sweeten , Tony Luck , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthew Brost , "=?UTF-8?q?Thomas=20Hellstr=C3=B6m?=" , Rodrigo Vivi , Dmitry Torokhov , Matthias Schwarzott , Mauro Carvalho Chehab , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Arend van Spriel , Rob Herring , Saravana Kannan , Krzysztof Kozlowski , Sylwester Nawrocki , Peter Griffin , Alim Akhtar , Linus Walleij , Anil Gurumurthy , Sudarsana Kalluru , "Martin K. Petersen" , Trond Myklebust , Anna Schumaker , Mike Marshall , Martin Brandenburg , Kees Cook , Jiri Pirko , Simon Horman , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Jaroslav Kysela , Takashi Iwai , Andrew Morton , "Mike Rapoport (Microsoft)" , Kanglong Wang , Tiezhu Yang , Qiang Ma , Randy Dunlap , Pengpeng Hou , Ard Biesheuvel , Breno Leitao , Thorsten Blum , Harshit Mogalapalli , Greg Kroah-Hartman , Lyude Paul , Ashutosh Desai , Imre Deak , Dmitry Baryshkov , Johan Hovold , Johannes Berg , Miri Korenblit , Alexander Stein , Cryolitia PukNgae , Jiaming Zhang , Will Porter , Cen Zhang , "=?UTF-8?q?C=C3=A1ssio=20Gabriel?=" , Rong Zhang , Arun Raghavan , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-edac@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-scsi@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, linux-hardening@vger.kernel.org, linux-sound@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable __devlink_compat_running_version() appends running firmware version strings and spaces to "buf" inside nested netlink attribute loops using strlcat(), rescanning "buf" on every iteration. In preparation for removing the deprecated strlcat() API[1], use struct seq_buf anchored at the current length of "buf" and append each version entry with seq_buf_printf(). Link: https://github.com/KSPP/linux/issues/370 [1] Cc: codemender-patching+linux@google.com Assisted-by: CoPilot:v1 [editor_update_file, shell_command_run] Signed-off-by: Bill Wendling --- Cc: Russell King Cc: Huacai Chen Cc: WANG Xuerui Cc: Thomas Bogendoerfer Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: x86@kernel.org Cc: "H. Peter Anvin" Cc: Ian Abbott Cc: H Hartley Sweeten Cc: Tony Luck Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Simona Vetter Cc: Matthew Brost Cc: "Thomas Hellstr=C3=B6m" Cc: Rodrigo Vivi Cc: Dmitry Torokhov Cc: Matthias Schwarzott Cc: Mauro Carvalho Chehab Cc: Tony Nguyen Cc: Przemek Kitszel Cc: Andrew Lunn Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Arend van Spriel Cc: Rob Herring Cc: Saravana Kannan Cc: Krzysztof Kozlowski Cc: Sylwester Nawrocki Cc: Peter Griffin Cc: Alim Akhtar Cc: Linus Walleij Cc: Anil Gurumurthy Cc: Sudarsana Kalluru Cc: "Martin K. Petersen" Cc: Trond Myklebust Cc: Anna Schumaker Cc: Mike Marshall Cc: Martin Brandenburg Cc: Kees Cook Cc: Jiri Pirko Cc: Simon Horman Cc: Chuck Lever Cc: Jeff Layton Cc: NeilBrown Cc: Olga Kornievskaia Cc: Dai Ngo Cc: Tom Talpey Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Bill Wendling Cc: Andrew Morton Cc: "Mike Rapoport (Microsoft)" Cc: Kanglong Wang Cc: Tiezhu Yang Cc: Qiang Ma Cc: Randy Dunlap Cc: Pengpeng Hou Cc: Ard Biesheuvel Cc: Breno Leitao Cc: Thorsten Blum Cc: Harshit Mogalapalli Cc: Greg Kroah-Hartman Cc: Lyude Paul Cc: Ashutosh Desai Cc: Imre Deak Cc: Dmitry Baryshkov Cc: Johan Hovold Cc: Johannes Berg Cc: Miri Korenblit Cc: Alexander Stein Cc: Cryolitia PukNgae Cc: Jiaming Zhang Cc: Will Porter Cc: Cen Zhang Cc: "C=C3=A1ssio Gabriel" Cc: Rong Zhang Cc: Arun Raghavan Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: loongarch@lists.linux.dev Cc: linux-mips@vger.kernel.org Cc: linux-parisc@vger.kernel.org Cc: linux-edac@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: intel-xe@lists.freedesktop.org Cc: linux-input@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org Cc: linux-wireless@vger.kernel.org Cc: brcm80211@lists.linux.dev Cc: brcm80211-dev-list.pdl@broadcom.com Cc: devicetree@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-gpio@vger.kernel.org Cc: linux-scsi@vger.kernel.org Cc: linux-nfs@vger.kernel.org Cc: devel@lists.orangefs.org Cc: linux-hardening@vger.kernel.org Cc: linux-sound@vger.kernel.org --- net/devlink/dev.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net/devlink/dev.c b/net/devlink/dev.c index 55959b0ff5ab..987b071345c4 100644 --- a/net/devlink/dev.c +++ b/net/devlink/dev.c @@ -5,6 +5,7 @@ */ =20 #include +#include #include #include #include "devl_internal.h" @@ -1190,6 +1191,7 @@ static void __devlink_compat_running_version(struct d= evlink *devlink, { struct devlink_info_req req =3D {}; const struct nlattr *nlattr; + struct seq_buf s; struct sk_buff *msg; int rem, err; =20 @@ -1202,6 +1204,9 @@ static void __devlink_compat_running_version(struct d= evlink *devlink, if (err) goto free_msg; =20 + seq_buf_init(&s, buf, len); + s.len =3D strnlen(buf, len); + nla_for_each_attr_type(nlattr, DEVLINK_ATTR_INFO_VERSION_RUNNING, (void *)msg->data, msg->len, rem) { const struct nlattr *kv; @@ -1209,8 +1214,7 @@ static void __devlink_compat_running_version(struct d= evlink *devlink, =20 nla_for_each_nested_type(kv, DEVLINK_ATTR_INFO_VERSION_VALUE, nlattr, rem_kv) { - strlcat(buf, nla_data(kv), len); - strlcat(buf, " ", len); + seq_buf_printf(&s, "%s ", (const char *)nla_data(kv)); } } free_msg: --=20 2.55.0.1032.g73a4cd73de-goog