Re: [PATCH 2/2] clk: loongson2: add support for ls2k1000 compatible

Krzysztof Kozlowski
2026-03-22T08:55:37Z

On 22/03/2026 09:03, wjjsn wrote:
> From: wjjsn <2858482031@qq.com>
>
> Add driver support for the "loongson,ls2k1000-clk" compatible
> and update the Loongson-2K1000 DTS to use it while retaining
> "loongson,ls2k-clk" as a fallback.
>
> Signed-off-by: wjjsn <wjjsn@qq.com>
> ---
> arch/loongarch/boot/dts/loongson-2k1000.dtsi | 2 +-

This is not driver.

> drivers/clk/clk-loongson2.c | 1 +

Why are you combining these? Please read submitting patches in DT and
maintainer-soc profile to understand. Then read submitting patches and
split your code in logical chunks.

> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/boot/dts/loongson-2k1000.dtsi b/arch/loongarch/boot/dts/loongson-2k1000.dtsi
> index ab6a55937e9e..61cdae438cb0 100644
> --- a/arch/loongarch/boot/dts/loongson-2k1000.dtsi
> +++ b/arch/loongarch/boot/dts/loongson-2k1000.dtsi
> @@ -156,7 +156,7 @@ pctrl: pinctrl@1fe00420 {
> };
>
> clk: clock-controller@1fe00480 {
> - compatible = "loongson,ls2k-clk";
> + compatible = "loongson,ls2k1000-clk", "loongson,ls2k-clk";

You never tested your code. You have warning here.

> reg = <0x0 0x1fe00480 0x0 0x58>;
> #clock-cells = <1>;
> clocks = <&ref_100m>;
> diff --git a/drivers/clk/clk-loongson2.c b/drivers/clk/clk-loongson2.c
> index 9c4c6c99db3e..48d00578b26f 100644
> --- a/drivers/clk/clk-loongson2.c
> +++ b/drivers/clk/clk-loongson2.c
> @@ -441,6 +441,7 @@ static const struct of_device_id loongson2_clk_match_table[] = {
> { .compatible = "loongson,ls2k0300-clk", .data = &ls2k0300_clks },
> { .compatible = "loongson,ls2k0500-clk", .data = &ls2k0500_clks },
> { .compatible = "loongson,ls2k-clk", .data = &ls2k1000_clks },
> + { .compatible = "loongson,ls2k1000-clk", .data = &ls2k1000_clks },

What is the point of this change? It's redundant.

> { .compatible = "loongson,ls2k2000-clk", .data = &ls2k2000_clks },
> { }
> };

Best regards,
Krzysztof