From: "Kumar Kartikeya Dwivedi" <memxor@gmail.com>
To: "Tiezhu Yang" <yangtiezhu@loongson.cn>, <bpf@vger.kernel.org>
Cc: "Huacai Chen" <chenhuacai@kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Eduard Zingerman" <eddyz87@gmail.com>,
"Emil Tsalapatis" <emil@etsalapatis.com>,
"Ihor Solodrai" <ihor.solodrai@linux.dev>, <kkd@meta.com>,
<kernel-team@meta.com>, <loongarch@lists.linux.dev>,
"Hengqi Chen" <hengqi.chen@gmail.com>
Subject: Re: [PATCH bpf-next v1 07/14] bpf, loongarch: Fix stack arguments for indirect trampolines
Date: Sun, 30 Aug 2026 03:46:46 +0200 [thread overview]
Message-ID: <DL1WDYI57AAF.Q8T6RDYE04J2@gmail.com> (raw)
In-Reply-To: <2bc45d20-d08f-e5c1-9da3-699d22959f98@loongson.cn>
On Fri Aug 28, 2026 at 10:19 AM CEST, Tiezhu Yang wrote:
> On 2026/8/28 下午12:55, Kumar Kartikeya Dwivedi wrote:
>> On Fri Aug 28, 2026 at 6:33 AM CEST, Tiezhu Yang wrote:
>
> ...
>
>>> With this patch:
>>>
>>> $ sudo ./test_progs -t struct_ops_trampoline
>>> #471 struct_ops_trampoline:OK
>>> Summary: 1/0 PASSED, 0 SKIPPED, 0 FAILED
>>>
>>> Tested-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>>
>> Thanks a lot for the test. Please also take a look at the argument rebase
>> patches once you folks have more cycles. Will definitely need your help and
>> reviews since they are mostly vibe coded.
>
> Hi Kumar,
>
> I have sent a standalone prerequisite fix for the pre-existing
> issue:
>
> LoongArch: BPF: Fix off-by-one error for insn_is_cast_user
> https://lore.kernel.org/loongarch/20260828075100.24776-1-yangtiezhu@loongson.cn/
>
> IMO, when you respin, please rebase your patches 07, 08, and 09
> on top of this fix for your v2 series.
>
> Additionally, please send the v2 as a standalone series to the
> loongarch mailing list loongarch@lists.linux.dev and the reviewer
> Hengqi Chen <hengqi.chen@gmail.com> too, as the LoongArch BPF JIT
> patches are typically routed through the loongarch-next tree.
>
> https://lore.kernel.org/loongarch/CAAhV-H55YcyXRewC+0YzTHXb1jab0GkAV13EF9nFbTx=UkX4ww@mail.gmail.com/
>
Ok, I will send v2 without loongarch changes and then split out and send them
separately later on (or let me know if you'd like to commandeer them, I'm happy
to do it either way).
Thanks
prev parent reply other threads:[~2026-08-30 1:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260821233516.3426127-1-memxor@gmail.com>
[not found] ` <20260821233516.3426127-8-memxor@gmail.com>
2026-08-28 4:33 ` [PATCH bpf-next v1 07/14] bpf, loongarch: Fix stack arguments for indirect trampolines Tiezhu Yang
2026-08-28 4:55 ` Kumar Kartikeya Dwivedi
2026-08-28 8:19 ` Tiezhu Yang
2026-08-30 1:46 ` Kumar Kartikeya Dwivedi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DL1WDYI57AAF.Q8T6RDYE04J2@gmail.com \
--to=memxor@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chenhuacai@kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=hengqi.chen@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=kernel-team@meta.com \
--cc=kkd@meta.com \
--cc=loongarch@lists.linux.dev \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox