From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 863F92B545 for ; Tue, 22 Aug 2023 17:50:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1551C433C8; Tue, 22 Aug 2023 17:50:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692726647; bh=8wyz7tIdSjCDpv2YyMio1rNav9NpU1p5w5n1ziqSooY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P39XmaDlgE+FbqLMhrQmh6S8v23NLkUiZmm10OQP9n+5Z/nPhLbCLTPpbO//+jaBa jetUvMq8WWFhmhSefgkrIoHQeuWMqomxZ6Qjn3x7mMAB8XmTOO6gZcT6yqROZXOAmS 6jBiduYtKqlw63lN/Ck4KpXEyXXsTN4/xZRVxOclXK2fsXxnSI4STYVO0PEf3zoWOQ HtOOCw1Ls9vXhs9VxbWUJOZmgsAffVsFpC1kldUblLFWcnN1dU4hXvYHBf6xYit/4f O3mIw9jhL9waAecNvUbQCohKNehrv0OzQFoctTMZnN+/bnV4Gxlmqi7uk3thCG+30G dnzIrG5GPh0hw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id B5EE640722; Tue, 22 Aug 2023 14:50:43 -0300 (-03) Date: Tue, 22 Aug 2023 14:50:43 -0300 From: Arnaldo Carvalho de Melo To: Yanteng Si Cc: mingo@redhat.com, peterz@infradead.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, irogers@google.com, adrian.hunter@intel.com, chenhuacai@kernel.org, linux-perf-users@vger.kernel.org, loongson-kernel@lists.loongnix.cn, loongarch@lists.linux.dev Subject: Re: [PATCH v1 2/2] perf/tools: Allow to use cpuinfo on loongarch Message-ID: References: Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Em Tue, Aug 22, 2023 at 05:32:07PM +0800, Yanteng Si escreveu: > Define these macros so that the CPU name can be displayed > when running perf report and perf timechart. > > Signed-off-by: Yanteng Si > --- > tools/perf/util/header.c | 2 ++ > tools/perf/util/svghelper.c | 7 ++++++- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c > index 52fbf526fe74..c6e19192bd28 100644 > --- a/tools/perf/util/header.c > +++ b/tools/perf/util/header.c > @@ -456,6 +456,8 @@ static int write_cpudesc(struct feat_fd *ff, > #define CPUINFO_PROC { "Processor", } > #elif defined(__xtensa__) > #define CPUINFO_PROC { "core ID", } > +#elif defined(__loongarch__) > +#define CPUINFO_PROC { "Model Name", } > #else > #define CPUINFO_PROC { "model name", } > #endif > diff --git a/tools/perf/util/svghelper.c b/tools/perf/util/svghelper.c > index 5c62d3118c41..0259715ad6a6 100644 > --- a/tools/perf/util/svghelper.c > +++ b/tools/perf/util/svghelper.c > @@ -322,6 +322,11 @@ void svg_waiting(int Yslot, int cpu, u64 start, u64 end, const char *backtrace) > > static char *cpu_model(void) > { > +#if defined(__loongarch__) > +#define CPU_TYPE "Model Name" > +#else > +#define CPU_TYPE "model name" > +#endif > static char cpu_m[255]; > char buf[256]; > FILE *file; > @@ -331,7 +336,7 @@ static char *cpu_model(void) > file = fopen("/proc/cpuinfo", "r"); > if (file) { > while (fgets(buf, 255, file)) { > - if (strstr(buf, "model name")) { > + if (strstr(buf, CPU_TYPE)) { Isn't it better to just switch to strcasestr()? - Arnaldo > strlcpy(cpu_m, &buf[13], 255); > break; > } > -- > 2.31.4 > -- - Arnaldo