From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 187B12B577 for ; Tue, 22 Aug 2023 18:02:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABEB8C433C7; Tue, 22 Aug 2023 18:02:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692727377; bh=4jEKuSPyHW8FpFNbKwoLd9oFXQQVr1W5mx8Bz9JrrMo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X6nh4bccoEfgSFZiQJbGNEGjd+WM8uY3l/rxeARYeDhVMAdEJsB7VBdhzC0Fcr7Qs TYjuyVFcx1lE3v5otam1UQcAqxEYs2IgnWI58VE24eQarFPz4M1rVZWgg9BuGoMUZ5 gRMSRUtHq/GnN3LIGbwoz+F3Al9P5h4+Yt0zEhTg8VgCrD/c06mG3I1T6z7BrpdzM3 KMacDCdcyWaluWLBlcN2tNDcIPYdvxYo8oo4bcW4bsBDq6da9f25TffDApXqwvnQVA ePE7QX4jbDUwR0lIHr5ybA0eMY3yMpVr7N9rgHx7je3bLSEJMQ9+bUycApCmHoIwvj 2kqPa03giHN3A== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id D72BE40722; Tue, 22 Aug 2023 15:02:54 -0300 (-03) Date: Tue, 22 Aug 2023 15:02:54 -0300 From: Arnaldo Carvalho de Melo To: Yanteng Si Cc: mingo@redhat.com, peterz@infradead.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, irogers@google.com, adrian.hunter@intel.com, chenhuacai@kernel.org, linux-perf-users@vger.kernel.org, loongson-kernel@lists.loongnix.cn, loongarch@lists.linux.dev Subject: Re: [PATCH v1 1/2] perf/trace: Fix mmap_flags for archs use generic mman.h Message-ID: References: <03ddc1c0e01518df63aac88e561cd0ec3c1e0028.1692694595.git.siyanteng@loongson.cn> Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <03ddc1c0e01518df63aac88e561cd0ec3c1e0028.1692694595.git.siyanteng@loongson.cn> X-Url: http://acmel.wordpress.com Em Tue, Aug 22, 2023 at 05:32:06PM +0800, Yanteng Si escreveu: > Silence this warning: > > grep: /root/linux-next/tools/arch/xxxxx/include/uapi/asm//mman.h: > No such file or directory > Signed-off-by: Yanteng Si > --- > tools/perf/trace/beauty/mmap_flags.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/trace/beauty/mmap_flags.sh b/tools/perf/trace/beauty/mmap_flags.sh > index 3022597c8c17..d035b29fc5ec 100755 > --- a/tools/perf/trace/beauty/mmap_flags.sh > +++ b/tools/perf/trace/beauty/mmap_flags.sh > @@ -19,7 +19,7 @@ arch_mman=${arch_header_dir}/mman.h > > printf "static const char *mmap_flags[] = {\n" > regex='^[[:space:]]*#[[:space:]]*define[[:space:]]+MAP_([[:alnum:]_]+)[[:space:]]+(0x[[:xdigit:]]+)[[:space:]]*.*' > -grep -E -q $regex ${arch_mman} && \ > +([ -f ${arch_mman} ] && grep -E -q $regex ${arch_mman}) && \ > (grep -E $regex ${arch_mman} | \ > sed -r "s/$regex/\2 \1 \1 \1 \2/g" | \ > xargs printf "\t[ilog2(%s) + 1] = \"%s\",\n#ifndef MAP_%s\n#define MAP_%s %s\n#endif\n") Humm, wouldn't this be simpler without that extra subshell? Like this: diff --git a/tools/perf/trace/beauty/mmap_flags.sh b/tools/perf/trace/beauty/mmap_flags.sh index 3022597c8c178f21..0ac1886a83b5aceb 100755 --- a/tools/perf/trace/beauty/mmap_flags.sh +++ b/tools/perf/trace/beauty/mmap_flags.sh @@ -19,6 +19,7 @@ arch_mman=${arch_header_dir}/mman.h printf "static const char *mmap_flags[] = {\n" regex='^[[:space:]]*#[[:space:]]*define[[:space:]]+MAP_([[:alnum:]_]+)[[:space:]]+(0x[[:xdigit:]]+)[[:space:]]*.*' +test -f ${arch_mman} && \ grep -E -q $regex ${arch_mman} && \ (grep -E $regex ${arch_mman} | \ sed -r "s/$regex/\2 \1 \1 \1 \2/g" | \