From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDCCC156C7 for ; Mon, 13 Nov 2023 08:00:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="1ra6n9fv" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZIUo6SitpM+vYIkRKxMDsTWGye+BOau+Sdl+Rn/5gvc=; b=1ra6n9fv04zKcULX0AWUO9GzA/ GpGAL8Jbl8giKBKycwRVVUW9hmYaNT2a8BcpyTaoD9qhz8Q404iRE6t+uJ3Zble869e2Rf/BjOOr7 DptWz9p9DZQClZG+IdD27GCb8Y6NRn9vJ9oiP7ZFt+3sBDc6c1MIdgB2DuXM6SQa6MaBgxg5XFxCX y9OWsNsBQotBj3bvpgF59e+ItDN4y576At2fVXf+8VUinUr6c47UW8eUkQgOBX6Mu61EUJlRXkZNs dPmUA6GU4Neh5R7kEw4gh2iV9kGepqciieG4SCtP6unGOd8lZrYFQCreT3yMDFP5kgaWnhippJHkx t/XlG99Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:49754) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1r2Rrr-0006Lc-08; Mon, 13 Nov 2023 08:00:24 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1r2Rrn-0004Mt-JQ; Mon, 13 Nov 2023 08:00:19 +0000 Date: Mon, 13 Nov 2023 08:00:19 +0000 From: "Russell King (Oracle)" To: Gavin Shan Cc: linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, kvmarm@lists.linux.dev, x86@kernel.org, linux-csky@vger.kernel.org, linux-doc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, Salil Mehta , Jean-Philippe Brucker , jianyong.wu@arm.com, justin.he@arm.com, James Morse , Greg Kroah-Hartman , "Rafael J. Wysocki" Subject: Re: [PATCH RFC 10/22] drivers: base: Move cpu_dev_init() after node_dev_init() Message-ID: References: <095c2d24-735b-4ce2-ba2e-9ec2164f2237@redhat.com> Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <095c2d24-735b-4ce2-ba2e-9ec2164f2237@redhat.com> Sender: Russell King (Oracle) On Mon, Nov 13, 2023 at 10:58:46AM +1000, Gavin Shan wrote: > > > On 11/7/23 20:30, Russell King (Oracle) wrote: > > From: James Morse > > > > NUMA systems require the node descriptions to be ready before CPUs are > > registered. This is so that the node symlinks can be created in sysfs. > > > > Currently no NUMA platform uses GENERIC_CPU_DEVICES, meaning that CPUs > > are registered by arch code, instead of cpu_dev_init(). > > > > Move cpu_dev_init() after node_dev_init() so that NUMA architectures > > can use GENERIC_CPU_DEVICES. > > > > Signed-off-by: James Morse > > Signed-off-by: Russell King (Oracle) > > --- > > Note: Jonathan's comment still needs addressing - see > > https://lore.kernel.org/r/20230914121612.00006ac7@Huawei.com > > --- > > drivers/base/init.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > With Jonathan's comments addressed: That needs James' input, which is why I made the note on the patch. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!