From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E942144D35 for ; Wed, 4 Sep 2024 19:07:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725476839; cv=none; b=sXm7MDXmXJMSWraSnKDYG3h+6CFHVgVY43zXPuavzs9EG8zQ3PfRUi9joGAwOivqAotoWki1HvA3BqFlxaW5KdQfnbNRq4fO7f3ceWYq/bmOgckygQWue27kiBJLKr6sT484bUsCmN/cBk3PPdyekrLtEOGpJU49tjotDGPtMZ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725476839; c=relaxed/simple; bh=hLtrV9fo2ENFsppI3EM5//2a1v6xLdR6UciGmLp3E0Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nAjn+6z914rrce6MLO3Xq+T91w5t54fccLBHV/Y5CAD/A9KBTQAe2vnZoYb695i1PSfFF4Rdvh3MoBUsqRU5skF+Hz9ueb2FIk9GQVFn+HgDqB4lxAd+t+5Urj/245FUqNurrc0HxWPRTth71EBoonpIlVsQ1h0WNgZnTidXlu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=p64KqztV; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="p64KqztV" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-7cd835872ceso4867097a12.3 for ; Wed, 04 Sep 2024 12:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1725476837; x=1726081637; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o2U7wgEbLS4i4a8ingcWCBDQrhNmwXrz+ffgx64j+qE=; b=p64KqztVlAkpR1fN1KT6U8rBSAzi/xuVBzrmZv8IsLMnMu182NhlFQKT2RbonE/0Sa 1xdg7YBtQp1g0sYgPR1ji99m48kAtRZZAXyIkvlM4iF5JXAE1OkwI8knfUI4rThFAf/D 2S8uoZDCKvL2pn+JgW1CY+QDe+yGh0bp9wvleMhmOInBWS+lH8T2Edb0aIWkvxBnUsyX yqeDeuTjhhiFVUErRoUm9xuhBBmWPhXTCwxdQEaGXr5V3RdmmjoinqKJy1Q37/88pQpF vkzFnHxCGHK3CN+KnxZM0WxbCytRvSRf8p4XJmT6eeKH7tTIgAWWPeEcxlNkbIxO9hZ7 knfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725476837; x=1726081637; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o2U7wgEbLS4i4a8ingcWCBDQrhNmwXrz+ffgx64j+qE=; b=g2629cSVPEDE3BUR6VQpjnD7Iyrqrl5JTlMqHD16OxlAWtvQDbwGMTIoxwp12YC2jf 5U2SVw7ekWyd/RhfQjQMHtc1Ai9hMBrgFCBVAfg5UYfi8cm7HdreTxZcEQwIiZ8UWul/ HJkrT+5aqZBaKEL1iY4/bE7cohcscRgRDK5UL3qutCPVyD7Fz42Hcs+KrLJGJJaItQsD tW35W2PifnmyPjnrOohLceKhTvga5EEBvy1Gq2+fKX79x64HqPF/PVeY6cG4um363vmN smGLbcO59yKt6F/qLHalzhSazaCGX8qFghjHePFvg8kBWbpb6it0dqfvGxton2bWV0Ux XMFA== X-Forwarded-Encrypted: i=1; AJvYcCXBXP0637N/9Dg3WXVzjL3dptZa5uzK3BlQ4FqleFgs/avsxp0OYT+6LJg0ERNzC7lFhu2jfHJ+uHU=@lists.linux.dev X-Gm-Message-State: AOJu0Yz/ddRHJzrcVfgI9CHCnOLJU7gjG7/cb6VH0zSCl+4BoGmKDkI8 Gb8BlZvLocFpbt+BrX94g/i9yVxc/Uy/WFDYFz7OAQzAgsP/Vz348jFHw96xCCI= X-Google-Smtp-Source: AGHT+IGRXMFw8eODDeHuSZGixob1QmbWy894YR3dac/q8kTYt2afjYPzXJiDq5qdDnRm4AHLgT4d4Q== X-Received: by 2002:a17:90b:300e:b0:2d8:27c3:87d7 with SMTP id 98e67ed59e1d1-2d893284ebdmr13545892a91.8.1725476836620; Wed, 04 Sep 2024 12:07:16 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2da53740084sm4858056a91.32.2024.09.04.12.07.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2024 12:07:16 -0700 (PDT) Date: Wed, 4 Sep 2024 12:07:12 -0700 From: Deepak Gupta To: Mark Brown Cc: "Liam R. Howlett" , Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Guo Ren , Huacai Chen , WANG Xuerui , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Chris Zankel , Max Filippov , Andrew Morton , Vlastimil Babka , Lorenzo Stoakes , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-csky@vger.kernel.org, loongarch@lists.linux.dev, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, Rick Edgecombe Subject: Re: [PATCH 3/3] mm: Care about shadow stack guard gap when getting an unmapped area Message-ID: References: <20240902-mm-generic-shadow-stack-guard-v1-0-9acda38b3dd3@kernel.org> <20240902-mm-generic-shadow-stack-guard-v1-3-9acda38b3dd3@kernel.org> Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Tue, Sep 03, 2024 at 08:57:20PM +0100, Mark Brown wrote: >On Tue, Sep 03, 2024 at 03:41:49PM -0400, Liam R. Howlett wrote: >> * Mark Brown [240902 15:09]: > >> > +static inline unsigned long stack_guard_placement(vm_flags_t vm_flags) >> > +{ >> > + if (vm_flags & VM_SHADOW_STACK) >> > + return PAGE_SIZE; > >> Is PAGE_SIZE is enough? > >It's what x86 currently uses so it'll be no worse off if it gets moved >to the generic code (there's a comment in the arch code explaing what's >needed there) and it's enough for arm64, we only do single record >pushes/pops or (optionally) writes to unconstrained addresses. It's enough for RISC-V too.