From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61E4B1C5D5E; Fri, 9 Jan 2026 00:30:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767918601; cv=none; b=nQNjDRBJKUpXJSD6i+FO+MCGy4jYF2dxWqa0EcHmSGiWI7iAxwwHiqFtICewqxqzHYM5vgTKcWAUOuBrh52D6SO9zg0XpBTpJ5xtR/dTXcIjMbY/j72fuHTxwX3QpFcct61Rsf6ECJvv1Leka8Lk13LcILxVMH9+5SIGlJZfYvQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767918601; c=relaxed/simple; bh=mX5XbuFq3oY1fgctrRQBbLXQxLXqk+y8wzPmf6LEIxk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=du46/D4R0v1LowpHjQMSc+FsOEm/71FVDS3LgaFhkV9BxCef2DLhzNVxJvCHRM6K+boG27/GV7xSw2yWbRVJf+Md10370CjO0xMUjmgFvZX1vN3i+sBVU/JWLEX8vbTm98pdavi4G4Qtfw12gpudYEV7QUx6kEP1mqjibOWB3Lc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=CtWgBhSf; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="CtWgBhSf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1767918601; x=1799454601; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=mX5XbuFq3oY1fgctrRQBbLXQxLXqk+y8wzPmf6LEIxk=; b=CtWgBhSft7qKOIpKv4EWtzblbtp+5ef4vZOqBo6fPRpLTQ8QPlzcFGFx GbCHJIpaGrR/EzCq3ypJ1u4kcgZmwm7r2wisNnrBjfIULb/32JGUxfuq8 6MG17ViCUoMkzTcOieTh5uuOy86k/AlhyAK4jdDr9hFi9g9ZG+QLJZ7j5 uwtVdcc0DY0gFH6tucsLiHxs3QkI7VgtAA4iQRch8bwz8AAOE7ovj+9lu gZXOqqXHDapC+L8L40hWlYSWLx4ESHczBEiaeDiAWJ+MgMOZfI3izI5Q+ CmKGAsb6hJLCmGQ7ZaoEEr+PcLXgJ9u9Ha0E+VJk3orIiXEbEgvr3mCxS g==; X-CSE-ConnectionGUID: qqmAK9l7ToGlCr+s3Hb2sw== X-CSE-MsgGUID: xbqsMyIHSFyredH6TGo2Yg== X-IronPort-AV: E=McAfee;i="6800,10657,11665"; a="86720687" X-IronPort-AV: E=Sophos;i="6.21,211,1763452800"; d="scan'208";a="86720687" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2026 16:30:00 -0800 X-CSE-ConnectionGUID: +aM55RQfSiK4CVJ+HHZuLw== X-CSE-MsgGUID: FprPpiFKRD+vf2GC5TB/5g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,211,1763452800"; d="scan'208";a="203255856" Received: from dapengmi-mobl1.ccr.corp.intel.com (HELO [10.124.240.14]) ([10.124.240.14]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2026 16:29:52 -0800 Message-ID: Date: Fri, 9 Jan 2026 08:29:50 +0800 Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 39/44] KVM: VMX: Bug the VM if either MSR auto-load list is full To: Sean Christopherson Cc: Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Xin Li , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Paolo Bonzini , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Mingwei Zhang , Xudong Hao , Sandipan Das , Xiong Zhang , Manali Shukla , Jim Mattson References: <20251206001720.468579-1-seanjc@google.com> <20251206001720.468579-40-seanjc@google.com> <04c70698-e523-43ae-9092-f360c848d797@linux.intel.com> Content-Language: en-US From: "Mi, Dapeng" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/9/2026 4:04 AM, Sean Christopherson wrote: > On Mon, Dec 08, 2025, Dapeng Mi wrote: >> On 12/6/2025 8:17 AM, Sean Christopherson wrote: >>> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c >>> index 38491962b2c1..2c50ebf4ff1b 100644 >>> --- a/arch/x86/kvm/vmx/vmx.c >>> +++ b/arch/x86/kvm/vmx/vmx.c >>> @@ -1098,6 +1098,7 @@ static void add_atomic_switch_msr(struct vcpu_vmx *vmx, unsigned msr, >>> { >>> int i, j = 0; >>> struct msr_autoload *m = &vmx->msr_autoload; >>> + struct kvm *kvm = vmx->vcpu.kvm; >>> >>> switch (msr) { >>> case MSR_EFER: >>> @@ -1134,12 +1135,10 @@ static void add_atomic_switch_msr(struct vcpu_vmx *vmx, unsigned msr, >>> i = vmx_find_loadstore_msr_slot(&m->guest, msr); >>> j = vmx_find_loadstore_msr_slot(&m->host, msr); >>> >>> - if ((i < 0 && m->guest.nr == MAX_NR_LOADSTORE_MSRS) || >>> - (j < 0 && m->host.nr == MAX_NR_LOADSTORE_MSRS)) { >>> - printk_once(KERN_WARNING "Not enough msr switch entries. " >>> - "Can't add msr %x\n", msr); >>> + if (KVM_BUG_ON(i < 0 && m->guest.nr == MAX_NR_LOADSTORE_MSRS, kvm) || >>> + KVM_BUG_ON(j < 0 && m->host.nr == MAX_NR_LOADSTORE_MSRS, kvm)) >> nit: Remove one extra space before "m->host.nr". > Oh, that's intentional, so that the rest of the line is aligned with the "guest" > line above. Good to know. Thanks.