From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41BE08C09 for ; Mon, 9 Jan 2023 19:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673290937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mHlpuxTK3Q4mXdtUEAjHx/X4tIty+fqRI+m6xngZY9c=; b=iYLzfX/+x0gg809zW0TTeakmRwaUF0lw64Q6nF8en1Uul5QIM1GCu8sbmRnTHfpB3HFrp6 oxhdcO7uTCXXXxk7EsQgQVC/pVAGqjSG9jgNDQdmVvz9akY9LbE16OWkdEv69rUibGbcws LgFQhXQxiRIFhsuNJsoft1bsRTeAWt8= Received: from mail-yb1-f200.google.com (mail-yb1-f200.google.com [209.85.219.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-524-ncHyZEPxOHCRnfhkhhey5A-1; Mon, 09 Jan 2023 14:02:16 -0500 X-MC-Unique: ncHyZEPxOHCRnfhkhhey5A-1 Received: by mail-yb1-f200.google.com with SMTP id k204-20020a256fd5000000b007b8b040bc50so8458803ybc.1 for ; Mon, 09 Jan 2023 11:02:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mHlpuxTK3Q4mXdtUEAjHx/X4tIty+fqRI+m6xngZY9c=; b=NgPAzBDQpB95pEIfJjpNA9y4NoS0aLqVRJIUI1GqkmPK49VEMq+UsUS4qD+gis0dLi JIRaFITmTzA2FZaIBCNam/cMUBjHetRIfSXyHsSrtBQsEU6laayV+Ln+3JNRKoeEjmDS OwGEiLlVfOusO/+wwWFmLFW1oK+CVmihSkaRt3EO7AasptCmZt73D+tZg1Z3E1NY5uBp PW0Mzqp2alnLraIkuBI/BZEqwgfYlzeJ4OuKOkqiRe7uhxmGKzf0lCeCxJgRrRjXrNXi UsQqerBjFYS2OUfa0GfNpGORFV1ztyEYNUlo/WKldRf7dVtsRhdbWGVtnLIiIWoDYWuq FzVw== X-Gm-Message-State: AFqh2krLoWJXo8EQrhyVlEESrkWP5a8lqYaU4zvu+tRlz8Kmlv2SVhSe t3xt+VfRcNYDp6b8ZBYK48uft2qZXJEP3dR0oEJ2RpcqBOagRGTUzY+hBMgQlN4WEz8y0wKbOa6 kUVyWCc/++OAtHchLCCck X-Received: by 2002:a05:7500:5c96:b0:f0:f14:b4f6 with SMTP id fh22-20020a0575005c9600b000f00f14b4f6mr1334334gab.55.1673290935395; Mon, 09 Jan 2023 11:02:15 -0800 (PST) X-Google-Smtp-Source: AMrXdXvpgx9uVCbTytxfSzpNGAx1CCCprwK9dYT+w5TdWAjmS9/Yvcm6uASOc9C3qqyAspkLlpcI4w== X-Received: by 2002:a05:7500:5c96:b0:f0:f14:b4f6 with SMTP id fh22-20020a0575005c9600b000f00f14b4f6mr1334309gab.55.1673290934985; Mon, 09 Jan 2023 11:02:14 -0800 (PST) Received: from vschneid.remote.csb ([154.57.232.159]) by smtp.gmail.com with ESMTPSA id az31-20020a05620a171f00b006fbbdc6c68fsm5795671qkb.68.2023.01.09.11.02.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 11:02:14 -0800 (PST) From: Valentin Schneider To: Ingo Molnar Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, Steven Rostedt , "Paul E. McKenney" , Peter Zijlstra , Thomas Gleixner , Sebastian Andrzej Siewior , Juri Lelli , Daniel Bristot de Oliveira , Marcelo Tosatti , Frederic Weisbecker , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Marc Zyngier , Mark Rutland , Russell King , Nicholas Piggin , Guo Ren , "David S. Miller" Subject: Re: [PATCH v3 3/8] sched, smp: Trace IPIs sent via send_call_function_single_ipi() In-Reply-To: References: <20221202155817.2102944-1-vschneid@redhat.com> <20221202155817.2102944-4-vschneid@redhat.com> Date: Mon, 09 Jan 2023 19:02:08 +0000 Message-ID: Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain On 07/01/23 12:04, Ingo Molnar wrote: > * Valentin Schneider wrote: > >> send_call_function_single_ipi() is the thing that sends IPIs at the bottom >> of smp_call_function*() via either generic_exec_single() or >> smp_call_function_many_cond(). Give it an IPI-related tracepoint. >> >> Note that this ends up tracing any IPI sent via __smp_call_single_queue(), >> which covers __ttwu_queue_wakelist() and irq_work_queue_on() "for free". >> >> Signed-off-by: Valentin Schneider >> Reviewed-by: Steven Rostedt (Google) > > Acked-by: Ingo Molnar > > Patch series logistics: > > - No objections from the scheduler side, this feature looks pretty useful. > Thanks! > - Certain patches are incomplete, others are noted as being merged > separately, so I presume you'll send an updated/completed series > eventually? > The first patch from Steve is now in, so can drop it. The other patches are complete, though I need to rebase them and regenerate the treewide patch to catch any changes that came with 6.2. I'll do that this week. The "incompleteness" pointed out in the cover letter is about the types of IPIs that can be traced. This series covers the ones that end up invoking some core code (coincidentally those are the most common ones), others such as e.g. tick_broadcast() for arm, arm64, riscv and hexagon remain unaffected. I'm not that much interested in these (other than maybe the tick broadcast one they are all fairly unfrequent), but I'm happy to have a shot at them for the sake of completeness - either in that series or in a followup, up to you. > - We can merge this via the scheduler tree I suspect, as most callbacks > affected relate to tip:sched/core and tmp:smp/core - but if you have > some other preferred tree that's fine too. > Either sound good to me. > Thanks, > > Ingo