[LTP] "unzip01" testcase failed.

[LTP] "unzip01" testcase failed.

[Mitani]

Hi,

I found that "unzip01" testcase failed as follows.
----------
unzip01     1  TFAIL  :  Test #1: unzip output differs from expected output.
Details
----------

The above error's "expected output" and "output" are :
  - "tst_unzip.out.exp" file ("expected output") : 
      In "${LTPROOT}/testcases/bin/unzip_tests.sh", the contents of the
      "tst_unzip.dir" directory are expected to output into this file.
  - "tst_unzip.out" file (actual "output") :
      A all contents of the "/opt/LTP/testcases/bin" directory are 
      logged to this file.

This problem occurs because "tst_unzip.dir" directory is not created.

Why does "DIR" become "/opt/ltp/testcases/bin" set 
though "DIR := tst_unzip.dir" is defined 
in "${LTPROOT}/testcases/commands/unzip/Makefile"?

To solve this problem, it is necessary to apply the following patche
to "${LTPROOT}/testcases/commands/unzip/Makefile" for creating 
"tst_unzip.dir" directory, I think.
============
--- Makefile	2009-12-18 17:48:40.000000000 +0900
+++ Makefile.new	2009-12-18 17:38:00.000000000 +0900
@@ -27,8 +27,6 @@
 # Only build and install if we have the zip command.
 HAVE_ZIPTOOLS		:= $(shell if which zip >/dev/null; then echo yes;
else echo no; fi)
 
-DIR			:= tst_unzip.dir
-
 RM			+= -r
 
 TESTCASES_DATA_DIR	:= $(DESTDIR)/$(prefix)/testcases/data
@@ -36,7 +34,7 @@
 ZIPFILE			:= $(TESTCASES_DATA_DIR)/tst_unzip_file.zip
 
 ifeq ($(HAVE_ZIPTOOLS),yes)
-CLEAN_TARGETS		:= $(DIR) $(ZIPFILE)
+CLEAN_TARGETS		:= tst_unzip.dir $(ZIPFILE)
 INSTALL_TARGETS		:= unzip_tests.sh
 endif
 
@@ -45,13 +43,14 @@
 $(TESTCASES_DATA_DIR):
 	mkdir -p "$@"
 
-$(ZIPFILE): | $(TESTCASES_DATA_DIR) $(DIR)
-	zip -r "$@" $(DIR)
+$(ZIPFILE): | $(TESTCASES_DATA_DIR) tst_unzip.dir
+	zip -r "$@" tst_unzip.dir
 	chmod 00666 "$@"
 
 # This target should be auto-removed by Make
-$(DIR): $(abs_srcdir)/unzip_genfile.sh
-	$(SHELL) "$^" $(DIR)
+.INTERMEDIATE: tst_unzip.dir
+tst_unzip.dir: $(abs_srcdir)/unzip_genfile.sh
+	$(SHELL) "$^" tst_unzip.dir
 
 include $(top_srcdir)/include/mk/generic_leaf_target.mk
============


Regards--


-Tomonori Mitani



------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] "unzip01" testcase failed.

[Garrett Cooper]

On Sun, Dec 20, 2009 at 8:23 PM, Mitani <mitani@ryobi.co.jp> wrote:
> Hi,
>
> I found that "unzip01" testcase failed as follows.
> ----------
> unzip01     1  TFAIL  :  Test #1: unzip output differs from expected output.
> Details
> ----------
>
> The above error's "expected output" and "output" are :
>  - "tst_unzip.out.exp" file ("expected output") :
>      In "${LTPROOT}/testcases/bin/unzip_tests.sh", the contents of the
>      "tst_unzip.dir" directory are expected to output into this file.
>  - "tst_unzip.out" file (actual "output") :
>      A all contents of the "/opt/LTP/testcases/bin" directory are
>      logged to this file.
>
> This problem occurs because "tst_unzip.dir" directory is not created.
>
> Why does "DIR" become "/opt/ltp/testcases/bin" set
> though "DIR := tst_unzip.dir" is defined
> in "${LTPROOT}/testcases/commands/unzip/Makefile"?
>
> To solve this problem, it is necessary to apply the following patche
> to "${LTPROOT}/testcases/commands/unzip/Makefile" for creating
> "tst_unzip.dir" directory, I think.
> ============
> --- Makefile    2009-12-18 17:48:40.000000000 +0900
> +++ Makefile.new        2009-12-18 17:38:00.000000000 +0900
> @@ -27,8 +27,6 @@
>  # Only build and install if we have the zip command.
>  HAVE_ZIPTOOLS          := $(shell if which zip >/dev/null; then echo yes;
> else echo no; fi)
>
> -DIR                    := tst_unzip.dir
> -
>  RM                     += -r
>
>  TESTCASES_DATA_DIR     := $(DESTDIR)/$(prefix)/testcases/data
> @@ -36,7 +34,7 @@
>  ZIPFILE                        := $(TESTCASES_DATA_DIR)/tst_unzip_file.zip
>
>  ifeq ($(HAVE_ZIPTOOLS),yes)
> -CLEAN_TARGETS          := $(DIR) $(ZIPFILE)
> +CLEAN_TARGETS          := tst_unzip.dir $(ZIPFILE)
>  INSTALL_TARGETS                := unzip_tests.sh
>  endif
>
> @@ -45,13 +43,14 @@
>  $(TESTCASES_DATA_DIR):
>        mkdir -p "$@"
>
> -$(ZIPFILE): | $(TESTCASES_DATA_DIR) $(DIR)
> -       zip -r "$@" $(DIR)
> +$(ZIPFILE): | $(TESTCASES_DATA_DIR) tst_unzip.dir
> +       zip -r "$@" tst_unzip.dir
>        chmod 00666 "$@"
>
>  # This target should be auto-removed by Make
> -$(DIR): $(abs_srcdir)/unzip_genfile.sh
> -       $(SHELL) "$^" $(DIR)
> +.INTERMEDIATE: tst_unzip.dir
> +tst_unzip.dir: $(abs_srcdir)/unzip_genfile.sh
> +       $(SHELL) "$^" tst_unzip.dir
>
>  include $(top_srcdir)/include/mk/generic_leaf_target.mk

I'm not convinced that this is the right solution because most of
what's done here just replaced $(DIR)'s value with the bareword value.
.INTERMEDIATE may be the only piece of value here, but I was avoiding
it because it's a 3.81-ism I thought...

Thanks,
-Garrett

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] "unzip01" testcase failed.

[Caspar Zhang]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]


----- "Garrett Cooper" <yanegomi@gmail.com> wrote:
> 
> I'm not convinced that this is the right solution because most of
> what's done here just replaced $(DIR)'s value with the bareword
> value.
> .INTERMEDIATE may be the only piece of value here, but I was avoiding
> it because it's a 3.81-ism I thought...

How about this one (see the attachment)?

Thanks,
Caspar
> 
> Thanks,
> -Garrett

[-- Attachment #2: commands-unzip01.patch --]
[-- Type: application/octet-stream, Size: 1674 bytes --]

diff -Naur a/include/mk/generic_leaf_target.inc b/include/mk/generic_leaf_target.inc
--- a/include/mk/generic_leaf_target.inc	2009-12-01 17:57:15.000000000 +0800
+++ b/include/mk/generic_leaf_target.inc	2009-12-11 12:33:01.716202544 +0800
@@ -97,7 +97,7 @@
 all: $(MAKE_TARGETS)
 
 clean:: $(CLEAN_DEPS)
-	-$(RM) -f $(CLEAN_TARGETS)
+	-$(RM) -rf $(CLEAN_TARGETS)
 
 $(INSTALL_FILES): | $(INSTALL_DEPS)
 
diff -Naur a/runtest/commands b/runtest/commands
--- a/runtest/commands	2009-02-26 21:10:54.000000000 +0800
+++ b/runtest/commands	2009-12-11 12:55:07.386077960 +0800
@@ -10,7 +10,7 @@
 logrotate export TCdat=$LTPROOT/testcases/bin; logrotate_tests.sh
 mail export TCdat=$LTPROOT/testcases/bin; mail_tests.sh
 cpio export TCdat=$LTPROOT/testcases/bin; cpio_tests.sh
-unzip01 unzip_tests.sh $LTPROOT/testcases/commands/unzip/tst_unzip_file.zip
+unzip01 unzip_tests.sh $LTPROOT/testcases/bin/tst_unzip_file.zip
 gzip01 gzip_tests.sh
 cp_tests01 cp_tests.sh
 ln_tests01 ln_tests.sh
diff -Naur a/testcases/commands/unzip/Makefile b/testcases/commands/unzip/Makefile
--- a/testcases/commands/unzip/Makefile	2009-10-10 01:55:45.000000000 +0800
+++ b/testcases/commands/unzip/Makefile	2009-12-11 12:37:12.397202792 +0800
@@ -27,13 +27,13 @@
 # Only build and install if we have the zip command.
 HAVE_ZIPTOOLS		:= $(shell if which zip >/dev/null; then echo yes; else echo no; fi)
 
+ZIP			:= zip
 DIR			:= tst_unzip.dir
-
-MAKE_TARGETS		:=
+ZIPFILE			:= tst_unzip_file.zip
+MAKE_TARGETS		:= $(ZIPFILE)
 
 ifeq ($(HAVE_ZIPTOOLS),yes)
-INSTALL_TARGETS		:= unzip_tests.sh
-$(INSTALL_TARGETS): $(ZIPFILE)
+INSTALL_TARGETS		:= unzip_tests.sh $(ZIPFILE)
 endif
 
 $(ZIPFILE): $(DIR)

[-- Attachment #3: Type: text/plain, Size: 390 bytes --]

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] "unzip01" testcase failed.

[Garrett Cooper]

On Sun, Dec 20, 2009 at 9:45 PM, Caspar Zhang <czhang@redhat.com> wrote:
>
> ----- "Garrett Cooper" <yanegomi@gmail.com> wrote:
>>
>> I'm not convinced that this is the right solution because most of
>> what's done here just replaced $(DIR)'s value with the bareword
>> value.
>> .INTERMEDIATE may be the only piece of value here, but I was avoiding
>> it because it's a 3.81-ism I thought...
>
> How about this one (see the attachment)?

AH... -[Rr] was missing.

RM += -[Rr]

will do that. The rest just seems spurious.

Thanks!
-Garrett

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] "unzip01" testcase failed.

[Garrett Cooper]

On Mon, Dec 21, 2009 at 1:10 AM, Garrett Cooper <yanegomi@gmail.com> wrote:
> On Sun, Dec 20, 2009 at 9:45 PM, Caspar Zhang <czhang@redhat.com> wrote:
>>
>> ----- "Garrett Cooper" <yanegomi@gmail.com> wrote:
>>>
>>> I'm not convinced that this is the right solution because most of
>>> what's done here just replaced $(DIR)'s value with the bareword
>>> value.
>>> .INTERMEDIATE may be the only piece of value here, but I was avoiding
>>> it because it's a 3.81-ism I thought...
>>
>> How about this one (see the attachment)?
>
> AH... -[Rr] was missing.
>
> RM += -[Rr]
>
> will do that. The rest just seems spurious.

    Uh, this was already committed on HEAD:

http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/commands/unzip/Makefile?r1=1.9&r2=1.8

    What version are you working with?
Thanks,
-Garrett

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] "unzip01" testcase failed.

[Mitani]

Hi,

I tried to test "unzip01".
But I get still the same fail at 2010-01-14 cvs.

I think that this failure occurs because "DIR" can't be defined 
correctly in "${LTPROOT}/testcases/commands/unzip/Makefile" and 
all files of "/opt/ltp/testcases/bin" directory was compressed.

There is the definition "DIR := tst_unzip.dir" in "${LTPROOT}/testcases
/commands/unzip/Makefile". But there is the definition "DIR := /opt/ltp
/testcases/bin" in two include files ("${LTPROOT}/include/mk/env_pre.mk"
and "${LTPROOT}/include/mk/generic_leaf_target.mk") which are included 
in "${LTPROOT}/testcases/commands/unzip/Makefile".

Perhaps, "DIR := tst_unzip.dir" is replaced by "DIR := /opt/ltp
/testcases/bin" when the two files were included, I think.

This test requires "tst_unzip.dir" and if the variable name "DIR" is
changed to another name, this problem will not occur.


> .INTERMEDIATE may be the only piece of value here, but I was avoiding
> it because it's a 3.81-ism I thought...

So, I don't try use .INTERMEDIATE target.

However, the compress target directory ("tst_unzip.dir") is created
under "$LTPROOT/testcases/commands/unzip" directory.
But I think that it does not affect for the test because the compressed
file which is for the test ("tst_unzip_file.zip") is create under 
the run directory ("/opy/ltp"). "tst_unzip.dir" is the file which isn't
related directly to the practice of the test, I think.

How about this patch:
============
--- Makefile.org	2009-12-11 21:50:29.000000000 +0900
+++ Makefile	2010-01-14 11:44:30.000000000 +0900
@@ -27,7 +27,7 @@
 # Only build and install if we have the zip command.
 HAVE_ZIPTOOLS		:= $(shell if which zip >/dev/null; then echo yes;
else echo no; fi)
 
-DIR			:= tst_unzip.dir
+COMPRESS_DIR		:= tst_unzip.dir
 
 RM			+= -r
 
@@ -36,7 +36,7 @@
 ZIPFILE			:= $(TESTCASES_DATA_DIR)/tst_unzip_file.zip
 
 ifeq ($(HAVE_ZIPTOOLS),yes)
-CLEAN_TARGETS		:= $(DIR) $(ZIPFILE)
+CLEAN_TARGETS		:= $(COMPRESS_DIR) $(ZIPFILE)
 INSTALL_TARGETS		:= unzip_tests.sh
 endif
 
@@ -45,13 +45,13 @@
 $(TESTCASES_DATA_DIR):
 	mkdir -p "$@"
 
-$(ZIPFILE): | $(TESTCASES_DATA_DIR) $(DIR)
-	zip -r "$@" $(DIR)
+$(ZIPFILE): | $(TESTCASES_DATA_DIR) $(COMPRESS_DIR)
+	zip -r "$@" $(COMPRESS_DIR)
 	chmod 00666 "$@"
 
 # This target should be auto-removed by Make
-$(DIR): $(abs_srcdir)/unzip_genfile.sh
-	$(SHELL) "$^" $(DIR)
+$(COMPRESS_DIR): $(abs_srcdir)/unzip_genfile.sh
+	$(SHELL) "$^" $(COMPRESS_DIR)
 
 include $(top_srcdir)/include/mk/generic_leaf_target.mk
 
============


I'm glad if I can get opinion that my revision is right or not.


Regards--


-Tomonori Mitani


-----Original Message-----
From: Garrett Cooper [mailto:yanegomi@gmail.com] 
Sent: Tuesday, December 22, 2009 11:39 AM
To: Caspar Zhang
Cc: ltp-list@lists.sourceforge.net; Mitani
Subject: Re: [LTP] "unzip01" testcase failed.

On Mon, Dec 21, 2009 at 1:10 AM, Garrett Cooper <yanegomi@gmail.com> wrote:
> On Sun, Dec 20, 2009 at 9:45 PM, Caspar Zhang <czhang@redhat.com> wrote:
>>
>> ----- "Garrett Cooper" <yanegomi@gmail.com> wrote:
>>>
>>> I'm not convinced that this is the right solution because most of
>>> what's done here just replaced $(DIR)'s value with the bareword
>>> value.
>>> .INTERMEDIATE may be the only piece of value here, but I was avoiding
>>> it because it's a 3.81-ism I thought...
>>
>> How about this one (see the attachment)?
>
> AH... -[Rr] was missing.
>
> RM += -[Rr]
>
> will do that. The rest just seems spurious.

    Uh, this was already committed on HEAD:

http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/commands/unzip/Makef
ile?r1=1.9&r2=1.8

    What version are you working with?
Thanks,
-Garrett



------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] "unzip01" testcase failed.

[Garrett Cooper]

On Wed, Jan 13, 2010 at 11:30 PM, Mitani <mitani@ryobi.co.jp> wrote:
> Hi,
>
> I tried to test "unzip01".
> But I get still the same fail at 2010-01-14 cvs.
>
> I think that this failure occurs because "DIR" can't be defined
> correctly in "${LTPROOT}/testcases/commands/unzip/Makefile" and
> all files of "/opt/ltp/testcases/bin" directory was compressed.
>
> There is the definition "DIR := tst_unzip.dir" in "${LTPROOT}/testcases
> /commands/unzip/Makefile". But there is the definition "DIR := /opt/ltp
> /testcases/bin" in two include files ("${LTPROOT}/include/mk/env_pre.mk"
> and "${LTPROOT}/include/mk/generic_leaf_target.mk") which are included
> in "${LTPROOT}/testcases/commands/unzip/Makefile".
>
> Perhaps, "DIR := tst_unzip.dir" is replaced by "DIR := /opt/ltp
> /testcases/bin" when the two files were included, I think.
>
> This test requires "tst_unzip.dir" and if the variable name "DIR" is
> changed to another name, this problem will not occur.
>
>
>> .INTERMEDIATE may be the only piece of value here, but I was avoiding
>> it because it's a 3.81-ism I thought...
>
> So, I don't try use .INTERMEDIATE target.
>
> However, the compress target directory ("tst_unzip.dir") is created
> under "$LTPROOT/testcases/commands/unzip" directory.
> But I think that it does not affect for the test because the compressed
> file which is for the test ("tst_unzip_file.zip") is create under
> the run directory ("/opy/ltp"). "tst_unzip.dir" is the file which isn't
> related directly to the practice of the test, I think.
>
> How about this patch:
> ============
> --- Makefile.org        2009-12-11 21:50:29.000000000 +0900
> +++ Makefile    2010-01-14 11:44:30.000000000 +0900
> @@ -27,7 +27,7 @@
>  # Only build and install if we have the zip command.
>  HAVE_ZIPTOOLS          := $(shell if which zip >/dev/null; then echo yes;
> else echo no; fi)
>
> -DIR                    := tst_unzip.dir
> +COMPRESS_DIR           := tst_unzip.dir
>
>  RM                     += -r
>
> @@ -36,7 +36,7 @@
>  ZIPFILE                        := $(TESTCASES_DATA_DIR)/tst_unzip_file.zip
>
>  ifeq ($(HAVE_ZIPTOOLS),yes)
> -CLEAN_TARGETS          := $(DIR) $(ZIPFILE)
> +CLEAN_TARGETS          := $(COMPRESS_DIR) $(ZIPFILE)
>  INSTALL_TARGETS                := unzip_tests.sh
>  endif
>
> @@ -45,13 +45,13 @@
>  $(TESTCASES_DATA_DIR):
>        mkdir -p "$@"
>
> -$(ZIPFILE): | $(TESTCASES_DATA_DIR) $(DIR)
> -       zip -r "$@" $(DIR)
> +$(ZIPFILE): | $(TESTCASES_DATA_DIR) $(COMPRESS_DIR)
> +       zip -r "$@" $(COMPRESS_DIR)
>        chmod 00666 "$@"
>
>  # This target should be auto-removed by Make
> -$(DIR): $(abs_srcdir)/unzip_genfile.sh
> -       $(SHELL) "$^" $(DIR)
> +$(COMPRESS_DIR): $(abs_srcdir)/unzip_genfile.sh
> +       $(SHELL) "$^" $(COMPRESS_DIR)
>
>  include $(top_srcdir)/include/mk/generic_leaf_target.mk
>
> ============
>
>
> I'm glad if I can get opinion that my revision is right or not.
>
>
> Regards--
>
>
> -Tomonori Mitani

Crap, you spotted the problem, but it was just in the wrong spot (from
functions.mk):

#
# Generate the directory install dependency separate from generate_install_rule
# to avoid noise from Make about redefining existing targets, for good reason.
#
# 1 -> The base install directory, based off $(prefix), or another
#      $(prefix)-like variable. Automatically gets $(DESTDIR) tacked on it.
# 2 -> The install target. This can be relative to $(srcdir), but will most
#      likely be `empty'.
#
define generate_install_rule_dir_dep
ifdef MAKE_3_80_COMPAT
DIR     := $$(call MAKE_3_80_abspath,$(DESTDIR)/$(1)/$(2))
else
DIR     := $$(abspath $(DESTDIR)/$(1)/$(2))
endif
$$(DIR):
        mkdir -p "$$@"
endef

>_>... I'm trying out something to get rid of this item... I'll get back to you in a few.

> -----Original Message-----
> From: Garrett Cooper [mailto:yanegomi@gmail.com]
> Sent: Tuesday, December 22, 2009 11:39 AM
> To: Caspar Zhang
> Cc: ltp-list@lists.sourceforge.net; Mitani
> Subject: Re: [LTP] "unzip01" testcase failed.
>
> On Mon, Dec 21, 2009 at 1:10 AM, Garrett Cooper <yanegomi@gmail.com> wrote:
>> On Sun, Dec 20, 2009 at 9:45 PM, Caspar Zhang <czhang@redhat.com> wrote:
>>>
>>> ----- "Garrett Cooper" <yanegomi@gmail.com> wrote:
>>>>
>>>> I'm not convinced that this is the right solution because most of
>>>> what's done here just replaced $(DIR)'s value with the bareword
>>>> value.
>>>> .INTERMEDIATE may be the only piece of value here, but I was avoiding
>>>> it because it's a 3.81-ism I thought...
>>>
>>> How about this one (see the attachment)?
>>
>> AH... -[Rr] was missing.
>>
>> RM += -[Rr]
>>
>> will do that. The rest just seems spurious.
>
>    Uh, this was already committed on HEAD:
>
> http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/commands/unzip/Makef
> ile?r1=1.9&r2=1.8

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] "unzip01" testcase failed.

[Garrett Cooper]

On Thu, Jan 14, 2010 at 12:29 AM, Garrett Cooper <yanegomi@gmail.com> wrote:
> On Wed, Jan 13, 2010 at 11:30 PM, Mitani <mitani@ryobi.co.jp> wrote:
>> Hi,
>>
>> I tried to test "unzip01".
>> But I get still the same fail at 2010-01-14 cvs.
>>
>> I think that this failure occurs because "DIR" can't be defined
>> correctly in "${LTPROOT}/testcases/commands/unzip/Makefile" and
>> all files of "/opt/ltp/testcases/bin" directory was compressed.
>>
>> There is the definition "DIR := tst_unzip.dir" in "${LTPROOT}/testcases
>> /commands/unzip/Makefile". But there is the definition "DIR := /opt/ltp
>> /testcases/bin" in two include files ("${LTPROOT}/include/mk/env_pre.mk"
>> and "${LTPROOT}/include/mk/generic_leaf_target.mk") which are included
>> in "${LTPROOT}/testcases/commands/unzip/Makefile".
>>
>> Perhaps, "DIR := tst_unzip.dir" is replaced by "DIR := /opt/ltp
>> /testcases/bin" when the two files were included, I think.
>>
>> This test requires "tst_unzip.dir" and if the variable name "DIR" is
>> changed to another name, this problem will not occur.
>>
>>
>>> .INTERMEDIATE may be the only piece of value here, but I was avoiding
>>> it because it's a 3.81-ism I thought...
>>
>> So, I don't try use .INTERMEDIATE target.
>>
>> However, the compress target directory ("tst_unzip.dir") is created
>> under "$LTPROOT/testcases/commands/unzip" directory.
>> But I think that it does not affect for the test because the compressed
>> file which is for the test ("tst_unzip_file.zip") is create under
>> the run directory ("/opy/ltp"). "tst_unzip.dir" is the file which isn't
>> related directly to the practice of the test, I think.
>>
>> How about this patch:
>> ============
>> --- Makefile.org        2009-12-11 21:50:29.000000000 +0900
>> +++ Makefile    2010-01-14 11:44:30.000000000 +0900
>> @@ -27,7 +27,7 @@
>>  # Only build and install if we have the zip command.
>>  HAVE_ZIPTOOLS          := $(shell if which zip >/dev/null; then echo yes;
>> else echo no; fi)
>>
>> -DIR                    := tst_unzip.dir
>> +COMPRESS_DIR           := tst_unzip.dir
>>
>>  RM                     += -r
>>
>> @@ -36,7 +36,7 @@
>>  ZIPFILE                        := $(TESTCASES_DATA_DIR)/tst_unzip_file.zip
>>
>>  ifeq ($(HAVE_ZIPTOOLS),yes)
>> -CLEAN_TARGETS          := $(DIR) $(ZIPFILE)
>> +CLEAN_TARGETS          := $(COMPRESS_DIR) $(ZIPFILE)
>>  INSTALL_TARGETS                := unzip_tests.sh
>>  endif
>>
>> @@ -45,13 +45,13 @@
>>  $(TESTCASES_DATA_DIR):
>>        mkdir -p "$@"
>>
>> -$(ZIPFILE): | $(TESTCASES_DATA_DIR) $(DIR)
>> -       zip -r "$@" $(DIR)
>> +$(ZIPFILE): | $(TESTCASES_DATA_DIR) $(COMPRESS_DIR)
>> +       zip -r "$@" $(COMPRESS_DIR)
>>        chmod 00666 "$@"
>>
>>  # This target should be auto-removed by Make
>> -$(DIR): $(abs_srcdir)/unzip_genfile.sh
>> -       $(SHELL) "$^" $(DIR)
>> +$(COMPRESS_DIR): $(abs_srcdir)/unzip_genfile.sh
>> +       $(SHELL) "$^" $(COMPRESS_DIR)
>>
>>  include $(top_srcdir)/include/mk/generic_leaf_target.mk
>>
>> ============
>>
>>
>> I'm glad if I can get opinion that my revision is right or not.
>>
>>
>> Regards--
>>
>>
>> -Tomonori Mitani
>
> Crap, you spotted the problem, but it was just in the wrong spot (from
> functions.mk):
>
> #
> # Generate the directory install dependency separate from generate_install_rule
> # to avoid noise from Make about redefining existing targets, for good reason.
> #
> # 1 -> The base install directory, based off $(prefix), or another
> #      $(prefix)-like variable. Automatically gets $(DESTDIR) tacked on it.
> # 2 -> The install target. This can be relative to $(srcdir), but will most
> #      likely be `empty'.
> #
> define generate_install_rule_dir_dep
> ifdef MAKE_3_80_COMPAT
> DIR     := $$(call MAKE_3_80_abspath,$(DESTDIR)/$(1)/$(2))
> else
> DIR     := $$(abspath $(DESTDIR)/$(1)/$(2))
> endif
> $$(DIR):
>        mkdir -p "$$@"
> endef
>
>>_>... I'm trying out something to get rid of this item... I'll get back to you in a few.
>
>> -----Original Message-----
>> From: Garrett Cooper [mailto:yanegomi@gmail.com]
>> Sent: Tuesday, December 22, 2009 11:39 AM
>> To: Caspar Zhang
>> Cc: ltp-list@lists.sourceforge.net; Mitani
>> Subject: Re: [LTP] "unzip01" testcase failed.
>>
>> On Mon, Dec 21, 2009 at 1:10 AM, Garrett Cooper <yanegomi@gmail.com> wrote:
>>> On Sun, Dec 20, 2009 at 9:45 PM, Caspar Zhang <czhang@redhat.com> wrote:
>>>>
>>>> ----- "Garrett Cooper" <yanegomi@gmail.com> wrote:
>>>>>
>>>>> I'm not convinced that this is the right solution because most of
>>>>> what's done here just replaced $(DIR)'s value with the bareword
>>>>> value.
>>>>> .INTERMEDIATE may be the only piece of value here, but I was avoiding
>>>>> it because it's a 3.81-ism I thought...
>>>>
>>>> How about this one (see the attachment)?
>>>
>>> AH... -[Rr] was missing.
>>>
>>> RM += -[Rr]
>>>
>>> will do that. The rest just seems spurious.
>>
>>    Uh, this was already committed on HEAD:

    Please try now. I removed the other offending code in include/mk.
Thanks,
-Garrett

------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list