public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: "Mitani" <mitani@ryobi.co.jp>
To: 'Rishikesh K Rajak' <risrajak@linux.vnet.ibm.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] cap_bounds_r.c build failure
Date: Thu, 1 Apr 2010 18:23:03 +0900	[thread overview]
Message-ID: <000101cad17c$ee4946d0$cadbd470$@co.jp> (raw)
In-Reply-To: <20100401083510.GD13796@linux.vnet.ibm.com>

Hi Rishi,


"libcap-devel" was not installed in my system.

------------
[root@RHEL4-8 mitani]# rpm -qa | grep libcap
libcap-1.10-20
[root@RHEL4-8 mitani]#
------------

I'm trying to install libcap-devel now.


Thanks--

-Tomonori Mitani

> -----Original Message-----
> From: Rishikesh K Rajak [mailto:risrajak@linux.vnet.ibm.com]
> Sent: Thursday, April 01, 2010 5:35 PM
> To: Mitani
> Cc: ltp-list@lists.sourceforge.net
> Subject: Re: [LTP] cap_bounds_r.c build failure
> 
> Hi  Mitani,
> 
> Can you confirm if you have installed libcap-devel ? As i see this is
> defined
> under linux/capability.h .
> 
> #define CAP_MAC_ADMIN        33
> 
> #define CAP_LAST_CAP         CAP_MAC_ADMIN
> 
> #define cap_valid(x) ((x) >= 0 && (x) <= CAP_LAST_CAP)
> 
> 
> Which unltimately is being called by sys/capability.h .
> 
> 
> FYI, I did not get any compilation error on SLES11GA where:
> 
> libcap2-2.11-2.15
> libcap-devel-2.11-2.15
> 
> -Rishi
> 
> 
> On Thu, Apr 01, 2010 at 05:13:39PM +0900, Mitani wrote:
> > Hi,
> >
> > I tried to build by using yesterday's git.
> >  (ltp-dev-02719d6f7e5cb252c0fcbfbaf26208d7196e46f2.tar.gz)
> > But build failed in "cap_bounds_r.c" with following message.
> >
> > ------------
> > gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall
> > -I/home/LTP/ltp-dev-20100401/testcases/kernel/include
> -I../../../../include
> > -I../../../../include   -L../../../../lib  cap_bounds_r.c
> -lltp -lcap -o
> > cap_bounds_r
> > cap_bounds_r.c: In function `main':
> > cap_bounds_r.c:46: error: `CAP_LAST_CAP' undeclared (first use in
> this
> > function)
> > cap_bounds_r.c:46: error: (Each undeclared identifier is reported
> only once
> > cap_bounds_r.c:46: error: for each function it appears in.)
> > make[4]: *** [cap_bounds_r] Error 1
> > ------------
> >
> > I tried to today's git, but it failed, too.
> >  (ltp-dev-44fba94453ca4f446cde4db08b0a760862b55cfa.tar.gz)
> >
> >
> > I referd this source's diff in following URL.
> >
> http://ltp.git.sourceforge.net/git/gitweb.cgi?p=ltp/ltp-dev.git;a=
> commitdiff
> > ;h=6e3dd83d9f575d98d76b8b3f642ad6e8793dbdfc
> >
> > "CAP_LAST_CAP" definition is deleted with other definitions in this
> > revision.
> > But "CAP_LAST_CAP" is still used after edited version.
> >
> > "The editor may have deleted too much to make this source simple?"
> > I think. ;-)
> >
> >
> > There is same problem in "cap_bounds_rw.c", too.
> >
> >
> > How about following patch?
> >
> >
> > Signed-off-by: Tomonori Mitani <mitani@ryobi.co.jp>
> >
> > Index: ./testcases/kernel/security/cap_bound/cap_bounds_r.c
> > ============
> > --- ./testcases/kernel/security/cap_bound/cap_bounds_r.c
> 2010-03-31
> > 22:44:52.000000000 +0900
> > +++ ./testcases/kernel/security/cap_bound/cap_bounds_r.c.new
> 2010-04-01
> > 15:43:01.000000000 +0900
> > @@ -32,6 +32,13 @@
> >  #include <sys/prctl.h>
> >  #include <test.h>
> >
> > +#if HAVE_SYS_CAPABILITY_H
> > +#ifndef CAP_LAST_CAP
> > +#warning out-of-date capability.h does not define CAP_LAST_CAP
> > +#define CAP_LAST_CAP 28  /* be ultra-conservative */
> > +#endif
> > +#endif
> > +
> >  char *TCID = "cap_bounds_r";
> >  int TST_TOTAL=1;
> >
> > ============
> >
> > Index: ./testcases/kernel/security/cap_bound/cap_bounds_rw.c
> > ============
> > --- ./testcases/kernel/security/cap_bound/cap_bounds_rw.c
> 2010-03-31
> > 22:44:52.000000000 +0900
> > +++ ./testcases/kernel/security/cap_bound/cap_bounds_rw.c.new
> 2010-04-01
> > 15:44:39.000000000 +0900
> > @@ -31,6 +31,13 @@
> >  #include <sys/prctl.h>
> >  #include <test.h>
> >
> > +#if HAVE_SYS_CAPABILITY_H
> > +#ifndef CAP_LAST_CAP
> > +#warning out-of-date capability.h does not define CAP_LAST_CAP
> > +#define CAP_LAST_CAP 28  /* be ultra-conservative */
> > +#endif
> > +#endif
> > +
> >  char *TCID = "cap_bounds_rw";
> >  int TST_TOTAL=1;
> >
> > ============
> >
> >
> > Regards--
> >
> > -Tomonori Mitani
> >
> >
> >
> >
> ------------------------------------------------------------------
> ------------
> > Download Intel&#174; Parallel Studio Eval
> > Try the new software tools for yourself. Speed compiling, find bugs
> > proactively, and fine-tune applications for parallel performance.
> > See why Intel Parallel Studio got high marks during beta.
> > http://p.sf.net/sfu/intel-sw-dev
> > _______________________________________________
> > Ltp-list mailing list
> > Ltp-list@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/ltp-list
> 
> --
> Thanks & Regards
> Rishi
> LTP Maintainer
> IBM, LTC, Bangalore
> Please join IRC #ltp @ irc.freenode.net



------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2010-04-01  9:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-01  8:13 [LTP] cap_bounds_r.c build failure Mitani
2010-04-01  8:35 ` Rishikesh K Rajak
2010-04-01  9:23   ` Mitani [this message]
2010-04-01  9:35     ` Rishikesh K Rajak
2010-04-01 11:24       ` Mitani
2010-04-01 15:26         ` Serge E. Hallyn
2010-04-02  2:20           ` Mitani
2010-04-05 13:20             ` Serge E. Hallyn
2010-04-09  7:49               ` Mitani
2010-04-16 18:39                 ` Garrett Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000101cad17c$ee4946d0$cadbd470$@co.jp' \
    --to=mitani@ryobi.co.jp \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=risrajak@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox