Re: [LTP] [PATCH] Fix rt_sigtimedwait ordering test

["Will Deacon" <will.deacon@arm.com>]

Hello,

> The rt_sigtimedwait test invokes test_masked_matching_rt, which
> spawns two children who send consecutive RT signals to the parent.
> The test then checks (via sigwaitinfo) that the RT signals are
> delivered in the correct order: namely that the lower signal is taken
> first.
> 
> This test can fail due to a race condition where the parent issues
> the sigwaitinfo syscall before the first child has signalled the
> parent but after the second child has (due to context switching).
> This results in the signals being received in the reverse order.
> 
> This patch inserts waitpid syscalls to the parent thread so that the
> sigwaitinfo call is only issued after the children have exited.
> 
> Signed-off-by: Will Deacon <will.deacon@arm.com>
> ---
>  .../kernel/syscalls/sigwaitinfo/sigwaitinfo01.c    |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)

I've not heard anything further on this, but it does fix a real issue
on the platform I'm using. Do you need anything more from me for this
to be considered for committing?

Cheers,

Will




------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list