Re: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> factor_nr = 5

Jan Stancek
2013-10-11T10:35:27Z

----- Original Message -----
> From: "Zeng Linggang" <zenglg.jy@cn.fujitsu.com>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp-list@lists.sourceforge.net
> Sent: Friday, 11 October, 2013 12:19:19 PM
> Subject: RE: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 -> factor_nr = 5
>
>
>
> > -----Original Message-----
> > From: 曾令钢 [mailto:zenglg.jy@cn.fujitsu.com]
> > Sent: Thursday, October 10, 2013 4:16 PM
> > To: 'Jan Stancek'
> > Cc: 'ltp-list@lists.sourceforge.net'
> > Subject: 答复: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 ->
> > factor_nr = 5
> >
> >
> >
> > >
> > >
> > > ----- Original Message -----
> > > > From: "曾令钢" <zenglg.jy@cn.fujitsu.com>
> > > > To: ltp-list@lists.sourceforge.net
> > > > Sent: Thursday, 10 October, 2013 7:56:05 AM
> > > > Subject: [LTP] [PATCH] getrusage/getrusage04.c: Fix factor_nr = 1 ->
> > > factor_nr = 5
> > > >
> > > > To make udelta or sdelta's values isnot great than expected, we
> > > > change the factor_nr to 5.
> > >
> > > Note, that there is already a parameter -m to set factor_nr.
> > >
> > > Can you share more details why this should be the default?
> > > On which system/architecture do you see it failing?
> >
> > Yes. We have some problems in RHEL5.10GA.
> > It could not work as we expected. And I will be more careful.
> > Thanks.
> >
>
> Maybe the case is not suit for xen kernel.
> When kernel is vmlinuz-2.6.18-371.el5xen, the case will fail.
> But with vmlinuz-2.6.18-371.el5, it works well.

Can you send the output from failed run?

>
> Regards,
> Zeng
>
> > >
> > > Regards,
> > > Jan
> > >
> > > >
> > > > Signed-off-by: Zeng Linggang <zenglg.jy@cn.fujitsu.com>
> > > > ---
> > > > testcases/kernel/syscalls/getrusage/getrusage04.c | 2 +-
> > > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > > >
> > > > diff --git a/testcases/kernel/syscalls/getrusage/getrusage04.c
> > > > b/testcases/kernel/syscalls/getrusage/getrusage04.c
> > > > index 96e24a4..41d0052 100644
> > > > --- a/testcases/kernel/syscalls/getrusage/getrusage04.c
> > > > +++ b/testcases/kernel/syscalls/getrusage/getrusage04.c
> > > > @@ -67,7 +67,7 @@ static long BIAS_MAX;
> > > >
> > > > static int opt_factor;
> > > > static char *factor_str;
> > > > -static long factor_nr = 1;
> > > > +static long factor_nr = 5;
> > > >
> > > > option_t child_options[] = {
> > > > {"m:", &opt_factor, &factor_str},
> > > > --
> > > > 1.7.1
> > > >
> > > >
> > > >
> > > >
> > > > --------------------------------------------------------------------
> > > > --
> > > > -------- October Webinars: Code for Performance Free Intel webinars
> > > > can help you accelerate application performance.
> > > > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the
> > > > most from the latest Intel processors and coprocessors. See
> > > > abstracts and register >
> > > >
> > >
> > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.c
> > > > lktrk _______________________________________________
> > > > Ltp-list mailing list
> > > > Ltp-list@lists.sourceforge.net
> > > > https://lists.sourceforge.net/lists/listinfo/ltp-list
> > > >