From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1Ul9IY-00076R-Uo for ltp-list@lists.sourceforge.net; Sat, 08 Jun 2013 02:54:34 +0000 Received: from lgemrelse7q.lge.com ([156.147.1.151]) by sog-mx-4.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1Ul9IX-0006NW-Eg for ltp-list@lists.sourceforge.net; Sat, 08 Jun 2013 02:54:34 +0000 From: "Jungsoo Son" Date: Sat, 8 Jun 2013 11:54:26 +0900 Message-ID: <00f801ce63f3$7d4cc8f0$77e65ad0$@lge.com> MIME-Version: 1.0 Content-Language: ko Subject: [LTP] [PATCH] syscalls/chown01: Fix test file creation List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: ltp-list@lists.sourceforge.net There is a bug in the code to create the file and the code is very intricate. So replace it with SAFE_FILE_PRINTF(). Signed-off-by: jungsoo.son --- testcases/kernel/syscalls/chown/chown01.c | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/testcases/kernel/syscalls/chown/chown01.c b/testcases/kernel/syscalls/chown/chown01.c index 50b9ea5..14b699b 100644 --- a/testcases/kernel/syscalls/chown/chown01.c +++ b/testcases/kernel/syscalls/chown/chown01.c @@ -116,9 +116,7 @@ #include #include "test.h" #include "usctest.h" - -void setup(); -void cleanup(); +#include "safe_macros.h" char *TCID = "chown01"; int TST_TOTAL = 1; @@ -126,8 +124,10 @@ int TST_TOTAL = 1; int exp_enos[] = { 0, 0 }; char fname[255]; -int fd, uid, gid; -char *buf = "davef"; +int uid, gid; + +static void setup(); +static void cleanup(); int main(int ac, char **av) { @@ -163,7 +163,7 @@ int main(int ac, char **av) } -void setup() +static void setup() { tst_sig(NOFORK, DEF_HANDLER, cleanup); @@ -176,17 +176,11 @@ void setup() gid = getegid(); sprintf(fname, "t_%d", getpid()); - if ((fd = open(fname, O_RDWR | O_CREAT, 0700)) == -1) - tst_brkm(TBROK | TERRNO, cleanup, - "open(%s, O_RDWR|O_CREAT,0700) failed", fname); - else if (write(fd, &buf, strlen(buf)) == -1) - tst_brkm(TBROK | TERRNO, cleanup, - "write(%s, &buf, strlen(buf)) failed", fname); - else if (close(fd) == -1) - tst_brkm(TBROK | TERRNO, cleanup, "close(%s) failed", fname); + + SAFE_FILE_PRINTF(cleanup, fname, "davef"); } -void cleanup() +static void cleanup() { TEST_CLEANUP; -- 1.7.9.5 ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. A cloud service to automate IT design, transition and operations 2. Dashboards that offer high-level views of enterprise services 3. A single system of record for all IT processes http://p.sf.net/sfu/servicenow-d2d-j _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list