Re: [LTP] [PATCH v2] getrusage04: add opportunity to increase the max [us]time increment

[Filippo ARCIDIACONO <filippo.arcidiacono@st.com>]

> -----Original Message-----
> From: Caspar Zhang [mailto:caspar@casparzhang.com]
> Sent: Monday, March 05, 2012 11:52 AM
> To: gaowanlong@cn.fujitsu.com
> Cc: Filippo ARCIDIACONO; ltp-list@lists.sourceforge.net
> Subject: Re: [LTP] [PATCH v2] getrusage04: add opportunity to increase
> the max [us]time increment
> 
> On 03/05/2012 05:33 PM, Wanlong Gao wrote:
> > On 03/05/2012 05:30 PM, Filippo ARCIDIACONO wrote:
> >
> >>
> >>
> >>> -----Original Message-----
> >>> From: Caspar Zhang [mailto:caspar@casparzhang.com]
> >>> Sent: Monday, March 05, 2012 8:55 AM
> >>> To: Filippo ARCIDIACONO
> >>> Cc: ltp-list@lists.sourceforge.net
> >>> Subject: Re: [LTP] [PATCH v2] getrusage04: add opportunity to
> increase
> >>> the max [us]time increment
> >>>
> >>> On 03/02/2012 10:39 PM, Filippo ARCIDIACONO wrote:
> >>>>> -----Original Message-----
> >>>>> From: Filippo ARCIDIACONO [mailto:filippo.arcidiacono@st.com]
> >>>>> Sent: Thursday, February 23, 2012 11:58 AM
> >>>>> To: ltp-list@lists.sourceforge.net
> >>>>> Cc: Filippo Arcidiacono; Salvatore Cro
> >>>>> Subject: [PATCH v2] getrusage04: add opportunity to increase the
> max
> >>>>> [us]time increment
> >>>>>
> >>>>> On slow systems it could be needed to increase the max value
> >>> [us]time
> >>>>> increment beetween two getrusage calls.
> >>>>>
> >>>>> Signed-off-by: Filippo Arcidiacono <filippo.arcidiacono@st.com>
> >>>>> Signed-off-by: Salvatore Cro <salvatore.cro@st.com>
> >>>>> ---
> >>>
> >>> ...
> >>>
> >>>> Is this version ok for you, or there are any other comments?
> >>>
> >>> I meet some `DOS line endings` errors when I am trying to merge
> this
> >>> patch. Could you double check your patch with checkpatch.pl from
> kernel
> >>> source tree? (or my mail client is broken :-(...
> >>
> >> I checked the patch with checkpatch.pl and no issue are raised.
> >> I sent the patch by means of "git send-email".
> >
> >
> > Yes, it's all right.
> > see here:
> https://github.com/gaowanlong/ltp/commit/9d12e835fdcd3624619be8b47e0f10
> 9343fc35e4
> >
> 
> Yup, my thunderbird should be blamed :-(
> 
> BTW, according to the style guide, it's recommended to send patches in
> attachment format, you can generate such patches by adding --attach
> option with `git format-patch` command.

Thanks for the  suggestion.
I'll take into account next time.

> 
> Thanks,
> Caspar

Thanks,
Filippo


------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list