From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v4 1/2] net: Add tst_net_run helper
Date: Fri, 16 Nov 2018 14:51:11 +0300 [thread overview]
Message-ID: <09aff1dd-a89f-479b-49da-c0c776b08b91@oracle.com> (raw)
In-Reply-To: <20181113163008.9093-1-pvorel@suse.cz>
Hi Petr,
On 13.11.2018 19:30, Petr Vorel wrote:
> and use it in tst_set_sysctl
>
> + improve doc of tst_rhost_run()
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> Reviewed-by: Alexey Kodanev <alexey.kodanev@oracle.com>
> ---
> Hi,
>
> Maybe we could signal where error occurred:
> * return 0: ok on both lhost and rhost
> * return 1: failure on lhost
> * return 2: failure on rhost
> * return 3: failure on both lhost and rhost
>
It is only when there is no "safe" option, right? when doing cleanup?
Could we print TWARN message inside tst_net_run() in such case?
next prev parent reply other threads:[~2018-11-16 11:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 16:30 [LTP] [PATCH v4 1/2] net: Add tst_net_run helper Petr Vorel
2018-11-13 16:30 ` [LTP] [PATCH v4 2/2] net/ipsec: Add check for xfrm_user kernel module Petr Vorel
2018-11-16 11:51 ` Alexey Kodanev [this message]
2018-11-16 14:24 ` [LTP] [PATCH v4 1/2] net: Add tst_net_run helper Petr Vorel
2018-11-19 10:44 ` Alexey Kodanev
2018-11-19 15:40 ` Petr Vorel
2018-11-19 17:19 ` Alexey Kodanev
2018-11-19 17:38 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09aff1dd-a89f-479b-49da-c0c776b08b91@oracle.com \
--to=alexey.kodanev@oracle.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox