From: Aleksandar Markovic <Aleksandar.Markovic@rt-rk.com>
To: ltp@lists.linux.it
Subject: [LTP] ?==?utf-8?q? ?==?utf-8?q? [PATCH 2/3]?==?utf-8?q? testcases/kernel/syscalls/ioctl: Add test for RTC ioctls used to read and set RTC alarm time
Date: Thu, 23 Apr 2020 08:01:01 +0200 [thread overview]
Message-ID: <1037-5ea12f00-b-69f42580@222291961> (raw)
In-Reply-To: <20200422152841.13432-3-fbozuta1@gmail.com>
Similar to the situation in patch 1, you wrote:
+?? ?struct rtc_time rtc_set_alarm = {13, 35, 12};
In my opinion, this way of setting structure should be avoided.
Thanks,
Aleksandar
-------- Original Message --------
Subject: [LTP] [PATCH 2/3] testcases/kernel/syscalls/ioctl: Add test for RTC ioctls used to read and set RTC alarm time
Date: Wednesday, April 22, 2020 17:28 CEST
From: Filip Bozuta <fbozuta1@gmail.com>
To: ltp@lists.linux.it
CC: pvorel@suse.cz, Aleksandar.Markovic@rt-rk.com, laurent@vivier.eu
References: <20200422152841.13432-1-fbozuta1@gmail.com>
?
This patch tests functionalities of following ioctls:
RTC_ALM_READ, RTC_ALM_SET - Getting/Setting alarm time
Read and set the alarm time, for RTCs that support alarms.
The alarm interrupt must be separately enabled or disabled
using the RTC_AIE_ON, RTC_AIE_OFF requests. The third ioctl's
argument is a pointer to a rtc_time structure. Only the tm_sec,
tm_min, and tm_hour fields of this structure are used.
Signed-off-by: Filip Bozuta <Filip.Bozuta@rt-rk.com>
---
runtest/syscalls | 1 +
testcases/kernel/syscalls/ioctl/.gitignore | 1 +
testcases/kernel/syscalls/ioctl/ioctl_rtc02.c | 107 ++++++++++++++++++
3 files changed, 109 insertions(+)
create mode 100644 testcases/kernel/syscalls/ioctl/ioctl_rtc02.c
?
?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20200423/aabefe16/attachment-0001.htm>
next prev parent reply other threads:[~2020-04-23 6:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 15:28 [LTP] [PATCH 0/3] Add tests for a group of real time clock ioctls Filip Bozuta
2020-04-22 15:28 ` [LTP] [PATCH 1/3] testcases/kernel/syscalls/ioctl: Add test for RTC ioctls used to read and set RTC time Filip Bozuta
2020-04-23 5:57 ` [LTP] ?==?utf-8?q? ?==?utf-8?q? [PATCH 1/3]?==?utf-8?q? " Aleksandar Markovic
2020-04-22 15:28 ` [LTP] [PATCH 2/3] testcases/kernel/syscalls/ioctl: Add test for RTC ioctls used to read and set RTC alarm time Filip Bozuta
2020-04-23 6:01 ` Aleksandar Markovic [this message]
2020-04-22 15:28 ` [LTP] [PATCH 3/3] testcases/kernel/syscalls/ioctl: Add test for RTC ioctls used to turn on/off RTC interrupts Filip Bozuta
2020-04-23 5:43 ` [LTP] ?==?utf-8?q? ?==?utf-8?q? [PATCH 3/3]?==?utf-8?q? " Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1037-5ea12f00-b-69f42580@222291961 \
--to=aleksandar.markovic@rt-rk.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox