Re: [LTP] [PATCH] semop/semop04.c: fix a bug when running with -i option

[Jan Stancek <jstancek@redhat.com>]

----- Original Message -----
> From: "Xiaoguang Wang" <wangxg.fnst@cn.fujitsu.com>
> To: ltp-list@lists.sourceforge.net
> Sent: Tuesday, 24 December, 2013 11:24:20 AM
> Subject: [LTP] [PATCH] semop/semop04.c: fix a bug when running with -i option
> 
> If we run semop04 like this: ./semop04 -i 2,
> its output will be:
> 
> semop04     1  TPASS  :  expected failure - errno = 11 : Resource temporarily
> unavailable
> semop04     2  TPASS  :  expected failure - errno = 11 : Resource temporarily
> unavailable
> semop04     1  TBROK  :  semctl() failed
> semop04     2  TBROK  :  Remaining cases broken.
> 
> Actually in the second iteration, semctl will return ERANGE. This is
> because the val variable will be less than zero in the sceond iteration.
> 
> Variable val should be reset to 1 before this actual errno test.
> 
> Signed-off-by: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>

Looks good:

Reviewed-by: Jan Stancek <jstancek@redhat.com>

> ---
>  testcases/kernel/syscalls/ipc/semop/semop04.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/syscalls/ipc/semop/semop04.c
> b/testcases/kernel/syscalls/ipc/semop/semop04.c
> index 2725378..f7efd86 100644
> --- a/testcases/kernel/syscalls/ipc/semop/semop04.c
> +++ b/testcases/kernel/syscalls/ipc/semop/semop04.c
> @@ -80,7 +80,7 @@ int main(int ac, char **av)
>  {
>  	int lc;
>  	char *msg;
> -	int val = 1;		/* value for SETVAL */
> +	int val;		/* value for SETVAL */
>  
>  	int i;
>  
> @@ -96,6 +96,7 @@ int main(int ac, char **av)
>  		/* reset tst_count in case we are looping */
>  		tst_count = 0;
>  
> +		val = 1;
>  		for (i = 0; i < TST_TOTAL; i++) {
>  
>  			/* initialize the s_buf buffer */
> --
> 1.8.2.1
> 
> 
> ------------------------------------------------------------------------------
> Rapidly troubleshoot problems before they affect your business. Most IT
> organizations don't have a clear picture of how application performance
> affects their revenue. With AppDynamics, you get 100% visibility into your
> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics
> Pro!
> http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
> 

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list